Jump to content

User talk:GZWDer

Add topic
From mediawiki.org
Latest comment: 3 months ago by Jack Phoenix in topic "Incompatible with temporary accounts" template

Dear GZWDer, Welcome to MediaWiki.org!

Yes, welcome! This site is dedicated to documenting the MediaWiki software, the software behind many wikis, including that of Wikipedia and the Wikimedia Foundation projects.
Please, take a look at the following pages. They might prove useful to you as a newcomer here:

If you have any questions, please ask me on my talk page. Once again, welcome, and I hope you quickly feel comfortable here, and find this site useful documentation of the MediaWiki software.

Thanks, and regards, --Liuxinyu970226 (talk) 11:25, 15 October 2013 (UTC)Reply

Emails to your Developer Account (uid=bugreporter,ou=people,dc=wikimedia,dc=org) are bouncing

[edit]

Recent emails sent to your Developer Account related to your use of the Toolforge project have bounced with the error message "552 5.2.1 Quota exceeded or service disabled." Please either update your Developer Account email address using the Preferences at https://wikitech.wikimedia.org/ or correct the problem on the email account side. If we continue to receive failure notices, the Toolforge admin team may be forced to disable your tools. --BDavis (WMF) (talk) 23:07, 20 April 2021 (UTC)Reply

@BDavis (WMF): I have changed the email. Can you resend it?--GZWDer (talk) 22:47, 21 April 2021 (UTC)Reply
The message that got my attention is not on the mail server anymore. If I remember correctly it was a notice from the wheel of misfortune script about a long running task on login.toolforge.org being terminated. Thank you for updating your contact email! --BDavis (WMF) (talk) 23:33, 21 April 2021 (UTC)Reply

"Incompatible with temporary accounts" template

[edit]

Hi,

I noticed this edit of yours, which flagged Extension:ArticleFeedbackv5 (AFTv5) as incompatible with temporary accounts. Now, as the current maintainer and the most active current developer of that extension, I have no doubt that the flag is correct — of course it'd be incompatible as the codebase hasn't been updated accordingly. :)

That said, I think that filing a bug report/feature request on WMF Phabricator with the appropriate tags set is a much better course of action, as it's something likely to be seen by myself as well as other people interested in helping out (if any). The MediaWiki.org documentation pages do not get nearly as much developer attention as the actual code does!

Furthermore, if you'd be interested in sharing your thoughts on how the extension should behave with regards to temporary accounts, that'd be super cool! I'm not very familiar with temporary accounts, although I am aware of the concept (and I think it's bad, but that's a completely different discussion, so let's not let me siderail this conversation ;-). If you have a patch to submit, that'd be even better! (Please note that as of right now, I'm trying to get this patch reviewed, so there can be some merge conflicts, although if you have a patch to add temp account support which merges cleanly...I'd be more than happy to +2 that after someone else has reviewed it, and instead rebase my patch if needed.) Jack Phoenix (Contact) 11:41, 30 August 2024 (UTC)Reply

@Jack Phoenix: This extension stores user id/text without using actor table (which should be migrated to actor table), so IPs will be leaked when interacting with AFTv5. The standard solution is to create a temporary account if unregistered users interacted with the feature. P.S. The database schema is still stored in raw SQL format; it should be converted to abstract schema, see phab:T259374. GZWDer (talk) 12:14, 30 August 2024 (UTC)Reply
To add temporary account support for an extension that store states is a bit complex, since in WMF wikis, after a temporary account is created, users are redirected to loginwiki to enable a global session. See gerrit:1057244. GZWDer (talk) 12:23, 30 August 2024 (UTC)Reply
Thanks for these links, very helpful!
Indeed, the choice to postpone the actor migration was an intentional one on my part, although in retrospect looks like it was a poor decision. At that time I thought that there was a lot of work to be done to make AFTv5 actor-compatible (something which might not've been true after all), and it seemed like not doing anything would also be a valid option. Seems like I need to look into that if I ever get the virtual database domain stuff sorted out and merged; it doesn't look that tricky, at least compared to how temporary accounts operate...
Regarding abstract schema, that is indeed true for AFTv5 as well as for all the things I maintain. Should someone come along and submit a patch, I'm happy to take a look and act accordingly but it's not a high-priority thing personally, because the current (hand-built) schemas work and have been tested on MySQL/MariaDB as well as SQLite, and of course PostgreSQL, so converting to abstract schema is more of a standards thing rather than a "doing this will gain us X, Y and Z and fix bugs A, B and C" thing. (Unless I'm wrong? Always happy to learn more so that I can assume less. :-)
With AFTv5 especially, it needs more than just the schema work for PostgreSQL, it also needs some app-level fixes. I tried implementing those (a while ago), but it was still failing CI on gerrit, and the failure looked like a legitimate, albeit an odd one at that. As I personally believe that good software should Just Work™ regardless of the DBMS used, getting that patch fixed up and merged is something I am interested in, but it's not the most high-priority item, given AFTv5's many other outstanding issues and that the main development target (Brickipedia) does run off of MariaDB, not PGSQL.
In any case, thanks again for those links! I've certainly not been following all the related (core) development progress too closely, and since people rarely, if ever, bother filing extension-specific tasks on Phabricator, things like these are more than likely to fly under a third-party developer's radar. Alas, I wish I could promise you that "AFTv5 will support actor and temporary accounts by <some date>" but I don't feel comfortable making such a bold statement; that said, I'm happy to see that you're interested in the state of AFTv5. It's a lovely piece of software. :-) Jack Phoenix (Contact) 19:36, 2 September 2024 (UTC)Reply