Jump to content

Topic on Talk:Continuous integration/Codehealth Pipeline

QualityGate failed with no issues listed in comment

3
Summary by PWangai-WMF

Made some configuration changes on "new code" definition to prevent alerts on changes unrelated to the patch.

MGrosse-WMF (talkcontribs)

In the comment by the bot on PatchSet 1 of this change: 1070555: Community updates: add missing instrumentation link id, it shows the quality gate as failed but all the items in the list below show still "0". When one clicks through to the analysis, this seems to be about problems in the linked file that existed prior to this change and on lines not touched by this change.

I'm not sure what the desired behavior here would be, but the status quo is not ideal. --~~~~

PWangai-WMF (talkcontribs)

@MGrosse-WMF Thank you for pointing this out. I have realized the new rules flagged issues unrelated to the change. I'm investigating to ensure the analysis focuses on new code, not legacy issues. I'll adjust the configuration to better align with our feedback process and prevent this undesired behavior.

PWangai-WMF (talkcontribs)

The current configuration treats any code changed in the last 30 days as new. I've updated this to consider only code changed since the previous version as new, so going forward, only code related to the specific patch will be analyzed.