Jump to content

Topic on Extension talk:Description2

Alex44019 (talkcontribs)

I've submitted a chain of six patches on Gerrit meant to improve the quality of generated descriptions, however, the author (as listed on the extension's page here) is unable to review them due to time constraints. I'd really appreciate if someone could perhaps review my changes for a merger.

The scope is rather big (effectively changing every bit of the logic), so please let me know if it'd be preferred to just fork the extension. I'm open to maintainership if needed, but (given I'm a newcomer to Gerrit and its projects, and this is my first Description2 patch) do not believe it'd be wise to go for that straight away.

These changes should also resolve the issues raised in "Multiple descriptions on file description page" and "references" threads.

Links, in order of dependency from top to bottom:

Changes #980054, #980055 and #980056 contain general summaries of all the changes.

Ciencia Al Poder (talkcontribs)

Thanks for the patches! I think they're of good quality. I did review them and they look good. However, I'm not sure what's going to happen with this extension, since the owner can't review them... I don't know if there are other "supergroup" members that can merge them. I'll try poking on IRC

Ciencia Al Poder (talkcontribs)

There's probably no chance other than Dantman merging those patches. Maybe with my comments he may have more confidence about the patches to merge them... I'd recommend to wait a couple of weeks, though, just in case someone else wants to also review them

Alex44019 (talkcontribs)

Alright, thank you very much!

Reply to "Code review request"