Jump to content

Topic on Extension talk:RevisionSlider

Broken click behavior on RTL wikis

24
Summary last edited by Aaron Liu 15:17, 12 March 2024 8 months ago

Should be fixed by task T352169.

IKhitron (talkcontribs)

Hi. Is there any hope the Revision Slider will work once on RTL wikis?

Thiemo Kreuz (WMDE) (talkcontribs)

I'm a bit surprised. RevisionSlider is RTL-compliant pretty much ever since. I just tested it on a random RTL page and it works fine, as far as I can see.

Maybe you can describe the problem in more detail? Are you referring to the Hebrew Wikipedia? Maybe you accidentally disabled RevisionSlider in your preferences?

IKhitron (talkcontribs)

I always liked the Slider, and used it a lot on hewiki. I also participated very heavily in discussions about its creation. It was very helpful and worked in perfect way. But about a year or more ago it broke. I explained the problem to the creators in details. Don't remember if it was on this page, on Phabricator or anywhere else. Since then I'm waiting for the fix.

Now for the problems. There are two, and looks like they are interconnected and probably even have the same cause. The smaller problem is that clicking to "move to the previous screen" sometimes responds unexpectedly, didn't find any rules for this part. The bigger problem is that clicking on some particular revision always finds some another revision of the page. There was no case in all this time that I get the revision I expected to get, even by chance. Maybe it's because of RTL, because I suspected that if one clicks on fifth revision from the left on a current screen, they get the fifth revision from the right, and vice versa. But I'm not sure about this counting, maybe I'm wrong.

Thiemo Kreuz (WMDE) (talkcontribs)

This sounds like it's related to phab:T336729 and maybe phab:T349208. I believe I can reproduce the issue now. I created a new ticket for us to keep track of it, see phab:T352169. Thanks a lot for the detailed report! We will definitely look into this.

A temporary workaround I found is to collapse the tools menu on the left. It looks like RevisionSlider works as expected without this menu.

IKhitron (talkcontribs)

No, all this does not fit the problem. I never uncollapsed the side menus, all three of them - main, tools, and TOC.

IKhitron (talkcontribs)

Let's create an example. I have an URL like this. It's exactly one revision diff. I open it. I click on RevisionSlider. I click on some revision on the left part of the slider. I get this, one old dot and two new dots. I try in the old Vector, I get this, three new dots. Back in Vector 2022. I add uselang=en. I get this, one old dot and one new dot, exactly as expected. Also, safemode does not help in this problem.

IKhitron (talkcontribs)
IKhitron (talkcontribs)

Well, 23 day later, no answers.

Thiemo Kreuz (WMDE) (talkcontribs)

The Technical Wishes team is tracking this via phab:T352169 and already invested quite some time in this and related issues, notably phab:T336729. Unfortunately we couldn't figure it out so far. What we know is that the underlying issue is probably as old as RevisionSlider itself. The reason we only see it now is because of the new Vector skin. We are very much interested in fixing this but need to invest our very limited resources wisely. For the moment the product decision was made to give this a lower priority as it's not blocking users from working with the history.

IKhitron (talkcontribs)

Both of these tickets have nothing to do with the problem, @Thiemo Kreuz (WMDE). They are about menus in Vector 2022, when I'm talking about the fact that the Slider does not work at all in all the skins.

IKhitron (talkcontribs)

Hello, @Aaron Liu. Could you tell me, please, why did you reverted this edit? The phabricator ticket has nothing to do with the problem. Thank you.

Aaron Liu (talkcontribs)

1. 14 minutes later, that account did some quite banal vandalism on another page. I assumed this one was also vandalism. 2. The slider seems to work as expected?

IKhitron (talkcontribs)
  1. I see, Aaron Liu, thank you. 2. The slider does not work on RTL wikis more than a year, at least for me.
Aaron Liu (talkcontribs)

Yeah, I've tried your link with the default language and it works perfectly for me.

IKhitron (talkcontribs)

It worked for me to once or twice, and didn't work dozens of times, as you can see in the screenshots.

IKhitron (talkcontribs)

A couple of months later. Is there something new? Maybe you should just remove the RevisionSlider at all on RTL wikis until you found and fix the problem. As with graphs or wikicode highlighting. For now, it just takes space.

Aaron Liu (talkcontribs)

You can collapse it, and it works for a lot of people. Also, the linked task has had a lot of patches lately. Maybe it'll be fixed when you check back next Wednesday?

IKhitron (talkcontribs)

What do you mean in "you can collapse it", @Aaron Liu, how does it help in all the screenshots I brought? I'll check, no problem, but the fix is about Vector 2022, and the RevisionSlider does not in any design.

Aaron Liu (talkcontribs)

Clicking on the header of the revision slider can prevent it from taking up that much space.

IKhitron (talkcontribs)

Still a non-working feature better will not appear at all.

Aaron Liu (talkcontribs)

Feels like we're talking in circles :p It works in Hebrew for me

IKhitron (talkcontribs)

Yap. It just means there are some conditions to work and different ones not to work. I have a suspicion that it can depend on browser, but I can't approve or disapprove this, because I really don't know what happens inside the RevisionSlider, and how to debug it. If this is the problem, it works wrong at least in Samsung Internet, last version. But the condition must be something completely different either.

Thiemo Kreuz (WMDE) (talkcontribs)

Hey all! Thanks a lot for the patience. We kept working on this the past months, one step at a time, and documented our findings in phab:T352169. The one remaining issue we have been able to reproduce on our machines is finally gone with the current MediaWiki release. Please let us know if it works for you as well.

IKhitron (talkcontribs)

Well, @Thiemo Kreuz (WMDE), I've checked now, on hewiki, and all the problems looks to be disappeared. On different skins. Don't know how it's possible, I never make more than 100% screen, but still. I'll try a couple more times in case in the next few weeks, to check if I've missed something, but I really hope that this time everything is fine.