Jump to content

Topic on Extension talk:Display Title

Updating Display Titles in links broken since MW 1.35

7
Planetenxin (talkcontribs)

Initial Situation:

  • A page "DT1" with content {{DISPLAYTITLE:Display Title 1}}
  • A second page "DT2", that links to the first page [[DT1]]

Expected Result:

  • On page "DT2" the link is rendered as "Display Title 1" → this works

Steps to reproduce

  • Change content of page "DT1" to {{DISPLAYTITLE:Display Title 2}}
  • Make sure, jobs are run
  • Refresh (F5) page "DT2"

Expected result:

  • On page "DT2" the link is rendered as "Display Title 2" → this fails - page is not updated still showing "Display Title 1"

The above worked with MW 1.31 and DT 2.2.0. For MW 1.35+ no version is updating the links anymore. Manual purging of "DT2" updates the link as expected. To my opinion this need to happen automatically.

Kghbln (talkcontribs)

The wiki was still serving an outdated version with other issues. I just updated it to 3.3, the last version supporting MW 1.35.

I just tested a bit and can confirm that you need to manually purge the pages to update the display title in links.

Cindy.cicalese (talkcontribs)

I confirmed this behavior on MW 1.39 with DisplayTitle 4.0.1. Please feel free to submit a patch that would trigger an update on pages linking the the current page on page save complete - preferably only if the display title changed, but I'm not sure how hard it would be to get access to that state information in the hook.

Planetenxin (talkcontribs)
Cindy.cicalese (talkcontribs)
Cindy.cicalese (talkcontribs)

@Planetenxin@Kghbln Could one or both of you please test/review the patch linked above to determine whether it adequately addresses the issue? I am waiting for review before merging the fix. Thank you.

Kghbln (talkcontribs)

I currently do not have a 1.39 at hand for testing. I will need to update sandbox.s-mw.o soon. It is on my list. Anyhow, I expect Planentenxin to be faster than me.

Reply to "Updating Display Titles in links broken since MW 1.35"