Jump to content

Topic on Extension talk:Purge

Broken with MW 1.40-alpha, i.e. with master?

6
Summary by Kghbln

Issue tracked with on GitHub and with task T312149.

Kghbln (talkcontribs)

@Original Authority: This edit of yours suggests that the extension is broken on MW 1.40-alpha (current master). Did you confirm this with a test? If yes it will be good if you created an issue report on GitHub?

Kghbln (talkcontribs)

Thanks for your edit. There appears to be a difference between SkinTemplateNavigation and SkinTemplateNavigation::Universal, with only the latter being removed some time.

@Samwilson: Since you worked on this extension in the past you will probably have a better insight into potential worries in the future.

Samwilson (talkcontribs)

@Kghbln: Yes, it seems the error with 1.40 is: "Deprecated: Use of SkinTemplateNavigation hook (used in MediaWiki\Extension\Purge\Hooks::onSkinTemplateNavigation) was deprecated in MediaWiki 1.39. [Called from MediaWiki\HookContainer\HookContainer::run in mediawiki/includes/HookContainer/HookContainer.php at line 137]" It shouldn't be too hard to fix.

I don't use this extension any more (because the functionality is now part of Cargo), so I'm not sure if I'll find the time to make a fix for it. Sorry!

Kghbln (talkcontribs)

Thanks a lot for your info and for shedding some light on the issue. No worries if you do not find the time to fix the issue.

Original Authority (talkcontribs)

Apologies, I missed this and reverted my edit. It turns out that despite the hook being depreciated, it has not been removed yet and the extension does still work, it will probably not work in the future when the hook is removed, however.

Kghbln (talkcontribs)
Reply to "Broken with MW 1.40-alpha, i.e. with master?"