Topic on Talk:NewPP parser report/Flow

I have updated the data section of the PP parser, however, I can find no data on the "Complications:" field here or on the wiki. I thought it may have been the Linters, though I have dispelled that thinking. Any pointers?

fwiw I can see the reports in https://doc.wikimedia.org/mediawiki-core/1.34.0/php/Parser_8php_source.html though we don't apparently state purpose there, and I cannot find when we introduced it into the code.

The "Complications" item is added in the makeLimitReport() function, with contents generated via getAllFlags(). The information that getAllFlags() returns is in turn defined via setFlag() (though that's tagged as deprecated in favor of setOutputFlag(); your guess is as good as mine for why the deprecated function would be used here). I don't know what calls setFlag(), or with what values, or when any of this was added. Poking around some on Phabricator, this field has existed since at least November 2019 (per this comment), but I couldn't find any mentions of it beyond incidental inclusions in copy-pasted NewPP output.

EDIT: looking around on en.WP, I also found this mention in August 2019, which pushes back its introduction a bit more.

I know this isn't much, but it at least narrows down some when it could've been added, and maybe it'll help you out a bit.

@Aaron Schulz: I am told that this is part of code that you introduced. I am still hunting up the MW version and whether there is phabricator to hunt down the background. Thanks.

• MediaWiki 1.34/wmf.8
• gerrit:c/mediawiki/core/+/513178

though that doesn't explain it to me and still looking for the phabricator ticket

Parent: 7faa7a74 (Factors out permissions check from User into PermissionManager service)
Author: Aaron Schulz <aschulz@wikimedia.org>
AuthorDate: 2019-05-29 10:55:57 -0700
Commit: Aaron Schulz <aschulz@wikimedia.org>
CommitDate: 2019-05-29 10:58:56 -0700

parser: list the vary-* flags in the NewPP report HTML comment

Change-Id: I5a4afba2bfdb5b5b56ba0a01ed8ff444a67fbb1a

Can see a particular addition at gerrit:c/mediawiki/core/+/519352/ for "vary-page-id"

parser: add speculative page IDs to use with 1449658 This works similarly to speculative rev IDs with . Re-parses can be avoided if the page ID is correctly guessed. Also make the 0 parser function set vary-page-id. Bug: T226785 Change-Id: I0b19be45e6ddd6cde330bfcd09d243e4e5beda01

which leads me to

• https://doc.wikimedia.org/mediawiki-core/REL1_34/php/CoreParserFunctions_8php_source.html

which seems to have a string of vary-* messages

See that the messages have been shifted to their own file in later version

• https://doc.wikimedia.org/mediawiki-core/master/php/ParserOutputFlags_8php_source.html