Jump to content

Topic on Module talk:TNT

Edit request: Correctly handle `null` values in `TemplateData` fields

11
Summary by ExE Boss

{{Edit Protected}}

ExE Boss (talkcontribs)
Yurik (talkcontribs)

Can't -- there is a failing unit test there - I suspect after one of the recent edits. I left a comment to the author - but feel free to fix it.

ExE Boss (talkcontribs)

That failing unit test is unrelated to my change (which passes test_doc).

Yurik (talkcontribs)

I was hoping to just copy/paste things. I will temp-revert the TNT sandbox to see if it works as is

ExE Boss (talkcontribs)

You can also run the tests while editing by using the Preview page with this template feature with Module:TNT/testcases as the target page.

Yurik (talkcontribs)

One more thing - could you add a unit test that shows the bug your change fixes?

This post was hidden by ExE Boss (history)
Yurik (talkcontribs)

Thanks! True, I could test it that way, but it only works if all tests are already in place, plus I do want to have a historical record of "this specific revision worked ok, and i copied it as is" :)

Yurik (talkcontribs)

thanks a lot for all the hard work on this, copied! :)