Jump to content

Topic on Manual talk:Hooks/UserInvalidateEmailComplete

Not entirely convinced this is an actual hook, seems to be a typo in extension code

5
Summary by SamanthaNguyen
SamanthaNguyen (talkcontribs)

I don't believe this is an actual hook, and may have instead have been a typo and thus dead code.

The only extension that has subscribed to this hook, according to Codesearch, is CentralAuth, originally in gerrit:61912; however, there is no actual hook named "UserInvalidateEmailComplete" in MediaWiki core, at least as in master.

I tried going back all the way to the 1.23 branch, as the time this version of MediaWiki was developed was about the same time the patch was created (earliest branch possible, REL1_23). I could only find the InvalidateEmailComplete hook on https://github.com/wikimedia/mediawiki/blob/REL1_23/includes/User.php#L3998.

Does anyone suspect the same? Should this be put up for deletion? And if need be, I can write up a phab ticket too.

SamanthaNguyen (talkcontribs)
Skizzerz (talkcontribs)

It's a typo for sure, the HISTORY entry that introduced the hook mentions InvalidateEmailComplete. I see no reason to keep the manual page around so I deleted it.

Pppery (talkcontribs)

Someone should definitely file a Phabricator task pointing out that CentralAuth calls a non-existent hook.

SamanthaNguyen (talkcontribs)

Thanks everyone, I've filed phab:T261034 and will mark this thread as resolved.