Jump to content

Topic on Extension talk:WikiEditor

Compatibility issue with Page Forms

6
Drfoland (talkcontribs)

WikiEditor 1.32 has a compatibility issue with the Page Forms extension. This is due to the fact that

$.wikiEditor.modules.dialogs.config = {
    ...
};

has been replaced with

module.exports = toolbarConfig;

Page Forms still relies on the jQuery module, and thus fails to render the WikiEditor toolbar when using the form editor. This is easy to resolve by redefining the jQuery module for backwards compatibility, but may be more appropriate to resolve with the Page Forms team.

Jdforrester (WMF) (talkcontribs)

We won't bloat the experience for all users of WikiEditor just to provide compatibility for PageForms; the maintainers of code dependent on WikiEditor are responsible for maintaining that, sorry.

Whatamidoing (WMF) (talkcontribs)

Pinging @Yaron Koren, because this incompatibility should probably be documented somewhere (assuming it can't be fixed).

Yaron Koren (talkcontribs)

I thought this was fixed in Page Forms already, but maybe not. What version of Page Forms are you running? Or are you just looking at the current code?

Hazeldee0512 (talkcontribs)

Hi @Yaron Koren -- I'm having this exact issue with PF 4.5.1 and WikiEditor 0.5.2. Have you been able to implement a fix yet?

Jongfeli (talkcontribs)

It seems that after the changes done in WikiEditor going from 1.34.0-wmf.16 to 1.34.0-wmf.17 WikiEditor stopped working inside a form.

This means when you use WikiEditor version 1.34.0-wmf.16.zip it works just fine inside a form.

This was with tested and works on:

  • MW 1.34.4
  • SMW 3.2.0
  • Page Forms 5.0-alpha (9e17cd7)
  • WikiEditor 1.34.0-wmf.16
  • PHP 7.3.23

I am not sure what has to be done to get the later versions of WikiEditor to work in a form, a lot has changed since then but this probably needs to be solved in Page Forms.

Reply to "Compatibility issue with Page Forms"