Hey, I just saw Special:Diff/3858844, The code I wrote would very likely explode majestically if we use "notnull" instead of "NotNull". Where did you see the DBAL docs? I can work on it and fix it though, not too complicated.
Topic on User talk:Tgr (WMF)/Flow
Sorry, I assumed it's case insensitive because both the page and your patches already had mixed case (`Notnull` and `NotNull`).
The docs I mentioned are https://github.com/doctrine/dbal/blob/2.10.x/docs/en/reference/schema-representation.rst
It can still work fine with both and I don't mind lower case either. It's that setOption in Column.php is like this: https://github.com/doctrine/dbal/blob/2.10.x/lib/Doctrine/DBAL/Schema/Column.php#L75 so I assume "setnotnull" wouldn't work. I dig deeper and let you know.
hmm, it's because php function calls are case insensitive: https://stackoverflow.com/a/5643544/2596051 so it doesn't matter which way. There's pros and cons:
- "NotNull" is closer to the actual declaration
- "notnull" is easier to read, looks better IMO.
I don't know which way to go TBH.
Given the docs, I would say latter. Let's go with the latter.