Topic on Skin talk:Metrolook

change:

skin.json: "MediaWiki": ">= 1.36.0"

to

skin.json: "MediaWiki": ">= 1.34.0"

and then

replace every occurrence of makeMetroLookListItem with makeListItem in /skins/Metrolook/MetrolookTemplate.php

as well as the last line from:

return $this->getSkin()->makeListItem( $key, $item, $options );

to

return parent::makeListItem( $key, $item, $options );

I'm running:

• MW 1.34.1 (b1f6480) 18:15, 30 April 2020
• git clone -b REL1_34 https://github.com/wikimedia/mediawiki-skins-Metrolook.git

but i'm having some minor issues and was wondering if the developers would recommend using -b master

Please advise. What is the best version for most up-to-date version compatible with MW 1.34.x. Thansk!

I've found that the REL1_35 release of Metrolook is incompatible with MW 1.34.x, due to use of Skin::makeListItem() which doesn't exist. (Metrolook commit b8f4807ccc6f3f9b)

So.. I installed version:REL1_35 in my MW 1.34.4 wiki and then replaced every occurrence of makeMetroLookListItem with makeListItem in /skins/Metrolook/MetrolookTemplate.php and it seems to be working great!

Note - this effectively just "undoes" metrolook commmit b8f4807ccc6f3f9b114ada830d664703e02aee68

change:

skin.json: "MediaWiki": ">= 1.36.0"

to

skin.json: "MediaWiki": ">= 1.34.0"

and then

replace every occurrence of makeMetroLookListItem with makeListItem in /skins/Metrolook/MetrolookTemplate.php