Topic on Talk:Gerrit/Privilege policy

Amending patches from other users requires you to be added to the Trusted-Contributors gerrit group, or be in privileged gerrit groups.

(transplanted from https://www.mediawiki.org/w/index.php?title=Topic:Vayass3b7l22mjxt&topic_showPostId=vayn7p2ps4ofdpkl&fromnotif=1&markasread=1034884&markasreadwiki=mediawikiwiki#flow-post-vayn7p2ps4ofdpkl)

Who can amend other's changes? How to deal with the message above the best way? « Saper // talk » 09:35, 12 November 2019 (UTC)

Hi @Saper,

changes (in this case patches) which are not your, can't be amended by you or me. Only by original uploader or user which have +2 in related repository.

Best regards,

Zoran.

@Saper Please try again. I made something.

@MarcoAurelio thanks, what has changed? The original change got merged, but I tried this on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/118981 (not sure how it works, since previously I have participated in this).

@Saper What Zoran mentioned above is true. Due to abusive use in the past of the ability to add patch sets to the work made by others, this ability is now restricted to patch owners, repository owners and members of some gerrit groups. This includes a group called Trusted-Contributors. I added you yesterday to test if my lecture of the gerrit permissions was right. I have removed you for now from said group because with this new Gerrit Privilege Policy in place it looks each and every Gerrit permission must be discussed and approved in advance. I have filed phab:T238649 requesting that you be formally added. Sorry for the bureaucracy, but it looks those are the rules now. I hope it won't take long to have you formally approved. Best regards.

Thanks... the policy says nothing about "trusted users" so I was a bit baffled if this is a glitch or intentional thing. Thank you again - will follow on Phab!

The policy is not quite clear for me in what a "privilege" is or how that should be interpreted. I opted to follow the safests of the paths. If the discussion results in that there's no need for Tasks to add people to that group, I'll be more than happy to follow that consensus. Regards.

@MarcoAurelio I appreciate your approach and the efforts. It worries me that this has become so burdensome. So much for "attracting new developers to the project" etc. etc. Although I am a pretty old one :)