Jump to content

Topic on Help talk:Extension:Linter/Flow

attributes with unpaired quotes

13
Summary last edited by Trizek (WMF) 14:36, 9 January 2019 5 years ago

Notice about a parsing change that causes this will go out in Tech News when more information will be given.

Bdijkstra (talkcontribs)

Consider the following wikicode:
{| style="background-color: #eb6841; style="text-align: center;"

It seems that with Tidy previously, the table would not be colored red, but with RemexHTML now it does. Should this be flagged by the linter?

Arlolra (talkcontribs)
Bdijkstra (talkcontribs)

Ah OK. But since this parsing change, a page's layout can break via an unrelated edit, so I would have expected a notice in Tech News to at least prevent confusion.

Arlolra (talkcontribs)
Bdijkstra (talkcontribs)

A broken page layout is not always noticed, and even then not always reported. So I think it would be good to let technical editors know which patterns are now treated differently.

Arlolra (talkcontribs)
Bdijkstra (talkcontribs)

Great, thanks. I'm glad that you watch this page! :)

Trizek (WMF) (talkcontribs)

Hey, I'm handling Tech News for this week.

How would you summarize that change in one sentence? How will in impact users? Do you have a tracking ticket on Phabricator about that?

Thanks!

Trizek (WMF) (talkcontribs)

Since I have no reply but I have to wrap-up and freeze the current issue, I've posted your previous explanation to next week issue.

Please provide there a shorter explanation. :)

Trizek (WMF) (talkcontribs)
Bdijkstra (talkcontribs)

Not from me. I assumed you were asking @Arlolra. I don't understand the change well enough to be able to figure out which wikicode patterns are now treated differently.

Arlolra (talkcontribs)

How about ...

Quoted attributes used to require being followed by a space, now they do not. Since this is a change to how a page is parsed it could cause unmodified portions of the page to render differently on edit.

Johan (WMF) (talkcontribs)

Thanks! I simplified that a fair bit, for the benefit of non-native and/or non-technical readers. You can see the draft at m:Tech/News/2019/03.

Reply to "attributes with unpaired quotes"