Jump to content

Topic on Talk:Gerrit/New repositories/Requests

Have a conversation about moving this process to Phabricator

9
Summary by MarcoAurelio

Declined. No community interest and no consensus with the current repository creators (mainly QChris). MarcoAurelio (talk) 12:42, 7 August 2020 (UTC)

MarcoAurelio (talkcontribs)

Good day. @Hashar suggested on IRC the other day to have a conversation about migrating the system to request new gerrit repositories to Phabricator. I see that work was done in that regard in the past but never saw light (and it's outdated, but can be updated real quick). Ideally this should all be in one place either keep it here at mediawiki or move it to Phabricator. Creating repos is something that is being done basically by @QChrisNonWMF so Hashar and myself agreed that we shouldn't do anything without consulting with him first as he does the vast majority of the repo creations. Regards.

Kizule (talkcontribs)
QChrisNonWMF (talkcontribs)

I do not care too much whether we use MediaWiki or some other tool to track repo requests.

For me, using MediaWiki for them is not extra nice, but it more or less works, and it for sure is good enough™. We do not have 100s of repo requests/day or something. I guess no one likes it, but it's very, very, very seldom I hear complaints about using MediaWiki for it. (And Phabricator would not address these complaints either). And the signal-to-noise ration from the watching of the pages is really good for me :-)

At some point someone took an effort to bring these requests to bugzilla. That never took off.

After some time, it was tried to bring these requests to Phabricator (as MarcoAurelio said already). It never took off either.

I am all for switching to a different tool, if it solves a real-world problem. Not sure things like "Tables suck in MediaWiki" are real-world problems though, because if $SOMEONE cannot be bothered to copy/paste the previous table row and adjust it for their request, chances are $SOMEONE cannot be bothered to fill out a Phabricator form either.

So the question for me would be: Which real-world problem is solved by switching to Phabricator?

MarcoAurelio (talkcontribs)

I feel the same as QChris above. We should stick to the place/system where requestors and people that create the repos feels more confortable working. If people think mediawiki.org is better suited for this, let's keep it here. If people think Phabricator would be a better place, let's move to there. I myself do not have a strong opinion and, like I said, I think the same as QChris above. In any case, requests should be all handled in one place (either here or at Phab.) for consistency. Thanks.

MarcoAurelio (talkcontribs)

On the other hand, most Gerrit stuff has been moved to Phabricator: issues and project ownership requests, so I'd say I lean towards using that platform a bit, provided that Phab is a place where people is comfortable working and requesting things.

AKlapper (WMF) (talkcontribs)

In https://phabricator.wikimedia.org/T238950#5685565 I wrote "(I'm also puzzled that https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests exists in parallel, but that's off-topic here.)" Confusingly, https://phabricator.wikimedia.org/project/profile/330/ states NOT to use Phabricator.

It would be georgeous to discuss and decide on one single place, instead of just opening more places in parallel (which seems like what happened here) to confuse people. (If it's too hard to make an educated decision then I'd propose that a person who opened the second place closes the second place. :P )

QChrisNonWMF (talkcontribs)

In phab:T259147#6365032 4 more items got were brought up by hashar:

> I have at least a couple use cases:
> 
> * have CI configured as soon as a repository is created. We do not actively monitor the mediawiki.org page and often catch new repositories after the fact. We have a Jenkins job comparing what is in Gerrit and what is configured in CI https://integration.wikimedia.org/ci/job/integration-config-qa/lastCompletedBuild/testReport/ .  Having a creation task flagged with #continuous-integration-config would flag the CI admins and should help having CI configured for them.
> 
> * when cleaning Gerrit from obsolete repositories (such as via #cleanup), it is often helpful to find whom/why a repository got created. That can be find in mediawiki.org though.
> 
> * Phabricator would make it easier to cc team/person to review a repository creation.
> 
> * The discussion seems easier to handle on Phabricator rather than on the Gerrit/New_repositories/Requests page.  But that is probably a bias on my side since I really dislike mediawiki notification system :]
QChrisNonWMF (talkcontribs)

They might be selling points for you, I'm not sure they are selling points for me.

Having CI configured as soon as the repo got created won't work. Most of the repos we create are empty, or have just a .gitreview file. There's not much to test there or do CI with. There's no PHP files, no tox. Sometime there isn't even a branch if requesters want a totally empty repo. Not sure there is a CI that does nothing is a benefit over no CI.

When it comes to finding how/why a repo got created, I find that quite convenient the way it is. For example a search on mediawiki for 'ArmchairGM' with a 'Page title contains' of 'Gerrit/New_repositories' gives a spot on result.

In Phabricator on the other side, I have a really hard time to find things, if I do not know the relevant tags/projects. And it's not easy to find the relevant tags/projects. But that might be a bias on my side, as I do not (yet) use Phabricator on a daily basis.

I'm not so sure CCing people is easier on wiki or Phabricator and whether discussion is easier here or there. I for one like that on the wiki pages, there is text. And less cruft about who subscribed and then unsubscribed a task and tokens and what not.

MediaWiki notifications have one huge benefit for me. They stick out. I get very few emails for MediaWiki. So when I do get one, I know I need to create a repo. But Phabricator spams me night and day about tasks that are not relevant for me. But that again might be a problem on my end.

That said, this thread started 1.5 years ago, and only 4 people (well ... 5 if you count hashar's comment on Phabricator that I copied over) chimed in. Not sure the pain or pressure to change things is enourmously big :-)

Valerio Bozzolan (talkcontribs)

(OT tip: unwatch some Phabricator projects, unsubscribe from Phabricator not interesting Tasks and change your Phabricator email preferences :) eventually ask how to configure Herald to get just what you want, without getting everything.)