Topic on User talk:Thibaut120094/Flow

Well, while I agree that your frwiki has a large number of articles that are having wrong, those don't seem to be unfixable by you, aren't they?

Neither purging nor null editing, but in fr:Module:Wikidata/Récup:

function p.loadEntity(entity, cache)
	if type(entity) ~= 'table' then
		if cache then
			if not cache[entity] then 
				cache[entity] = mw.wikibase.getEntity(entity) --Can't you change it to 'cache[entity] = mw.wikibase.getEntityObject(entity)'?
				mw.log("cached")
     		end
			return cache[entity]
        else
			if entity == '' then
				entity = nil
			end
        	return mw.wikibase.getEntity(entity) --Can't you change it to 'return mw.wikibase.getEntityObject(entity)'?
        end
    else 
    	return entity
    end
end

Hi Liuxinyu970226,

I don't understand why you come here on my talk page to scold me about this, I didn't change the priority of T170039 and I'm not the author of the module. If you have ideas how to fix this bug you're welcome to add a comment in the ticket, submit a patch, or contact the main authors of this module (Zolo & Zebulon84).

I find your tone here and in Phabricator (T106687 for example) very condescending and sometimes aggressive, if someone makes a mistake or don't have the same opinion than you, you need to stay cool.

Regards.

Liuxinyu970226 : the doc of mw.wikibase.getEntityObject is : "Alias for mw.wikibase.getEntity."

I doubt replacing a function by it's alias would change anything.

If you are absolutely sure there is a difference, you should first change the documentation.

Regards.