Jump to content

Topic on Talk:Reading/Web/MobileFrontend and Minerva

Missing "Why is it helpful to have them in the same repository..." section

3
Phuedx (WMF) (talkcontribs)

For example:

  • If MobileFormatter changes the way that content is transformed, then Minerva is likely to be updated soon after – it's unlikely (but possible) that a change to Minerva would cause a change in MobileFormatter soon after.
  • Vendoring libraries on a per-extension basis is hard.
Jdlrobson (talkcontribs)

I forgot to add "IN progress" which I've done now and I've started filling in new sections. I've also outlined a draft proposal to give a sense of where I'm going with all this. I hope this clarifies my thinking a little more.

I'm curious if you could go into more detail about "a change to Minerva would cause a change in MobileFormatter soon after.'

Can you give an example?

From my perspective if these two components are separate they should be agnostic to

changes.

I see purpose of MobileFormatter is to provide content in a well defined format to Minerva.

The desktop version of Minerva (useformat=desktop&useskin=minerva) doesn't use MobileFormatter at all.

Can you expand on Vendoring libraries on a per-extension basis is hard?

Which libraries would both Minerva and MobileFrontend make use of?

I should note my main concern is making it possible to separate in future the two repos, not to necessarily pull them apart. A git submodule might help with problems like these, but right now I'm not seeing concrete examples of where we'd need to vendor libraries between them.

Phuedx (WMF) (talkcontribs)

Sorry for not getting back to you sooner, @Jdlrobson.


I see purpose of MobileFormatter is to provide content in a well defined format to Minerva.

I think you hit the nail on the head. MobileFormatter and Minerva are coupled. This should be acknowledged. AFAICT the intention here is to both formalize that coupling and loosen it slightly.


The desktop version of Minerva (useformat=desktop&useskin=minerva) doesn't use MobileFormatter at all.

Do we actually support desktop Minerva? I see your point but I'm not sure whether to accept your premise.


Can you expand on Vendoring libraries on a per-extension basis is hard?

Now that you've done work on this project, I see that your intention wasn't to vendor MobileFormatter and make MobileFrontend depend on it. My comment isn't relevant.

Reply to "Missing "Why is it helpful to have them in the same repository..." section"