Topic on Talk:Fundraising tech/Chat/Ingenico Connect

See this spike: https://phabricator.wikimedia.org/T152649

And the code: https://github.com/Ingenico-ePayments/connect-sdk-php

SDK docs: https://developer.globalcollect.com/documentation/sdk/server/php/

Do we like the looks of their code?

• Is it easy to use?
• Is there any advantage to crafting our own REST requests?
• Will it be easy to unit test?

Drawbacks of using the SDK:

• To get logging, we have to make something that implements their CommunicatorLogger interface, can't just plug in monolog.

Code seems like a classic PHP inheritance stew, but readable enough and it's already there so I definitely think we should use it. One problem I see is that it requires PHP5.4 and we are still dependent on 5.3

One giant positive from using the SDK: we get to delete all the crazy XML functions from the base gateway adapter class. Actually, we'll get to do that even if we make our own REST requests. So yay either way!

After further investigation, the Ingenico SDK seems good enough to handle the API layer, and it's supported, which is great. This leaves us with the responsibilities of the forms (DonationInterface), and configuration, fraud checking, DB/queue interaction, and certainly other things I'm not thinking of, which are all in SmashPig right now. A more composition-based approach might look like pulling fraud checking, and whatever other things, into standalone modules so that SmashPig's responsibility could be as close to just implementing them and providing configuration as possible. For the time being SmashPig could contain shims for anything that became its own repo.