Jump to content

Topic on Extension talk:RevisionSlider

Released with deprecated functionality, and how to switch offf?

8
Summary by Addshore

Tickets have been filed for all points mentioned, and many have already been tackled and will soon be deployed (Monday 28th).

Expanded docs on mw.org, jQuery deprecation warnings, User option to hide, HelpDialog doesn't have static name, Use Map.get instead of Map.values & Lazy Loading

PerfektesChaos (talkcontribs)

Page seems to throw a pile of warnings now?

  • This page is using the deprecated ResourceLoader module "jquery.ui.widget".
  • This page is using the deprecated ResourceLoader module "jquery.ui.core".
  • Use of "Map-values" is deprecated. mw.Map#values is deprecated. Use mw.Map#get() instead.
  • OO.ui.WindowManager#addWindows: Windows must have a `name` static property defined.

At least partially caused by this extension and tracked back.

If I do not want to load and execute this JavaScript stuff, where can I configure to be kept in peace?

Addshore (talkcontribs)

I have just confirmed that the "Use of "Map-values" is deprecated. mw.Map#values is deprecated. Use mw.Map#get() instead." messages do indeed come from the RevisionSlider. I created a ticket on phabricator and have uploaded https://gerrit.wikimedia.org/r/#/c/323094/ which should resolve these. The other warnings to not appear to come from the RevisionSlider extension.

The RevisionSlider bar loads mostly without JavaScript and currently there is no user option to disable / remove the bar.

Schnark (talkcontribs)

All these warnings are caused by the RevisionSlider: ext.RevisionSlider.SliderView has a dependency on jquery.ui.draggable (which itself depends on jquery.ui.widget and jquery.ui.core), and ext.RevisionSlider.HelpDialog.js does create a window without a static name.

Addshore (talkcontribs)

Ahh, indeed RevisionSlider also appears to contribute those deprecation notices, they still appear for me locally with RevisionSlider disabled as other extensions also pump out the same notices.

I have created https://phabricator.wikimedia.org/T151448 regarding the HelpDialog windows without a static name.

PerfektesChaos (talkcontribs)

WRT deprecated warnings (Thanks @Schnark):

  • They occur on pages with no gadgets at all, nothing else than MediaWiki issued stuff, and RevisionSlider is the only thing with a UI, and there has been silence until yesterday.
  • Unfortunately they do not permit simple tracking down; if they are caused by something but not directly called it is hard to identify which circumstances are triggering them, by calling something on top.

WRT Opt-Out:

  • On every diffpage call the new gadget is unconditionally loading in the background the full history of 20 or whatever previous versions.
  • The API calls require about 30 kB of additional traffic, depending on summary lengths.
  • This is not acceptable for slow or expensive connections.
  • I am interested to see the difference between two particular versions I asked for. If I would like to analyse the history for recent years I will let you know.

On Preferences I can disable VE, MultimediaViewer, and indirectly ULS.

  • I can even request on Preferences that I want to see the comparison only without rendered page, for a decade now. Sometimes I make temporarily use of this config for specific maintenance tasks.

I want to get a chance to bail out from this tool asap.

Addshore (talkcontribs)

The patch fixing the HelpDialog deprecation note has been merged. This only leaves the jquery.ui.draggable deprecation notice (and the 2 that result from that). jquery.ui.draggable is also still used by other extensions, for example WikiEditor.

The extension is loaded (in the form of the collapsed bar) but the "20 or whatever previous versions" will not be loaded until the user requests to expand the RevisionSlider. This means the additional traffic of the requests is optional. This follows exactly your 4th bullet point. If the user lets the slider know that they want to use it, then it will make the requests and render.

As for a user preference to totally disable the collapsed RevisionSlider bar I have created a ticket on Phabricator to track the request.

Addshore (talkcontribs)
PerfektesChaos (talkcontribs)

Fine; thanks a lot.

I do appreciate lazy loading. I am running 30 gadgets on wikipages, and I preselect depending on circumstances, which of them will be actually triggered, and some are only sniffing and will complete loading and execution after individual request only, or interactive configuration change.

And when I leave city and enjoy German countryside, I have an internet connection slower than in the Australian outback.