Database migration fixed for the upcoming version 4.0.0.
I'm trying to install this extension for the first time today, and I had the aforementioned issues with 3.2.0 and 3.2.1. I tried installing the development version (4.0.0), and when I attempted to upgrade my wiki I had the following error:
Uncommitted DB writes (transaction from DatabaseUpdater::doUpdates). in .../includes/db/Database.php on line 4262
Any suggestions would be appreciated. Thanks!
Thanks for reporting this. From what version and to what version did you upgrade your MediaWiki installation?
Oh, and could you please elaborate what issues you had with the 3.2.x versions? Thanks.
I don't recall what the previous version was (sorry!). I recently upgraded to 1.26.3, but I didn't have this extension installed with the previous version.
And the previous issues were the database:ignore errors in 3.2.0 and the query error in 3.2.1 (which is still present since I cannot complete the wiki manual upgrade per the installation instructions)
OK, I've updated the database creation code to use a transaction. Hopefully this will prevent the error. Please try the latest commit from the development branch.
Still an issue. Something I didn't notice before in the text the upgrade tool was spitting out:
Creating Pubmed table ...
An error occurred:
[c98ccaec] /wiki/mw-config/?page=Upgrade MWException from line 3885 of .../wiki/includes/db/Database.php: Could not open ".../wiki/extensions/PubmedParser/includes../db/PubmedParser_Migration.sql".
It appears that PubmedParser_Migration.sql is not in that location, but in /wiki/extensions/PubmedParser/db, Would that matter?
Yes, of course. A missing slash caused this. I've pushed the fix.
I know I should have an automated test suite for the extension, and in fact I do do quite a lot of test-driven development, but somehow I have never gotten to terms with the MediaWiki testing environment...
