Jump to content

Topic on Manual talk:Extension registration/Flow

Comments (keys starting with @ in extension.json) not ignored in "SpecialPages" array

4
217.15.199.78 (talkcontribs)

Hello,

Special:Specialpages crashes (in SpecialPageFactory.php/getPage()/"$page = new $className;") if there are comments (like "@doc": "Something") under "SpecialPages" array in extension.json. It seems keys starting with "@" are not as filtered as this page suggests...

Legoktm (talkcontribs)

"@" is only ignored in the top level structure, or under the "config" key.

SPage (WMF) (talkcontribs)
Legoktm (talkcontribs)

Thanks. Re: Gather, that only works because ResourceLoader is ignoring the unknown parameter, I wouldn't depend upon it. The extension registry is still loading and caching that value on each request unlike "@" keys in top-level/config which are ignored in the parsing stage.