Jump to content

Topic on Extension talk:NoTitle

Not working with MW 1.23.2?

10
Mitchelln (talkcontribs)

Hi.

I've just upgraded a site to 1.23.2 and __NOTITLE__ no longer appears to work. I'm running version 0.2.0 with the standard Vector skin.

Any ideas?

Thanks.

Kghbln (talkcontribs)
Mitchelln (talkcontribs)

Yes, I have this set and the page title still displays.

Kghbln (talkcontribs)

Just successfully tested this extension on << MW 1.23.3 - PHP 5.4.4 - MySQL 5.5.38 >> with Vector. Just added the magic word and the magic started to happen. Probably where is something in the water with you custom skin? Edit: Ah, you are testing with Vector, too. That's really obnoxious.

Kghbln (talkcontribs)

Well, there is indeed something in the water. When I e.g. switch to another skin the title reappears for all skins, even for Vector which was working ok before. You will have to touch the page to hide the title again which makes this extension basically unusable. Have not tested any cache related implications but this is bad enough.

Mitchelln (talkcontribs)

Thanks for the info. I'll find another way for now.

MrFrelling (talkcontribs)

Was happy to find this extension, but sad to see that it was not functional. As kgh discovered it appears to work at first but not when a page is revisited. When it fails, it appears that the killTitle() method parameter $text contains the page's footer text rather than the content, hence the style override never happens. If the method is triggered, one would expect the associated text to contain the magic word. Somewhere, somehow, page content is being cached, even though I have no caching enabled. The style override still works, so its just a matter of the conditional triggering properly. Tested this with MW 1.23.5, Apache 2.2.15, PHP 5.3.3, and MySQL 5.1.73 on CentOS 6.6. If I have some time, I'll try to dig a bit deeper.

Mitchelln (talkcontribs)

Hi.

I've just tried this again after a git pull and it now works! Somebody has obviously fixed it. Thank you :)

Kghbln (talkcontribs)

Well that's interesting since there were no changes except for code styling in the meantime.

87.249.73.195 (talkcontribs)

Actually, it still doesn't work properly. Weird behaviour in fact as you discovered.

If you edit and save the page, the title does not show, but if you navigate away and then back the title shows again. If you then click Refresh the title disappears again. Navigate away and then back the title shows again.

I have no caching enabled.

I'll go back to using per page CSS to show/hide.

Thanks.

Reply to "Not working with MW 1.23.2?"