Won't it be possible to configure this extension in "LocalSettings.php" after it's invocation rather than doing it in the "AmazonLookup.php" file itself?
Topic on Extension talk:AmazonLookup/Flow
Yes, this would be completely possible.
I have adjusted the instructions to reflect using the 'LocalSettings.php' file for the parameters. Thanks for your question.
That's great. Thank you for doing this. However, I personally would discourage people from adjusting the source files of the extension since these settings will be overwritten upon every update. Also, this is how it is done for all other extensions and provides a clear path for users.
This is my first Mediawiki Extension and the first thing I've written in PHP. I've found the process of sharing the extension to be more of a learning experience than writing the extension or learning PHP. I appreciate the feedback as it helps me to see where improvements can be made. I can appreciate your logic and was having trying finding examples to model the page layout and content around. I will adjust the instructions and remove the code block from AmazonLookup.php on my next update. I hope you find the extension useful and look forward to future feedback.
I believe you are doing a great job already and me or others changing things does not mean that it was not ok what you did before. These are just further improvements. I myself am trying to make an effort to provide a more standard look to pages to make it easier for starters to find their way. However there are still hundreds of pages which could be done better and I am basically mostly working on the new pages added.
The most interesting part for you will probably start as soon as your extension is in the WMF repo. Quite often you get heaps of feedback regarding the programming of the extension itself. There is always a lot to learn. It's great that you a picking up on suggestions.