Topic on Extension talk:BreadCrumbs/Archive 2

fixed by having merged https://gerrit.wikimedia.org/r/#/c/98246/1

see Bug 57757

I have recently installed this extension and I found that it was necessary to make a single character change, to add an ampersand, in order for the preferences to be shown.

I downloaded the "Git master" snapshot on 2013-03-22 and it was necessary to change, in BreadCrumbs.php:

function fnBreadCrumbsAddPreferences( $user, $defaultPreferences ) {

to:

function fnBreadCrumbsAddPreferences( $user, &$defaultPreferences ) {

I don't know enough about the GetPreferences hook to know if the requirement to add the & is a peculiarity of my installation, or the way that things should be. --79.98.163.245 10:55, 25 March 2013 (UTC)

No, that's definitely a bug. I'll be sure it gets fixed in the upcoming, super-charged, latest-and-greatest BreadCrumbs, powered by Javascript. Thanks for the tip!

see my commit https://gerrit.wikimedia.org/r/#/c/98246/1 (pls. merge that)