Jump to content

Topic on Talk:Gerrit/git-review

Qgil-WMF (talkcontribs)

For those (windows users?) having trouble exec'ing git review -R, it works nicely to run the suggested scp command (please note that the shell used by git in windows puts stray characters at the end of lines, so IGNORE "←[K" in the following):

 mylocaldir>git review -R
 Enter passphrase for key '/c/Users/myusername/.ssh/id_rsa':
 Enter passphrase for key '/c/Users/myusername/.ssh/id_rsa':
 remote: Processing changes: refs: 1, done    ←[K
 remote: ERROR: missing Change-Id in commit message footer←[K
 remote: Suggestion for commit message:←[K
 remote:
 remote: Change-Id: I8155f3c92111ae8228e7ac1970225ddef73a88bc←[K
 remote:
 remote: Hint: To automatically insert Change-Id, install the hook:←[K
 remote:   scp -p -P 29418 myusername@gerrit.wikimedia.org:hooks/commit-msg .git/hooks/←[K

In other words, run the suggested "scp" command and your life will be more pleasant/

This post was posted by Qgil-WMF, but signed as Hypergrove.

Waldyrious (talkcontribs)

Gerrit/git-review#Windows suggests to "run scp -v -P 29418 <USERNAME>@gerrit.wikimedia.org:hooks/commit-msg . from within the repo's .git/hooks directory". I believe using the path directly in the command instead of . is clearer, but I also would like to know which of the two other options that differ (-v and -p) should be kept in the instructions on that page. Any insights?

Reply to "importance of scp"