Jump to content

Talk:Reading/Web/QUnit test guidelines

About this board

Start a new topic
You are not logged in. To receive attribution with your name instead of your IP address, you can log in or create an account.

"Always use assert.strictEqual(); never use assert.equal()."

2 comments • 20:40, 26 June 2018 6 years ago
2
Jdlrobson (talkcontribs)

There are some cases where using equals makes more sense - particularly when testing attributes

Consider the following case:

const width = otherParam - anotherParam + 10; strictEquals( $foo.attr('width'), width ) strictEquals( $foo.data('x-y-z-width'), width )

Doing the following seems overkill to me, given data could also be stored as an integer: const width = otherParam - anotherParam + 10; strictEquals( parseInt( $foo.attr('width'), 10 ), width )

Reply 20:09, 26 June 2018 6 years ago
Jdlrobson (talkcontribs)

In Page previews I see a frequent reoccurrence of "Number.parseFloat( thumbnail.el.attr( 'height' ) )," to workaround this.

Reply 20:40, 26 June 2018 6 years ago
Reply to ""Always use assert.strictEqual(); never use assert.equal().""
There are no older topics
Retrieved from "https://www.mediawiki.org/wiki/Talk:Reading/Web/QUnit_test_guidelines"