Talk:Gerrit/Code review/Getting reviews

Looks good!

-) Mahadeva (talk) 19:21, 28 August 2012 (UTC)

Thanks

Thanks to Thehelpfulone, Daniel Kinzler, Jack Phoenix, Roan Kattouw, Jeroen de Dauw, Lydia Pintscher, and others for their feedback on improving this document. Sumana Harihareswara, Engineering Community Manager (talk) 21:45, 29 August 2012 (UTC)

Abandonment

So abandonment doesn't necessarily mean that we've decided not to make the change; it just means that we don't want code review at that time? Leucosticte (talk) 11:59, 19 December 2013 (UTC)

Probably. But if your commit was abandoned by Brion with reason "NOOOOOOOOOOOOOOOOOOOOOOOOO" then maybe the patch is not wanted. ;) --Nemo 12:08, 19 December 2013 (UTC)

1. Introduce yourself well

Looks like it was good to place this as point one, it gets repeated by others as "Phase One: Good or Bad Idea?", of which the commit message is naturally the main tool. --Nemo 22:52, 24 September 2014 (UTC)

explain what votes and by how many reviewers mean what, typically, usually.

for example, i have some experience in stackexchange, and as i know, even having a -1 vote for a post usually means that the post is going to be deleted after some time. but i do not have so much experience in gerrit. for example, if my code has a -2 vote, or one -1 and one +1, i do not understand, what does it mean. --QDinar (talk) 16:34, 10 December 2020 (UTC)

Added some explanation here:

https://www.mediawiki.org/w/index.php?title=Gerrit/Code_review/Getting_reviews&type=revision&diff=4274066&oldid=3884156&diffmode=source cscott (talk) 16:46, 10 December 2020 (UTC)

also, meaning of -1, +1, -2, +2 is here: Gerrit/Tutorial#How_to_comment_on,_review,_and_merge_code_in_Gerrit. (link to it is in this page (article), but i have not read this page fully, before i wrote here in talk...). --QDinar (talk) 17:06, 10 December 2020 (UTC)

more likely several a larger number

"the more likely several a larger number of review iterations will be needed".

Is the grammar correct? It does not make sense to me. 4nn1l2 (talk) 21:45, 19 November 2021 (UTC)

• Fixed, at least as much as I understood the intent. --Clump (talk) 22:01, 19 November 2021 (UTC)

Marking text for translation

Hello, @Shirayuki!

I'm kindly asking you to make the text of this article translatable. I translated it so quickly in Russian that I noticed it's not fully marked for translation. Please take a look. Thank you!

— Pacha Tchernof (talk) 17:29, 14 October 2022 (UTC)

Partially done Shirayuki (talk) 02:26, 15 October 2022 (UTC)