Scrum of scrums/2019-08-07

2019-08-07

Callouts

• Wikidata/WMDE: we would appreciate if there were any updates with regards to fixing issues with the Graphoid, which cause problems on many Wikipedias who use it (https://phabricator.wikimedia.org/T226250), . Some investigation as been done but Yurik doesn't seem to be willing to investigate more or to touch the code. Are there any news about the ownership of Graphoid (WMF team taking over? leaving unmaintained? undeploying?), see https://phabricator.wikimedia.org/T211881.
• Informational information from Parsing:
  • Tim isolated a GC bug in PHP from the SEGV crasher we found running Parsoid/PHP parser tests
    • https://phabricator.wikimedia.org/T228346 is the SEGV phab task and https://bugs.php.net/bug.php?id=78379 is the upstream bug report against PHP
    • Please take a look at https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/527952/4/src/Utils/PHPUtils.php for a workaround in Parsoid in case your codebases might benefit from this.
• Growth: One more threshold update for huwiki: https://phabricator.wikimedia.org/T230031
• Structured Data: As we roll out new features on Commons, we have been seeing a couple of errors that seem to be a product of the MediaInfo extension using underlying Wikibase code in ways different than originally intended. Example: https://phabricator.wikimedia.org/T229280. This is not an emergency or train blocker, but would be good to chat about how we can work together to address issues like this going forward
• Search: need some feedback from Slovak speakers: https://phabricator.wikimedia.org/T223787
• Next week: No train due to Wikimania
• Services: We fixed ORES precache to handle new "stream" param (not "topic"). Should be good to remove your workaround. https://phabricator.wikimedia.org/T228689

Product

Contributors

Editing

• Updates:
  • Preparing for Wikimania
  • Deployed Edit Cards v2
  • Created a Prototype for Toolbar v1 on Mobile
  • Working on Phase 2 of Talk Pages report

Growth

• Updates:
  • Preparing for Task Recommendations work

Readers

iOS native app

• Updates:
  • 6.3.1 released yesterday https://phabricator.wikimedia.org/tag/ios-app-v6.3.1_lobster-on-an-orv/
    • bug fixes
    • talk pages enhancements
  • 6.4 exploratory phase https://phabricator.wikimedia.org/tag/ios-app-v6.4-seamonkey-on-a-hoverboard/
    • iOS13 / iPadOS updates
    • Working on a big release that improves article history https://phabricator.wikimedia.org/tag/ios-app-v6.4-seamonkey-on-a-hoverboard/

Android native app

• Updates:
  • Suggested Edits v2 (editing image captions) released to production!
  • Mobile html integration is almost done. At 70% now.

Readers Web

• Updates:
  • Summary: advanced (mobile) contributions deployed today. \o/
  • Responsive website (MinervaNeue / MobileFrontend / Portals):
    • Advanced mobile contributions:
      • All edits are tagged as "advanced mobile edit" when wgMFAdvancedMobileContributions is true
      • Cleanup AMC feature flagging
      • Contributions page has regressed since changes to RecentChanges adding visual clutter
      • [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage)
      • [AMC] Recent changes design review
      • Notification icon should be visible when the notification drawer is open
      • Decommision MobileWebMainMenuClickTracking
      • Inform AMC users that grouped results are not available on the recent changes page
      • Disable grouped results on RecentChanges page on mobile
      • Notifications should appear in a modal dialog or drawer
      • AMC Outreach - Modal
      • [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists
      • [AMC] Rename setting "Advanced mode" (instead of "Advanced contributions mode")
      • Cleanup Special:RecentChanges filters appearance on Minerva (mobile)
      • Skin should reset SkinOptions on UserLogout action.
      • Extract $skinOptions from SkinMinerva class
      • AMC Navigation - make main menu scrollable
      • Move skin "subtitle" markup that contains redirect and breadcrumbs
      • Main menu should slide over content
      • [SPIKE 8hr] Main Menu should work without javascript
    • Miscellaneous:
      • [Bug] can't re-enter Talk overlay after adding a discussion
      • mobilecite is missing i18n title messages for Special:Specialpages
      • Talk page replies lost when clicking on links
      • [Bug] Visiting a talk section flashes page content
      • ReferencesDrawer should be a Drawer, not extend the Drawer
      • [EPIC] Re-define the contract for displaying drawers and overlays in MobileFrontend
      • Add Redux to MobileFrontend
      • Separate View code from SearchOverlay
      • [Bug] Remove download button from pages that don't exist
      • Make toasts tappable links when redirecting a user away from a page
      • [Bug] Watchlist has skewed thumbnails

Product Infrastructure

• Updates:
  • Profiling Wikifeeds https://phabricator.wikimedia.org/T229287#5394483
  • Created Beta cluster instance with node 10 for migrating Proton https://phabricator.wikimedia.org/T217114
  • Machine Vision Middleware APIs
  • Event Platform Client documentation

Structured Data

• Blocked by:
  • Not a real "block" but it would be good to chat with someone from the Wikidata team about this issue which has appeared occasionally on production since some new structured data features went live on Commons: https://phabricator.wikimedia.org/T229280
• Updates:
  • launch of arbitrary wikibase statements on commons went ok
  • about to commence work on supporting configurable structured data for campaigns

Parsing

• Updates:
  • Parsoid/PHP parser tests ~99% green now
  • Work in progress to enable large scale roundtrip testing on scandium ( https://phabricator.wikimedia.org/T229356 is the tracker task for those interested)
    • Enabling Parsoid/PHP on scandium will also let us run performance tests with production content
  • Tim isolated a GC bug in PHP from the SEGV crasher we found running Parsoid/PHP parser tests
    • https://phabricator.wikimedia.org/T228346 is the SEGV phab task and https://bugs.php.net/bug.php?id=78379 is the upstream bug report against PHP
    • Please take a look at https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/527952/4/src/Utils/PHPUtils.php for a workaround in Parsoid in case your codebases might benefit from this.

UI Standardization

• Updates:
  • Design Style Guide
    • Components: Updated overview with slicing structure for “Components” section
    • Components: Provided WIP patch for “Components” section at https://github.com/wikimedia/WikimediaUI-Style-Guide/pull/22
  • AMC: Improving collapsible HTMLForm styling in preparation of Special:Contributions transformation to OOUI
  • No OOUI release this week due to other priorities above

Technology

Fundraising Tech

• Updates:
  • Ready to deploy EventLogging-based pipeline to get and transform banner and landing page view stats from main cluster to payments cluster DBs (replaces old solution, inexplicably written as a Django app, that parses full web logs reconstructed from Kafkatee): https://phabricator.wikimedia.org/T195594
  • Fixing CentralNotice QUnit tests: https://phabricator.wikimedia.org/T227879
  • Tweaks to India donation form in response to limited initial tests: https://phabricator.wikimedia.org/T228698
  • Deployment and first real-money tests of one-time to recurring donation conversion: https://phabricator.wikimedia.org/T227051, https://phabricator.wikimedia.org/T227048
  • Resuming final piece of work to cut db links between payments-wiki front end and CiviCRM back end
  • Training up fundraising non-tech people to bypass Rube Goldberg machine currently used to import Thank You email content from metawiki: https://phabricator.wikimedia.org/T229965
  • Getting up to speed on progress of core CSP work to make sure CentralNotice banner-preview CSP doesn't break: https://phabricator.wikimedia.org/T229607
  • Working through issues blocking updating fundraising python tools to python3: https://phabricator.wikimedia.org/T213757
  • Improvements to CiviCRM data import and export

Core Platform

• Blocking:
  • MediaWiki installer silently ignores invalid extensions https://phabricator.wikimedia.org/T225512
• Updates:
  • Further rollouts of Kask, paused for performance review
  • Final routes of Parsoid API in PHP
  • API integration testing

Engineering Productivity

Performance

• Blocked by:
  • SRE: DeferredUpdates enqueue-on-failure patch (figure out why it fails wikibase tests); https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/
• Updates:
  • Published the Excellence monthly for June 2019. https://phabricator.wikimedia.org/phame/post/view/163/production_excellence_june_2019/ [wiki][email]
  • AbuseFilter: Continued CR for Daimona's on-going perf work. – https://phabricator.wikimedia.org/T156095
  • Started widespread audit of CSS image-embed performance to improve page load times. – https://phabricator.wikimedia.org/T121730

Quality and Test Engineering

• Updates:
  • MediaWiki installer silently ignores invalid extensions https://phabricator.wikimedia.org/T225512

Release Engineering

• Blocked by:
  • Core Platform Team:
    • MediaWiki installer silently ignores invalid extensions https://phabricator.wikimedia.org/T225512
• Updates:
  • Train Health
    • Last week: 1.34.0-wmf.16 - https://phabricator.wikimedia.org/T220741 – Fully deployed
    • This week: 1.34.0-wmf.17 - https://phabricator.wikimedia.org/T220742 – No known blockers yet
    • Next week: No train this week due to Wikimania
  • Code Health
  • Log Health

Scoring Platform

• Blocked by:
  • Growth https://phabricator.wikimedia.org/T230031
• Updates:
  • ORES deployment (probably Tuesday, Aug 6th): https://phabricator.wikimedia.org/T229848
    • Improvements to huwiki editquality models
    • Improvements to enwiki article quality model
    • Improvements to wikidata item quality model
    • Fixed ORES precache to handle new "stream" param (not "topic")
  • Completed https://www.mediawiki.org/wiki/JADE/Use_cases
  • Designed a "catch-all" endpoint for Jade. See https://phabricator.wikimedia.org/T229362 Is this a good idea?

Search Platform

• Blocked by: need some feedback from Slovak speakers: https://phabricator.wikimedia.org/T223787
• Updates:
  • Improved documentation on search boolean operators: https://phabricator.wikimedia.org/T228925
    • Docs here: https://www.mediawiki.org/wiki/Help:CirrusSearch/Logical_operators
  • Set up load balancing for cloudelastic: https://phabricator.wikimedia.org/T224324
  • Set up “did you mean” satisfaction metrics dashboard: https://phabricator.wikimedia.org/T229268
  • Fixed some missing updates after WDQS reload and underlying cause: https://phabricator.wikimedia.org/T228640
  • Waiting for feedback on Slovak stemmer: https://phabricator.wikimedia.org/T223787
  • Working on creating RDF export for SDC/MediaInfo: https://phabricator.wikimedia.org/T221917
  • Working on getting glent suggestions into Elastic indexes: https://phabricator.wikimedia.org/T227364
  • Working on CirrusSearch configuration for cloudelastic: https://phabricator.wikimedia.org/T220625
  • Working on WDQS Updater performance improvements: https://phabricator.wikimedia.org/T212826

Security

• Updates:
  • Team members out / at conferences, intermittent progress will be made on existing tickets over the next 1-2 weeks.

Site Reliability Engineering

• Blocking:
  • WMDE/Wikidata would appreciate some review on https://gerrit.wikimedia.org/r/c/operations/puppet/+/526627
  • SRE: DeferredUpdates enqueue-on-failure patch (figure out why it fails wikibase tests); https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/
• Updates:
  • SRE is migrating all cron/maintenance jobs to PHP7, tracking task: https://phabricator.wikimedia.org/T195392

TechCom

• Updates:
  • Last Calls being review in today's TechCom meeting:
    • Proper command-line runner for MediaWiki maintenance tasks https://phabricator.wikimedia.org/T99268
    • Heredoc arguments for templates (aka "hygienic" or "long" arguments) https://phabricator.wikimedia.org/T114432
    • Abstract schemas and schema changes https://phabricator.wikimedia.org/T191231

Wikimedia DE

Wikidata

• Blocked by:
  • Site Reliability Engineering: WMDE/Wikidata would appreciate some review on https://gerrit.wikimedia.org/r/c/operations/puppet/+/526627