Jump to content

Extension talk:CleanChanges

Add topic
From mediawiki.org
Latest comment: 7 years ago by Nikerabbit in topic Mod to match language tag in middle of page name?

I has no installation instructions :S 213.22.31.12 08:23, 22 October 2008 (UTC)Reply

Comparison?

[edit]

It's hard to understand how it differs in appearance from the vanilla recent changes view without two comparable screenshots. Can someone produce those, preferably of the same dataset (i.e. enable and disable the extension)? Ijon (talk) 02:15, 17 September 2013 (UTC)Reply

Hi. Sure, I'll do that (though there is a bug which may confuse the comparison a bit). I assume that for "vanilla recent changes" you mean core's m:Help:Enhanced recent changes? Otherwise the comparison makes little sense. --Nemo 05:39, 17 September 2013 (UTC)Reply
Yes, that's right, thanks! Ijon (talk) 03:42, 18 September 2013 (UTC)Reply

Broken on 1.24?

[edit]

Is this extension broken on version 1.24? I just upgraded my wiki and there was a blank page on the recent changes, and it started to work after I disabled the extension.

Did you install the matching version from MLEB? --Nemo 06:01, 23 January 2015 (UTC)Reply
After installing Extension:Translate CleanChanges is broken: Detected bug in an extension! Hook CCFilters::user has invalid call signature; Parameter 1 to CCFilters::user() expected to be a reference, value given. Problem caused by TranslateRcFilter::translationFilter --C0nnex 12:29, 04 October 2015 (UTC)Reply

Mod to match language tag in middle of page name?

[edit]

I was looking into using this extension for filtering based on language, however, with the wiki page structure I want to create, it'd be a lot more convenient to have the language code in the middle of the page name. At a glance, it looked like changing Filters.php (line 81) as follows might be a simple way to do that.

$conds[] = 'rc_title ' . $dbr->buildLike( $dbr->anyString(), $trailer );

Change to

$conds[] = 'rc_title ' . $dbr->buildLike( $dbr->anyString(), $trailer, $dbr->anyString() );

However, I don't understand the code of the extension well enough. Does anyone know enough to say if this modification to the extension would or wouldn't work? Thanks, --Flyingferret83 (talk) 02:55, 2 November 2015 (UTC)Reply

It is certainly possible to do so, but I don't see any reason to do it. The language code is always at the end in any system using Translate, in the MediaWiki namespace and so on. --Nikerabbit (talk) 06:53, 24 August 2017 (UTC)Reply

Logs full of error

[edit]

Because of an PHP strict standards error, logs became full...

[Sun Oct 02 14:00:53.788937 2016] [:error] [pid 23686] [client xxx.xxx.xxx.88:20726] FastCGI: server "/var/www/xxx/xxx/xxx/cgi-bin/php5-fcgi-37.xxx.xxx.xxx-443-wiki.debian-fr.xyz" stderr: PHP message: PHP Strict Standards: Declaration of NCL::recentChangesLine() should be compatible with EnhancedChangesList::recentChangesLine(&$rc, $watched = false, $linenumber = NULL) in /var/www/xxx/xxx/xxx/web/extensions/CleanChanges/CleanChanges_body.php on line 6

I have to deactive the extension.

I changed line 92 in "CleanChanges_body.php" from
public function recentChangesLine( &$baseRC, $watched = false ) {
to
public function recentChangesLine( &$baseRC, $watched = false, $linenumber = null ) {
and this solved the problem.
Just noting that this has been fixed a long time ago now. --Nikerabbit (talk) 06:52, 24 August 2017 (UTC)Reply