Extension:MobileFrontend/Deployments/2013-12-05
Appearance
Dependencies
[edit]- Dependency: I786b63ab57518fc6af7761501259ed66592f70e3
- Dependency: I708006fd6733cac89128bc76a1cd34c0d091c371
- Dependency: Ieecf289ec5fb7307369ba8b3f1ebbe682b900383
- Dependency: Ief6b5f53096dd5eeb43a72a7bb182a2c04ec97ca
Stories
[edit]- Story 1401: Language Selector Overlay UI Redesign
- Rename Special:History to Special:MobileHistory
- Story 1408: Resolve Edit Tutorial A/B Test
Bugs
[edit]commit 3d509562b855f597decd1719dc242fd2f0092caa Author: kaldari <rkaldari@wikimedia.org> Date: Tue Dec 3 18:11:10 2013 -0800 Don't create empty user descriptions for User Profile If the initial description and new description are both empty, just switch the User Profile back to view mode instead of trying to save the user description page with no content. Bug: 57931 Change-Id: I54f51476833d400db3a4276f8db35870f18a898e
commit 0544160a64f1d7dd662f6e1b76514243ffa31a2a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Dec 5 14:47:41 2013 +0100 Moved information on how to run Selenium tests to a separate README file The goal is to make it easy for people to start contributing to Selenium tests. While working on resolving a couple of bugs (see below) we are updating existing documentation and adding README files to tests/browser folders of all repositories that contain Selenium tests. Some people will land there and never notice the main README file. Bug: 57841 Bug: 56089 Change-Id: I814f7167ef5aafca62fc92d11ad27956cc3a4d89
commit 0544160a64f1d7dd662f6e1b76514243ffa31a2a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Dec 5 14:47:41 2013 +0100 Moved information on how to run Selenium tests to a separate README file The goal is to make it easy for people to start contributing to Selenium tests. While working on resolving a couple of bugs (see below) we are updating existing documentation and adding README files to tests/browser folders of all repositories that contain Selenium tests. Some people will land there and never notice the main README file. Bug: 57841 Bug: 56089 Change-Id: I814f7167ef5aafca62fc92d11ad27956cc3a4d89
commit 46064865056cbde34b33707bd0fceed22f81d617 Author: awjrichards <arichards@wikimedia.org> Date: Wed Dec 4 16:19:26 2013 -0700 Ensure title arg isn't set twice when creating 'mobile view' link This was happening previously - but only in cases where the wgMobileUrlTemplate variable was NOT set (e.g., not on Wikimedia wikis). Now it happens all the time. Bug: 56837 Change-Id: Ibdbbf461f95d48f9c522f08027ced510a05f0bff
commit e51dd87229b0fbff461b9fd979ee4daed2fb6c0f Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Nov 28 02:02:08 2013 +0400 Introduce new mobileview parameter, onlyrequestedsections Allows to reduce response size for new app versions being developed. I know it's ugly as hell, but only this way b/c can be preserved. Bug: 57440 Change-Id: Ie0d93918ab0fff49a2b6f0afd72e390e90d6dd10
commit 925dc197cba42e2ffcfe2d9fc8a84e60d7533c5c Author: mayankmadan <maddiemadan@gmail.com> Date: Tue Dec 3 14:58:25 2013 +0530 Adding a readme file in /tests/browser Bug: 56089 Change-Id: I27829c5b6eb663ac97c01c5b235209d413dcc45e
commit db757131b6180ec00d4f8b90aeba86d3324e16d4 Author: mayankmadan <maddiemadan@gmail.com> Date: Wed Nov 27 00:20:00 2013 +0530 QA: prefer double-quoted strings in Ruby code Bug: 57597 Change-Id: I53986162e8e0dfce5f1671a5fc63f923822f61d8
commit 8dd45b94aae88058ecbe6ec3ebbdff8581c1404b Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 20 16:57:08 2013 -0800 Add all logic for edit profile pages in JavaScript You need JavaScript to open the editor interface so let's just use JavaScript to do the edit itself. Bug: 57120 Change-Id: I267ff48b506f89719757e7fd20b72b1e36e69b3e
commit b73a7ae792b4b002b68ad81522f9ebd7497ee8bb Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 26 16:50:45 2013 -0800 Don't show the existing page in list of results of nearby pages Also stop unnecessarily pushing Bug: 57444 Change-Id: Ib97bd1680f570262e78ba37c29f0c3726fddda04 (cherry picked from commit 8816557a3f5a518adcf1d72dcee5ac91b63b2438)
commit 5d76687a067ace255c98919a580954da2acbcf86 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Nov 22 23:46:29 2013 +0400 Always remove headings if requested Bug: 57402 Change-Id: I7fd8785610061885fd4ca1e468b87a6084ff6952
commit 9ac8eb8ee8dd63fb7f3d02977991769e630bfbc1 Author: tholam <t.lam@lamsinfosystem.com> Date: Tue Nov 26 16:13:42 2013 -0600 Add refresh functionality on fancycaptcha for mobile Created a new module for use in mobilefrontend extension Bug: 51482 Change-Id: I5d76a7c64ba3f67b938446c8a8361114a709eabe Dependency: Ieecf289ec5fb7307369ba8b3f1ebbe682b900383
commit f855673ca6c5eeeb8c5d74521110ab31d9dc898f Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 14:45:05 2013 -0800 Style errors on profile better Do what Special:MobileDiff does and 404 on no argument Style like Special:Nearby for errors Tweak language Bug: 57087 Change-Id: Icfcf2c9ac4d58fc8bacbe4617b024a255a5469b4
commit 9d8dbf9801a124bc66e51d522bc03949c05d0eac Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 11:34:32 2013 -0800 Make last modified bar green until page is >= 24 hours Bug: 56862 Change-Id: I1b30bf583b5f6b18030ceff11e47ed53ed46f83f
commit 32b2538ee3e9d273bf76ebde66fcb822810cc1df Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 12:25:56 2013 -0800 Fix media viewer for images with unicode characters Also address FIXMEs related to History.js which we no longer use. Bug: 57089 Change-Id: I8c8beb79b57d2a14b59fbc695df3262eee53ed59
commit dc9ed37697753eb34d4806e5a35aaca270cbc43a Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:29:36 2013 -0800 Don't ask about abandoning edit if no changes present Update micro.autosize in the process. Bug: 57377 Change-Id: I4e1f3fb0dee6e1e39306d8114e9e0d72af667b36
commit 4f177d1349ff2f4082a125c240db9462054feeec Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:06:42 2013 -0800 Fix markup in PhotoUploadProgress.html Make it similar to what OverlayNew.html uses. Bug: 57434 Change-Id: If57618b016c2896e351c3484fb7e06529b75e750
commit 48a1f09c37b00e06c2726817e1e1192ba608930c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 12:37:16 2013 -0800 Don't set defaults using $.ajaxSetup() Bug: 57556 Change-Id: Iadb4ee2b336e07ae2dfec7f09798ba210f409f6b
commit 2e0cef6f44fcbc4e87f852cc6104258df0c5dcc7 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 22 15:39:04 2013 -0800 Desktop: Add Vector specific Special:Nearby tweaks It seems in Vector in Firefox since our reset is not applied the lists can be badly styled with bullet points and with a margin (our reset is not applied) I'd rather not tarnish our own less file so adding a minor less file to combat this. Bug: 57446 Change-Id: I15ed91662140ff131931f8ef40b1336bea2c83e8 (cherry picked from commit f0332c70fa73b69416e06fe7a64467979a979e7e)
commit 4bdfd75d91701feed9341f541ee76f19d21d4793 Author: kaldari <kaldari@gmail.com> Date: Mon Nov 25 07:26:59 2013 -0800 Adding default styling for tables Also removing some redundant styling for infoboxes and consolidating the two table.infobox styles. Bug: 49959 Change-Id: Ib3376651b8bbca3fb5b5ff8e3020efc435be0408
commit 74e2e1bed4d7a735c3311278e07fde7cfb255dcb Author: kaldari <kaldari@gmail.com> Date: Sat Nov 23 02:31:33 2013 -0800 Some fixes to the new overlay 1. Making continue and save buttons line up with the rest of the header by giving them a -1px bottom-margin. 2. Making continue button flip in RTL languages (Bug: 57404) 3. Fixing background position of .overlay .license so that the graphic isn't clipped at the bottom. (18px - 16px is 2px, not 4px). Change-Id: I97027b065e80b6057f4a0a879e2a6481c916ad84
commit 194a04bbe153c132cc04025aeedf3602f074ba09 Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 21 11:44:10 2013 -0800 Hack around Wikibase extension bug Workaround to avoid language button incorrectly showing up on mobile Bug: 57094 Change-Id: I63da6e52e028f968cc8a3c92aee2484ef7c17a13
commit 271737ca6f5981a46aaf698bbf93e6f91780a616 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 15:30:44 2013 -0800 Stop SHOUTING in special page headers Switch to lowercase minor tweaks to h2s to reflect change Bug: 57208 Change-Id: I33f9f5f1abfc366b53b130d92aad289ab5942fb4
commit 266c8805e8bd4b062d1ca7b61e3c7b3f23bc2142 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 15:13:20 2013 -0800 Use prefixed title in Special:History banner Bug: 57119 Change-Id: Ibad184ac3d7fb62f605b773e0f7dbba3c5a81d28
Qa
[edit]- QA: prefer double-quoted strings in Ruby code
Hygiene
[edit]- Hygiene: Basic mobileview test
- Hygiene: Remove title exists check on Special:History
- Hygiene: Uncomment and fix upload progress event test for Api
- Hygiene: Fix references
- Hygiene: Remove console.log statement
- Hygiene: Remove unused code
- Hygiene: Add make phplint to Makefile and pre commit hook
- Hygiene: Cleanup diff css
I18n
[edit]Localisation updates from https://translatewiki.net.
commitcommit 46c2e8b850c9d8412f52253ba61a0c4e8e7d7434 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 5 21:17:49 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I5efe0d8aabfdd6ebeb9962284e04571c4af7ebe4
Localisation updates from https://translatewiki.net.
commit 1fdcd07c64fac45b5c79503bf2b3b44e07cc54fe Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 4 20:24:43 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: Icff23028318e4c15b85e0d0cd0df8104c5de13e1
Localisation updates from https://translatewiki.net.
commit 1d76eb78dce74f3624cbff5be30e62c50f191f6b Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 3 20:49:38 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I611014a27a2e742bd89abdf87658ce10bcf0f402
i18n: Add missing explicit GENDER parameter
commit 84e89991dbbaf4e16964c6d333d7143facebc548 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Mon Dec 2 19:21:15 2013 +0100 i18n: Add missing explicit GENDER parameter Spotted by Mormegil at https://translatewiki.net/wiki/Thread:Support/ About_MediaWiki:Mobile-frontend-profile-last-thanked/cs Change-Id: I6f1c8c36f9b39c7bf2b7bc6318c829d72d716284
Localisation updates from https://translatewiki.net.
commit 54447f92d2af234ea8e2d3d26f5e72f66ef50835 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 2 20:39:20 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I0fa574b38fd9ebed35dd83b30c6fb948c130651c
Localisation updates from https://translatewiki.net.
commit ffaf6ddd0e173b3f8cc8ee0529384efc397c7902 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 1 19:56:12 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I07adee5c12dd51522d65b4e6aaea6d1ce588c109
Localisation updates from https://translatewiki.net.
commit b986831c51a643b12e0aaa53d89e15eabbc32765 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Nov 30 19:54:14 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I2132f7f9a7421adf9b22b4e916aa4cff1ab82d70
Localisation updates from https://translatewiki.net.
commit 87ffae3a4f5d89c3e4633a8005e8dee3b145c446 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Nov 29 19:30:15 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I8c324e7ab8660523e38cb153d66d8da1a7dd4fa2
Localisation updates from https://translatewiki.net.
commit e5006c322606c01d6947a3124562e2e97774a33c Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Nov 27 19:27:13 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I8f2bcb49db9c908776a074c89c1ab41954a0df63
i18n: Revert watchlist damage caused by two word tab name
commit ce678492068c2a0a0252e22633f704718f797638 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 10:31:55 2013 -0800 i18n: Revert watchlist damage caused by two word tab name In I80895b461ee272f1a6ff54199752553426eae956 the watchlist 'Articles' tab was switched to 'Content pages'. Having two words in a tab causes serious layout problems on mobile. These tabs should only contain one word. Update qqq codes to make this clearer. Unfortunately I can't think of a better word than article right now so I've reverted to that pending further thought Change-Id: I5c886450641ac86e71d26e0c7ec9caceebb2a7d3
Localisation updates from https://translatewiki.net.
commit 711164c26d3b0846ada112b9f0526fadc0991b05 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Nov 26 20:23:17 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: Id535fcf2559b411762ec26536876d226fb5daefd
Localisation updates from https://translatewiki.net.
commit 8f980c9230e70487cc6cbce3d0d4320a9492533f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Nov 25 21:16:36 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I1fc2f48c1fe07858d4d96f6a823cdcfe4e3ec212
Localisation updates from https://translatewiki.net.
commit dfb0c2c4a318e523eb185ca213e966fca9fc13d0 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Nov 24 20:35:05 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I15934bc17473eefedb78d9ad4fa77798a5d60468
Localisation updates from https://translatewiki.net.
commit 87d6a71817cc1644e0e4c605a3ad51a593d792cc Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Nov 23 10:47:58 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I999ddd40cf893e0450dd7e6d179b558eb2a09fe8
Regressions
[edit]- Talk:Beta_Features/Nearby_Pages#Button_regressions
Other
[edit]commit 8d800df770d5aaa1bc5dbcb2204fc1d42da9ae67 Author: kaldari <kaldari@gmail.com> Date: Wed Dec 4 20:25:43 2013 -0800 More robust permission checking for User Profile The previous permission checking on the client-side didn't work for fish-bowl wikis or blocked editors, and on the server side it didn't work in certain rare situations (like the UserProfileIntro being protected). We now make sure the user can actually edit the page in both cases. Also, since we're generating the UserDescriptionPage's title earlier now, change getWikiPageText() to take advantage of that. Change-Id: I2d59153ac41e30239641380c213c7d85db852d29
commit 80ab0a3905ff27de1f6390e9df324c23aef668b1 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Dec 4 17:54:22 2013 -0800 Update styling in user profiles As per Kaity's request. Change-Id: Ie233ec7e9741656caac7cbfcc0c7f248703ff5f9
commit 1abc863993f82f840f05917667bf0db50239b485 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Dec 2 20:41:23 2013 +0400 Avoid HTTP redirects in links Every unneeded request worsens user experience Change-Id: I0cf52dc79a93f23b2730df02ee8a2320d2782a78
commit 2a33a180871d519597c2ec19b0250cddad720cb9 Author: Derk-Jan Hartman <hartman.wiki@gmail.com> Date: Thu Nov 28 15:16:00 2013 +0100 Add margins when floating thumbnails in mobile view Improves readability by introducing spacing between thumbnails and adjacent text. Change-Id: I8b6aca3521c5f57327c16751798dafb0cc49eb7c
commit bd1e7d4ea1bcc16f53b1ea63f0635f6af954e252 Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 19 15:44:10 2013 -0800 Remove infobox experiment from MobileFrontend Change-Id: Iad24ce41b5820e3bbdbedb3e9bbaaeb01bc3db75
commit 56019074e7825e1f226e118744f9e59e673e1d59 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 14:45:43 2013 -0800 Conditionally hack mw.Api Follow up to I4c92422428de60d2e11ba891fe44dbf43ad99c43 Since some of our code runs on desktop let's play it safe! Change-Id: Ib67349c9ae7aa2a6720df9a92d2e1fc40a5462a8
commit 68cadc1834861428fee24d7219611a89b69edc27 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 10:55:52 2013 -0800 Hack: Add hack so modules that use mw.Api can work on mobile in limited form To give an example: https://gerrit.wikimedia.org/r/#/c/97852/ adds captcha refresh functionality to mobile. It expects mw.Api but uses it in the same way as the api we provide. Change-Id: I4c92422428de60d2e11ba891fe44dbf43ad99c43
commit 7e6837341d533a3003cda65fe85b7ef01f66ed60 Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 26 16:44:42 2013 -0800 Limit pagelist overlay styles to search in stable Now we have the new search overlay there is no reason for these styles in beta - in fact they break nearby pages overlay Change-Id: Iaaaad434a0d23e9faf356e811d97534a87fe400c
commit 4d996372e5df04416629a08ff3d25602fbbd51f2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 11:25:53 2013 -0800 Stop flash of last modified bar * Move last modified code to top of page * Fire header-loaded event after the last modified bar has been rendered (will not effect cached pages) Change-Id: Ia24c6ff4efc4c5286f69c5e1acc86e16ac9cf73c
commit 038dec5130bfbcd124b634710c290e7df6443c6c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:15:06 2013 -0800 Only display right button list when needed in OverlayNew This fixes overlay header in new notifications overlay on which there is a large gap in the corner of the overlay (right corner on LTR mode) Change-Id: I3fa8f9a37d291159c58d238364f10c6438f03561
commit b43d847209a2148fa382406594be0c0c2dec3f0c Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 14 15:12:38 2013 -0800 Redirect action=history links to mobile view Change-Id: Icf162d34b1b3c566d46a9e98b0e3c736623e28c0
commit 59b0325e64e58f054b0a5f20e2f18ec29425aca9 Author: cmcmahon <cmcmahon@wikimedia.org> Date: Tue Nov 26 09:57:00 2013 -0700 password for Selenium_newuser is the same as for Selenium_user Change-Id: I4dac86d2216eb3b95955bbdde15bed155d2f473d
commit e012f5fb51914c6ebf34d16f78270b26124748b7 Author: cmcmahon <cmcmahon@wikimedia.org> Date: Tue Nov 26 08:47:40 2013 -0700 update locator for tutorial overlay Change-Id: Iadeee27d43db6e296144151531c6c9f72bf81f19
commit f61bf26c717bf2bb4e6b4d8647917ed6c4befaf4 Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 21 13:25:44 2013 -0800 Beta Feature: Switch from + to * in regex In Commons for example geo coordinates render in the forn 37.9782663;-119.1324739 with no space between the semicolon and - sign Change-Id: Ic1610d0fc1a98d749927306eded8589144556745
commit 160013d74367a4f7c3407986493008f437b64211 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Nov 23 03:10:10 2013 +0400 Fix fatal PHP Fatal error: Call to a member function getLocalUrl() on a non-object in /usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php on line 94 Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232
commit 6d58d0d4ce2550423c2f885dcc3fe1c5e7ae134b Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 20 10:34:46 2013 -0800 Cleanup this page has issues initialisation Limit to main namespace - user pages and user talk pages for example should never have issues! Change-Id: I95375a8347e07ef5de2c0efe3fe1ebf3f13ddcd7
commit c8d446be9164cf0c2fb88df717abdff709ce225a Author: Marius Hoch <hoo@online.de> Date: Thu Nov 14 00:26:53 2013 +0100 Make collapsible sections accessible to screen reader users I've addedd the relevant aria attributes so that screen reader users can know about the collapsible sections. Change-Id: Ie176f7fda685c320e7bc2fc740be59194adba945
Raw git log
[edit]commit 46c2e8b850c9d8412f52253ba61a0c4e8e7d7434 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 5 21:17:49 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I5efe0d8aabfdd6ebeb9962284e04571c4af7ebe4 commit 5e3774adea632ccb0e837aff89310d5d0216b9fb Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 20 17:07:11 2013 -0800 VE editing on tablets in alpha Requires this patch, Visualeditor and Parsoid installed, and the following changes to be merged: Dependency: I786b63ab57518fc6af7761501259ed66592f70e3 Dependency: I708006fd6733cac89128bc76a1cd34c0d091c371 Change-Id: I09037c1ef289f8e871bc99372f2e2e810a250af4 commit 3d509562b855f597decd1719dc242fd2f0092caa Author: kaldari <rkaldari@wikimedia.org> Date: Tue Dec 3 18:11:10 2013 -0800 Don't create empty user descriptions for User Profile If the initial description and new description are both empty, just switch the User Profile back to view mode instead of trying to save the user description page with no content. Bug: 57931 Change-Id: I54f51476833d400db3a4276f8db35870f18a898e commit 8d800df770d5aaa1bc5dbcb2204fc1d42da9ae67 Author: kaldari <kaldari@gmail.com> Date: Wed Dec 4 20:25:43 2013 -0800 More robust permission checking for User Profile The previous permission checking on the client-side didn't work for fish-bowl wikis or blocked editors, and on the server side it didn't work in certain rare situations (like the UserProfileIntro being protected). We now make sure the user can actually edit the page in both cases. Also, since we're generating the UserDescriptionPage's title earlier now, change getWikiPageText() to take advantage of that. Change-Id: I2d59153ac41e30239641380c213c7d85db852d29 commit 0544160a64f1d7dd662f6e1b76514243ffa31a2a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Dec 5 14:47:41 2013 +0100 Moved information on how to run Selenium tests to a separate README file The goal is to make it easy for people to start contributing to Selenium tests. While working on resolving a couple of bugs (see below) we are updating existing documentation and adding README files to tests/browser folders of all repositories that contain Selenium tests. Some people will land there and never notice the main README file. Bug: 57841 Bug: 56089 Change-Id: I814f7167ef5aafca62fc92d11ad27956cc3a4d89 commit 7ba9ec356390809955ffd9e5f668454c8718982b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Dec 2 15:50:39 2013 -0800 Story 1401: Language Selector Overlay UI Redesign Also make some overlay styles more uniform, fix a -1px margin hack so that the border of the last element in an overlay list (.page-list) doesn't disappear. Change-Id: Ib700b810c1d1e10fdac1ae43f25c8e043227e02c commit 80ab0a3905ff27de1f6390e9df324c23aef668b1 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Dec 4 17:54:22 2013 -0800 Update styling in user profiles As per Kaity's request. Change-Id: Ie233ec7e9741656caac7cbfcc0c7f248703ff5f9 commit 46064865056cbde34b33707bd0fceed22f81d617 Author: awjrichards <arichards@wikimedia.org> Date: Wed Dec 4 16:19:26 2013 -0700 Ensure title arg isn't set twice when creating 'mobile view' link This was happening previously - but only in cases where the wgMobileUrlTemplate variable was NOT set (e.g., not on Wikimedia wikis). Now it happens all the time. Bug: 56837 Change-Id: Ibdbbf461f95d48f9c522f08027ced510a05f0bff commit 1fdcd07c64fac45b5c79503bf2b3b44e07cc54fe Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 4 20:24:43 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: Icff23028318e4c15b85e0d0cd0df8104c5de13e1 commit e51dd87229b0fbff461b9fd979ee4daed2fb6c0f Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Nov 28 02:02:08 2013 +0400 Introduce new mobileview parameter, onlyrequestedsections Allows to reduce response size for new app versions being developed. I know it's ugly as hell, but only this way b/c can be preserved. Bug: 57440 Change-Id: Ie0d93918ab0fff49a2b6f0afd72e390e90d6dd10 commit 925dc197cba42e2ffcfe2d9fc8a84e60d7533c5c Author: mayankmadan <maddiemadan@gmail.com> Date: Tue Dec 3 14:58:25 2013 +0530 Adding a readme file in /tests/browser Bug: 56089 Change-Id: I27829c5b6eb663ac97c01c5b235209d413dcc45e commit 1d76eb78dce74f3624cbff5be30e62c50f191f6b Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 3 20:49:38 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I611014a27a2e742bd89abdf87658ce10bcf0f402 commit 8c4471d18bb21b0b55bc8bee05c7d6a9a74bb1b4 Author: Kunal Mehta <legoktm@gmail.com> Date: Thu Nov 21 23:55:29 2013 -0800 Rename Special:History to Special:MobileHistory Allows core to use Special:History (see I612df6e33c74527c9a3a0af5a6c66cd977dc7344) Also adds the missing alias. Change-Id: I11b6eb72793d2d885e0ce8f70bf780386b30daed commit db757131b6180ec00d4f8b90aeba86d3324e16d4 Author: mayankmadan <maddiemadan@gmail.com> Date: Wed Nov 27 00:20:00 2013 +0530 QA: prefer double-quoted strings in Ruby code Bug: 57597 Change-Id: I53986162e8e0dfce5f1671a5fc63f923822f61d8 commit 84e89991dbbaf4e16964c6d333d7143facebc548 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Mon Dec 2 19:21:15 2013 +0100 i18n: Add missing explicit GENDER parameter Spotted by Mormegil at https://translatewiki.net/wiki/Thread:Support/ About_MediaWiki:Mobile-frontend-profile-last-thanked/cs Change-Id: I6f1c8c36f9b39c7bf2b7bc6318c829d72d716284 commit 54447f92d2af234ea8e2d3d26f5e72f66ef50835 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 2 20:39:20 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I0fa574b38fd9ebed35dd83b30c6fb948c130651c commit 1abc863993f82f840f05917667bf0db50239b485 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Dec 2 20:41:23 2013 +0400 Avoid HTTP redirects in links Every unneeded request worsens user experience Change-Id: I0cf52dc79a93f23b2730df02ee8a2320d2782a78 commit ffaf6ddd0e173b3f8cc8ee0529384efc397c7902 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 1 19:56:12 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I07adee5c12dd51522d65b4e6aaea6d1ce588c109 commit b986831c51a643b12e0aaa53d89e15eabbc32765 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Nov 30 19:54:14 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I2132f7f9a7421adf9b22b4e916aa4cff1ab82d70 commit 87ffae3a4f5d89c3e4633a8005e8dee3b145c446 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Nov 29 19:30:15 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I8c324e7ab8660523e38cb153d66d8da1a7dd4fa2 commit 2a33a180871d519597c2ec19b0250cddad720cb9 Author: Derk-Jan Hartman <hartman.wiki@gmail.com> Date: Thu Nov 28 15:16:00 2013 +0100 Add margins when floating thumbnails in mobile view Improves readability by introducing spacing between thumbnails and adjacent text. Change-Id: I8b6aca3521c5f57327c16751798dafb0cc49eb7c commit bd1e7d4ea1bcc16f53b1ea63f0635f6af954e252 Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 19 15:44:10 2013 -0800 Remove infobox experiment from MobileFrontend Change-Id: Iad24ce41b5820e3bbdbedb3e9bbaaeb01bc3db75 commit 56019074e7825e1f226e118744f9e59e673e1d59 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 14:45:43 2013 -0800 Conditionally hack mw.Api Follow up to I4c92422428de60d2e11ba891fe44dbf43ad99c43 Since some of our code runs on desktop let's play it safe! Change-Id: Ib67349c9ae7aa2a6720df9a92d2e1fc40a5462a8 commit 8dd45b94aae88058ecbe6ec3ebbdff8581c1404b Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 20 16:57:08 2013 -0800 Add all logic for edit profile pages in JavaScript You need JavaScript to open the editor interface so let's just use JavaScript to do the edit itself. Bug: 57120 Change-Id: I267ff48b506f89719757e7fd20b72b1e36e69b3e commit e5006c322606c01d6947a3124562e2e97774a33c Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Nov 27 19:27:13 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I8f2bcb49db9c908776a074c89c1ab41954a0df63 commit 68cadc1834861428fee24d7219611a89b69edc27 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 10:55:52 2013 -0800 Hack: Add hack so modules that use mw.Api can work on mobile in limited form To give an example: https://gerrit.wikimedia.org/r/#/c/97852/ adds captcha refresh functionality to mobile. It expects mw.Api but uses it in the same way as the api we provide. Change-Id: I4c92422428de60d2e11ba891fe44dbf43ad99c43 commit b73a7ae792b4b002b68ad81522f9ebd7497ee8bb Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 26 16:50:45 2013 -0800 Don't show the existing page in list of results of nearby pages Also stop unnecessarily pushing Bug: 57444 Change-Id: Ib97bd1680f570262e78ba37c29f0c3726fddda04 (cherry picked from commit 8816557a3f5a518adcf1d72dcee5ac91b63b2438) commit ce678492068c2a0a0252e22633f704718f797638 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 27 10:31:55 2013 -0800 i18n: Revert watchlist damage caused by two word tab name In I80895b461ee272f1a6ff54199752553426eae956 the watchlist 'Articles' tab was switched to 'Content pages'. Having two words in a tab causes serious layout problems on mobile. These tabs should only contain one word. Update qqq codes to make this clearer. Unfortunately I can't think of a better word than article right now so I've reverted to that pending further thought Change-Id: I5c886450641ac86e71d26e0c7ec9caceebb2a7d3 commit 5d76687a067ace255c98919a580954da2acbcf86 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Nov 22 23:46:29 2013 +0400 Always remove headings if requested Bug: 57402 Change-Id: I7fd8785610061885fd4ca1e468b87a6084ff6952 commit 9ac8eb8ee8dd63fb7f3d02977991769e630bfbc1 Author: tholam <t.lam@lamsinfosystem.com> Date: Tue Nov 26 16:13:42 2013 -0600 Add refresh functionality on fancycaptcha for mobile Created a new module for use in mobilefrontend extension Bug: 51482 Change-Id: I5d76a7c64ba3f67b938446c8a8361114a709eabe Dependency: Ieecf289ec5fb7307369ba8b3f1ebbe682b900383 commit 73c6c47a898947ed1b5e6a24397ac47c171b9ba2 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 17:17:22 2013 -0800 Story 1408: Resolve Edit Tutorial A/B Test Change-Id: I13f55548df57d2524afec9b899617ce216ea4ee6 commit 7e6837341d533a3003cda65fe85b7ef01f66ed60 Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 26 16:44:42 2013 -0800 Limit pagelist overlay styles to search in stable Now we have the new search overlay there is no reason for these styles in beta - in fact they break nearby pages overlay Change-Id: Iaaaad434a0d23e9faf356e811d97534a87fe400c commit 59300e49ece20c56044d69b9c3af7307a9cbf07d Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Nov 27 00:02:49 2013 +0400 Hygiene: Basic mobileview test Change-Id: I841c284d83ca8fe78261c8f103b674e3847b0fcc commit f855673ca6c5eeeb8c5d74521110ab31d9dc898f Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 14:45:05 2013 -0800 Style errors on profile better Do what Special:MobileDiff does and 404 on no argument Style like Special:Nearby for errors Tweak language Bug: 57087 Change-Id: Icfcf2c9ac4d58fc8bacbe4617b024a255a5469b4 commit 9d8dbf9801a124bc66e51d522bc03949c05d0eac Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 11:34:32 2013 -0800 Make last modified bar green until page is >= 24 hours Bug: 56862 Change-Id: I1b30bf583b5f6b18030ceff11e47ed53ed46f83f commit 4d996372e5df04416629a08ff3d25602fbbd51f2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 11:25:53 2013 -0800 Stop flash of last modified bar * Move last modified code to top of page * Fire header-loaded event after the last modified bar has been rendered (will not effect cached pages) Change-Id: Ia24c6ff4efc4c5286f69c5e1acc86e16ac9cf73c commit 32b2538ee3e9d273bf76ebde66fcb822810cc1df Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 12:25:56 2013 -0800 Fix media viewer for images with unicode characters Also address FIXMEs related to History.js which we no longer use. Bug: 57089 Change-Id: I8c8beb79b57d2a14b59fbc695df3262eee53ed59 commit 49c6a1c49078818f5fb1a69df77a2f017c5d0397 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 22 16:03:05 2013 -0800 Hygiene: Remove title exists check on Special:History Without 404 it shows "No history matches the filter provided." This is also accurate and probably more helpful considering pages can be deleted. Restore the banner for non-existant pages. The banner for non-existent pages will show a red link. Change-Id: Ia0a612af3ff51c905eda8d9dbcbbefa10ee09fa6 commit 038dec5130bfbcd124b634710c290e7df6443c6c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:15:06 2013 -0800 Only display right button list when needed in OverlayNew This fixes overlay header in new notifications overlay on which there is a large gap in the corner of the overlay (right corner on LTR mode) Change-Id: I3fa8f9a37d291159c58d238364f10c6438f03561 commit 133447027981151e0cfac00463e2a98fb1d181a4 Author: jrobson <jrobson@wikimedia.org> Date: Tue Nov 26 11:13:07 2013 -0800 BF: Hide nearby button on VE mode In BetaFeatures when Visual Editor is loaded the nearby button should be hidden from view. Also see: https://www.mediawiki.org/wiki/ Talk:Beta_Features/Nearby_Pages#VisualEditor_save_button_issue Dependency: Ief6b5f53096dd5eeb43a72a7bb182a2c04ec97ca Change-Id: I78c7e03ecc15275eed5ef21898328d244c24fa34 commit 71c17de35cb075229ac2fdee6981b0ba840ea46e Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 12:58:46 2013 -0800 Hygiene: Uncomment and fix upload progress event test for Api Related to bug 44921 Change-Id: Idf8ef9c1e76103b9ef045a7e6e106b889711eeb5 commit dc9ed37697753eb34d4806e5a35aaca270cbc43a Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:29:36 2013 -0800 Don't ask about abandoning edit if no changes present Update micro.autosize in the process. Bug: 57377 Change-Id: I4e1f3fb0dee6e1e39306d8114e9e0d72af667b36 commit 4f177d1349ff2f4082a125c240db9462054feeec Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 13:06:42 2013 -0800 Fix markup in PhotoUploadProgress.html Make it similar to what OverlayNew.html uses. Bug: 57434 Change-Id: If57618b016c2896e351c3484fb7e06529b75e750 commit 48a1f09c37b00e06c2726817e1e1192ba608930c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Nov 26 12:37:16 2013 -0800 Don't set defaults using $.ajaxSetup() Bug: 57556 Change-Id: Iadb4ee2b336e07ae2dfec7f09798ba210f409f6b commit 711164c26d3b0846ada112b9f0526fadc0991b05 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Nov 26 20:23:17 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: Id535fcf2559b411762ec26536876d226fb5daefd commit 2e0cef6f44fcbc4e87f852cc6104258df0c5dcc7 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 22 15:39:04 2013 -0800 Desktop: Add Vector specific Special:Nearby tweaks It seems in Vector in Firefox since our reset is not applied the lists can be badly styled with bullet points and with a margin (our reset is not applied) I'd rather not tarnish our own less file so adding a minor less file to combat this. Bug: 57446 Change-Id: I15ed91662140ff131931f8ef40b1336bea2c83e8 (cherry picked from commit f0332c70fa73b69416e06fe7a64467979a979e7e) commit 65cfbba39ba5b1724c76369cd5fba667c536b6dd Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 22 10:42:58 2013 -0800 Beta Feature: Remove mobile styling from mobile on desktop * Avoid global style changes to buttons and to loading class as used by Watchlist * Fix styling of page list See: https://www.mediawiki.org/wiki/ Talk:Beta_Features/Nearby_Pages#Button_regressions Change-Id: I222f398e76cf219a9319fe50ffe73c2ff5625023 commit b43d847209a2148fa382406594be0c0c2dec3f0c Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 14 15:12:38 2013 -0800 Redirect action=history links to mobile view Change-Id: Icf162d34b1b3c566d46a9e98b0e3c736623e28c0 commit 59b0325e64e58f054b0a5f20e2f18ec29425aca9 Author: cmcmahon <cmcmahon@wikimedia.org> Date: Tue Nov 26 09:57:00 2013 -0700 password for Selenium_newuser is the same as for Selenium_user Change-Id: I4dac86d2216eb3b95955bbdde15bed155d2f473d commit e012f5fb51914c6ebf34d16f78270b26124748b7 Author: cmcmahon <cmcmahon@wikimedia.org> Date: Tue Nov 26 08:47:40 2013 -0700 update locator for tutorial overlay Change-Id: Iadeee27d43db6e296144151531c6c9f72bf81f19 commit f61bf26c717bf2bb4e6b4d8647917ed6c4befaf4 Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 21 13:25:44 2013 -0800 Beta Feature: Switch from + to * in regex In Commons for example geo coordinates render in the forn 37.9782663;-119.1324739 with no space between the semicolon and - sign Change-Id: Ic1610d0fc1a98d749927306eded8589144556745 commit 4bdfd75d91701feed9341f541ee76f19d21d4793 Author: kaldari <kaldari@gmail.com> Date: Mon Nov 25 07:26:59 2013 -0800 Adding default styling for tables Also removing some redundant styling for infoboxes and consolidating the two table.infobox styles. Bug: 49959 Change-Id: Ib3376651b8bbca3fb5b5ff8e3020efc435be0408 commit 8f980c9230e70487cc6cbce3d0d4320a9492533f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Nov 25 21:16:36 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I1fc2f48c1fe07858d4d96f6a823cdcfe4e3ec212 commit 74e2e1bed4d7a735c3311278e07fde7cfb255dcb Author: kaldari <kaldari@gmail.com> Date: Sat Nov 23 02:31:33 2013 -0800 Some fixes to the new overlay 1. Making continue and save buttons line up with the rest of the header by giving them a -1px bottom-margin. 2. Making continue button flip in RTL languages (Bug: 57404) 3. Fixing background position of .overlay .license so that the graphic isn't clipped at the bottom. (18px - 16px is 2px, not 4px). Change-Id: I97027b065e80b6057f4a0a879e2a6481c916ad84 commit dfb0c2c4a318e523eb185ca213e966fca9fc13d0 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Nov 24 20:35:05 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I15934bc17473eefedb78d9ad4fa77798a5d60468 commit 87d6a71817cc1644e0e4c605a3ad51a593d792cc Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Nov 23 10:47:58 2013 +0000 Localisation updates from https://translatewiki.net. Change-Id: I999ddd40cf893e0450dd7e6d179b558eb2a09fe8 commit df49db76d2bf66e37ff98cf412e9d38c26fc0526 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 22 15:51:19 2013 -0800 Hygiene: Fix references * Drop the mf prefix * Put JS in a folder like other modules * Separate reference specific CSS from notifications to fix bug 57409 Change-Id: I99beea7ebe87b92ae2e4ecb0573a159df70f107c commit 160013d74367a4f7c3407986493008f437b64211 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Nov 23 03:10:10 2013 +0400 Fix fatal PHP Fatal error: Call to a member function getLocalUrl() on a non-object in /usr/local/apache/common-local/php-1.23wmf4/extensions/MobileFrontend/includes/specials/SpecialHistory.php on line 94 Change-Id: I9c1a22ae12dee022254453ad6f931398d4c5a232 commit 3de54c9fd699a1e65f4c282854b2ed6c3fc289d8 Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 21 15:15:24 2013 -0800 Hygiene: Remove console.log statement Change-Id: I61eb1c33dfd34a3799af4493ef66657f734849de commit 194a04bbe153c132cc04025aeedf3602f074ba09 Author: jrobson <jrobson@wikimedia.org> Date: Thu Nov 21 11:44:10 2013 -0800 Hack around Wikibase extension bug Workaround to avoid language button incorrectly showing up on mobile Bug: 57094 Change-Id: I63da6e52e028f968cc8a3c92aee2484ef7c17a13 commit 6d58d0d4ce2550423c2f885dcc3fe1c5e7ae134b Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 20 10:34:46 2013 -0800 Cleanup this page has issues initialisation Limit to main namespace - user pages and user talk pages for example should never have issues! Change-Id: I95375a8347e07ef5de2c0efe3fe1ebf3f13ddcd7 commit 271737ca6f5981a46aaf698bbf93e6f91780a616 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 15:30:44 2013 -0800 Stop SHOUTING in special page headers Switch to lowercase minor tweaks to h2s to reflect change Bug: 57208 Change-Id: I33f9f5f1abfc366b53b130d92aad289ab5942fb4 commit 266c8805e8bd4b062d1ca7b61e3c7b3f23bc2142 Author: jrobson <jrobson@wikimedia.org> Date: Mon Nov 18 15:13:20 2013 -0800 Use prefixed title in Special:History banner Bug: 57119 Change-Id: Ibad184ac3d7fb62f605b773e0f7dbba3c5a81d28 commit 0d56beee11646bfa27a60b72021bf9ad17fd4dd1 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 15 10:44:27 2013 -0800 Hygiene: Remove unused code Same code exists in SpecialMobileUserlogin Change-Id: I40c18ec5f01891255aa006aa1f36720e476b9aa2 commit 96e18ea5a53c6e26fcede46f06ec4310f8429539 Author: jrobson <jrobson@wikimedia.org> Date: Fri Nov 15 09:27:28 2013 -0800 Hygiene: Add make phplint to Makefile and pre commit hook It's running on Jenkins so let's run it on commits too Prevent commits when they have jshint, less, php errors Change-Id: I4abac7a5236baab843fa5b3924d431e767a10edc commit c8d446be9164cf0c2fb88df717abdff709ce225a Author: Marius Hoch <hoo@online.de> Date: Thu Nov 14 00:26:53 2013 +0100 Make collapsible sections accessible to screen reader users I've addedd the relevant aria attributes so that screen reader users can know about the collapsible sections. Change-Id: Ie176f7fda685c320e7bc2fc740be59194adba945 commit a223d2abe476018cebb8a585d7c6222fb0340ac8 Author: jrobson <jrobson@wikimedia.org> Date: Wed Nov 13 09:23:14 2013 -0800 Hygiene: Cleanup diff css Avoid use of multiple selectors Change-Id: Idd47e8ebef4f16ce0127b8babdac46bcfe624672