Extension:MobileFrontend/Deployments/2013-11-21
Dependencies
[edit]Stories
[edit]- Story 1346: Edit overlay UI overhaul
- Story 1360: Add paging to Special:History and enable link
- Story 1345: Redesign notifications overlay
- Story 1347 2/2: Update this page has issues in beta
- Story 1347 1/2: Use new overlay for this page has issues
- Story 1099: Better search UX
Bugs
[edit]commit 194a04bbe153c132cc04025aeedf3602f074ba09
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 21 11:44:10 2013 -0800
Hack around Wikibase extension bug
Workaround to avoid language button incorrectly
showing up on mobile
Bug: 57094
Change-Id: I63da6e52e028f968cc8a3c92aee2484ef7c17a13
commit 3af6366769dd0c78ea30733d392413d7d7e32bb3
Author: jrobson <jrobson@wikimedia.org>
Date: Fri Nov 15 08:56:58 2013 -0800
Strengthen .tutorial selector
In certain circumstances the tutorials.less file loads after
overlays.less - this means the tutorial overlay gets a white
background - account for this
* Add slider-button class to avoid specificity wars
* Limit styling to .button class to avoid conflicts with tutorial
Bug: 57192
Change-Id: I70f2a610d441db9d8665a3ae6c37d17d033443a6
commit 942b56331682265dab3cbd33e5831860ff4e77e8
Author: jrobson <jrobson@wikimedia.org>
Date: Tue Nov 19 09:01:32 2013 -0800
Fix regression in HTML markup
Head items need to be added BEFORE the template is generated
Introduced by I43fc26bf334753b189e20921f142bade7658ac31
Bug: 57257
Change-Id: I111a1784b8e6b84747e598c2f71e48c5440297be
commit edfc6ddc49834d061d2105ff39a6438d5e43980e
Author: jrobson <jrobson@wikimedia.org>
Date: Mon Nov 18 10:52:10 2013 -0800
Last modified bar tweaks
* addressing padding
* introduce truncated-text class for ellipsis sentence truncation
Bug: 56861
Change-Id: Ibc7b37c49bb4bc393444b6130969d688710537c7
commit b974ba0dd19337b28460fa7bb35ee5c1436f5900
Author: Zeljko Filipin <zeljko.filipin@gmail.com>
Date: Mon Nov 18 17:39:22 2013 +0100
Added tags to all feature files
Bug: 51046
Change-Id: I60db380113e79a74657fcfaa2896bdcb2ac7e1ce
commit b00bef724c8cc91ace192b274466eb0f5bb5a8d0
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Mon Nov 18 12:52:21 2013 +0530
Don't run Router#checkRoutes externally
This causes callbacks for routes to be called too many times.
Bug: 56973
Change-Id: I467ffb1e7c7cc9bf58437673ff5ed8177a359430
commit b6872e90ad094266d93e507faec4b69968863dde
Author: jrobson <jrobson@wikimedia.org>
Date: Fri Nov 15 10:38:03 2013 -0800
Hack: Hack around ULS issue
Bug: 57091
Change-Id: I8d4983a432bf7f6197a0ae4159d9e07819f6c174
Hygiene
[edit]- Hygiene: Cleanup enwp.less prepare to destroy it
- Hygiene: Merge @contentMarginLeft/Right into @contentMargin
- Hygiene: Remove unused LESS variables
- Hygiene: The big skin cleanup
I18n
[edit]Localisation updates from https://translatewiki.net.
commitcommit cdb085db363bcb8718f072c6040732d88e8e8888
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Thu Nov 21 20:39:51 2013 +0000
Localisation updates from https://translatewiki.net.
Change-Id: I3d82cf10a5e5f48bb5c2b32a8075402bf52396c5
i18n: Tweak language of Nearby pages beta feature
commit 9660c61d2652c21773d05aa98069da2ffa4f23bf
Author: jrobson <jrobson@wikimedia.org>
Date: Tue Nov 19 13:33:37 2013 -0800
i18n: Tweak language of Nearby pages beta feature
Change-Id: I6af242ac527d678e829f3ddba32002ff51e1ebbc
https://gerrit.wikimedia.org/r/#/c/95318/4/MobileFrontend.i18n.php
commit af7ea9928371a451505f53dcfd22e3abceab1041
Author: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Thu Nov 21 12:50:01 2013 +0100
article -> page
Inspired by comments on
https://gerrit.wikimedia.org/r/#/c/95318/4/MobileFrontend.i18n.php
Change-Id: I80895b461ee272f1a6ff54199752553426eae956
Localisation updates from http://translatewiki.net.
commit 2c65a5857365c8a41ceaa0d72f8ce19bc696d497
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Wed Nov 20 20:43:20 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I82ab43f55dd92d780e8e88983a26fd37b16df312
Localisation updates from http://translatewiki.net.
commit f27318d9c14f31144003e49a41a3cdb42b5797ec
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Tue Nov 19 20:15:34 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I0be5dace391fee1acc8a67286109f7224c867882
Localisation updates from http://translatewiki.net.
commit 3144421e4fd71e0cdcdcd6671f02808e5fa6b7f2
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Mon Nov 18 20:38:43 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I72ca190f8e4c9dbf54c88c74ece12f28859be44a
i18n: Fix double-space
commit 3b0ca624744c4e89c27477206f34476b87cadc14
Author: Yuki Shira <shirayuking@gmail.com>
Date: Mon Nov 18 13:30:43 2013 +0900
i18n: Fix double-space
Change-Id: I2d75c2dcab2877d18030741ba81372686162d052
Localisation updates from http://translatewiki.net.
commit 00a9df69f6cbec7f79454b5f0dde0892c6466449
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Sun Nov 17 20:25:59 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I2bd719dc8ce3884a29a839018089f461553e8a33
Localisation updates from http://translatewiki.net.
commit b0fe2e289f3ecfdef188f83ade1514a7be017371
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Fri Nov 15 20:25:13 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I786989fbffdbe767406e3f32e7f4ff28fed94ed3
Localisation updates from http://translatewiki.net.
commit 972c0a4ca76cff7592f6990720f089ee96cd22d3
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Thu Nov 14 20:35:59 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I76c75636afe9883c312321fe4f081c136c684e58
Regressions
[edit]- Fix regression in HTML markup
- Regression: Fix upload button on Special:Uploads
Other
[edit]commit 925407cd72093509b60a5640c7f0eb8891c628e4
Author: Ori Livneh <ori@wikimedia.org>
Date: Tue Nov 19 16:13:48 2013 -0800
Disable MobileWebInfobox's attemptLogEvent
Change-Id: I3efc1fa64ec804aab8410e24d483eeb19463eea3
commit 90a070042db5b07f4b249d892163b123b8a03cdf
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Wed Nov 6 16:32:05 2013 -0800
Separate stable and beta search JS code
Use a global search-results event rather than a write-results event of a
SearchOverlay.
Change-Id: Ia8d61ffcc4e4eb936380c5cd1493a3070f2131b4
commit 8b9c28389848eca2d50cd23265069a9ba9181e88
Author: Zeljko Filipin <zeljko.filipin@gmail.com>
Date: Mon Nov 18 17:40:43 2013 +0100
Whitespace cleanup
Change-Id: I8285f1b4ae9a99d5bc658ba38d04e9a1d367635e
commit 224bbe495341d3847e05af2fe72dc89d00d3f671
Author: Amir E. Aharoni <amir.aharoni@mail.huji.ac.il>
Date: Mon Nov 18 09:53:47 2013 +0530
Set up GENDER for two messages
mobile-frontend-profile-last-edit already had GENDER support,
but mentioning the parameter in the message prevents warnings
at translatewiki.net.
Change-Id: I75647e3564bcff39d2cc585a792a7ba6dee3a1f7
commit b30dbc1a6e81da906fbaffb141bf35d7620a8a60
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 14 15:36:58 2013 -0800
Don't load beta features code on mobile
hehe.
If you do then Special:Nearby refresh icon breaks.
Also certain styles are loaded twice.
We shouldn't do this. Luckily this should only effect
a small minority of our audience.
Change-Id: Icd1cd6e6e526068c93879e7bcffbc59d8c11aebd
commit 54b9ff5ab5889c06f75c89a2f3b3b870154f5e32
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Fri Nov 8 17:57:04 2013 -0800
Make child overlay hide the parent forcefully
So that when clicking "What does this mean?" in photo upload preview
doesn't ask the user if they want to cancel the upload.
Add JSHint configuration change so that unused parameters are okay -
describing the interface is more important here.
Change-Id: Ieb75812bb9f1eb603a6e66aa09469feb97b27a5c
Raw git log
[edit]commit cdb085db363bcb8718f072c6040732d88e8e8888
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Thu Nov 21 20:39:51 2013 +0000
Localisation updates from https://translatewiki.net.
Change-Id: I3d82cf10a5e5f48bb5c2b32a8075402bf52396c5
commit 194a04bbe153c132cc04025aeedf3602f074ba09
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 21 11:44:10 2013 -0800
Hack around Wikibase extension bug
Workaround to avoid language button incorrectly
showing up on mobile
Bug: 57094
Change-Id: I63da6e52e028f968cc8a3c92aee2484ef7c17a13
commit 9660c61d2652c21773d05aa98069da2ffa4f23bf
Author: jrobson <jrobson@wikimedia.org>
Date: Tue Nov 19 13:33:37 2013 -0800
i18n: Tweak language of Nearby pages beta feature
Change-Id: I6af242ac527d678e829f3ddba32002ff51e1ebbc
commit af7ea9928371a451505f53dcfd22e3abceab1041
Author: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Thu Nov 21 12:50:01 2013 +0100
article -> page
Inspired by comments on
https://gerrit.wikimedia.org/r/#/c/95318/4/MobileFrontend.i18n.php
Change-Id: I80895b461ee272f1a6ff54199752553426eae956
commit 82437a13715de7e6f7db42d2c146e5279c9b72ba
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Fri Nov 15 14:51:14 2013 +0530
Story 1346: Edit overlay UI overhaul
Also, change @grayLight color to #cacaca, per Kaity's previous instructions
and remove .cancel for buttons (not used anymore).
Change-Id: I677aa4b79ee247c1accda67b697f1fbd9e278583
commit 3af6366769dd0c78ea30733d392413d7d7e32bb3
Author: jrobson <jrobson@wikimedia.org>
Date: Fri Nov 15 08:56:58 2013 -0800
Strengthen .tutorial selector
In certain circumstances the tutorials.less file loads after
overlays.less - this means the tutorial overlay gets a white
background - account for this
* Add slider-button class to avoid specificity wars
* Limit styling to .button class to avoid conflicts with tutorial
Bug: 57192
Change-Id: I70f2a610d441db9d8665a3ae6c37d17d033443a6
commit 2c65a5857365c8a41ceaa0d72f8ce19bc696d497
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Wed Nov 20 20:43:20 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I82ab43f55dd92d780e8e88983a26fd37b16df312
commit 056f01074b6a58ce6a67ef39be6007e831aec0a2
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 14 15:09:14 2013 -0800
Story 1360: Add paging to Special:History and enable link
* Add more button to bottom of page to allow going back in time when
there is more history to show
* Add error message when no history is returned.
* Link to it from the last modified link
Change-Id: I8ed1607259d3babb21c29d6256379fc89dc99204
commit 4b30b1bd0c3cacd634f6912fade62f2083148595
Author: jrobson <jrobson@wikimedia.org>
Date: Wed Nov 20 11:28:34 2013 -0800
Story 1345: Redesign notifications overlay
* Separate notification code out into mobile.notifications module
* Override in beta
* Use OverlayNew
* Support back behaviour
Change-Id: I0edb2a2cf7167554ecd14f40665411e05c305d52
commit 5abaf28d59b26bfb818b5623083b043e449ead01
Author: jrobson <jrobson@wikimedia.org>
Date: Wed Nov 20 11:21:30 2013 -0800
Story 1347 2/2: Update this page has issues in beta
This concludes the required style changes.
Moved existing images to issues folder
Change-Id: I29976d8201d7f426878fa1c7f31eff5f04dca8ee
commit 06e546e676546d5bb522bd95d49cac1023d1d774
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 14 08:44:49 2013 -0800
Hygiene: Cleanup enwp.less prepare to destroy it
* .navbox is display:none in hacks.less yet there are loads of rules
in enwp.less that style it. Thus removing.
* other things are hidden in hacks.less so moving other display:none
rules from enwp.less there
* add FIXME to destroy enwp.less - originally it was designed to be
for enwiki specific styles but now we have Mobile.css and hacks.less
this has become confusing and redundant
Change-Id: I3eb546c869ff5db25f1ee0e8843149103302668e
commit 1f4c9799036e2f2c4d9cfafb4c4209c12cd51501
Author: jrobson <jrobson@wikimedia.org>
Date: Wed Nov 13 17:20:39 2013 -0800
Story 1347 1/2: Use new overlay for this page has issues
Update resources so that it is easy to swap out Overlay for OverlayNew
Add back behaviour to new overlay
Restore margins to cleanup template list
This patch DOES NOT address styling of icons
Change-Id: Ica89fee9b3a5d60ab677205b48bafce55b15dc2e
commit 925407cd72093509b60a5640c7f0eb8891c628e4
Author: Ori Livneh <ori@wikimedia.org>
Date: Tue Nov 19 16:13:48 2013 -0800
Disable MobileWebInfobox's attemptLogEvent
Change-Id: I3efc1fa64ec804aab8410e24d483eeb19463eea3
commit 942b56331682265dab3cbd33e5831860ff4e77e8
Author: jrobson <jrobson@wikimedia.org>
Date: Tue Nov 19 09:01:32 2013 -0800
Fix regression in HTML markup
Head items need to be added BEFORE the template is generated
Introduced by I43fc26bf334753b189e20921f142bade7658ac31
Bug: 57257
Change-Id: I111a1784b8e6b84747e598c2f71e48c5440297be
commit f27318d9c14f31144003e49a41a3cdb42b5797ec
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Tue Nov 19 20:15:34 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I0be5dace391fee1acc8a67286109f7224c867882
commit 0fe4311c95e3d7ef9cea67318b1de7b31a33ca02
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Tue Nov 12 19:48:32 2013 -0800
Story 1099: Better search UX
Bonus fixes:
* search in progress indication
* aborting old requests if search query changed
* double check if response is the response to the latest query
* clean up OverlayNew CSS
Change-Id: I842ff097814f66cb7cca4949b5ccadff834029c4
commit 3144421e4fd71e0cdcdcd6671f02808e5fa6b7f2
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Mon Nov 18 20:38:43 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I72ca190f8e4c9dbf54c88c74ece12f28859be44a
commit edfc6ddc49834d061d2105ff39a6438d5e43980e
Author: jrobson <jrobson@wikimedia.org>
Date: Mon Nov 18 10:52:10 2013 -0800
Last modified bar tweaks
* addressing padding
* introduce truncated-text class for ellipsis sentence truncation
Bug: 56861
Change-Id: Ibc7b37c49bb4bc393444b6130969d688710537c7
commit 90a070042db5b07f4b249d892163b123b8a03cdf
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Wed Nov 6 16:32:05 2013 -0800
Separate stable and beta search JS code
Use a global search-results event rather than a write-results event of a
SearchOverlay.
Change-Id: Ia8d61ffcc4e4eb936380c5cd1493a3070f2131b4
commit 3b0ca624744c4e89c27477206f34476b87cadc14
Author: Yuki Shira <shirayuking@gmail.com>
Date: Mon Nov 18 13:30:43 2013 +0900
i18n: Fix double-space
Change-Id: I2d75c2dcab2877d18030741ba81372686162d052
commit 8b9c28389848eca2d50cd23265069a9ba9181e88
Author: Zeljko Filipin <zeljko.filipin@gmail.com>
Date: Mon Nov 18 17:40:43 2013 +0100
Whitespace cleanup
Change-Id: I8285f1b4ae9a99d5bc658ba38d04e9a1d367635e
commit b974ba0dd19337b28460fa7bb35ee5c1436f5900
Author: Zeljko Filipin <zeljko.filipin@gmail.com>
Date: Mon Nov 18 17:39:22 2013 +0100
Added tags to all feature files
Bug: 51046
Change-Id: I60db380113e79a74657fcfaa2896bdcb2ac7e1ce
commit b00bef724c8cc91ace192b274466eb0f5bb5a8d0
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Mon Nov 18 12:52:21 2013 +0530
Don't run Router#checkRoutes externally
This causes callbacks for routes to be called too many times.
Bug: 56973
Change-Id: I467ffb1e7c7cc9bf58437673ff5ed8177a359430
commit 224bbe495341d3847e05af2fe72dc89d00d3f671
Author: Amir E. Aharoni <amir.aharoni@mail.huji.ac.il>
Date: Mon Nov 18 09:53:47 2013 +0530
Set up GENDER for two messages
mobile-frontend-profile-last-edit already had GENDER support,
but mentioning the parameter in the message prevents warnings
at translatewiki.net.
Change-Id: I75647e3564bcff39d2cc585a792a7ba6dee3a1f7
commit 00a9df69f6cbec7f79454b5f0dde0892c6466449
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Sun Nov 17 20:25:59 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I2bd719dc8ce3884a29a839018089f461553e8a33
commit b30dbc1a6e81da906fbaffb141bf35d7620a8a60
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 14 15:36:58 2013 -0800
Don't load beta features code on mobile
hehe.
If you do then Special:Nearby refresh icon breaks.
Also certain styles are loaded twice.
We shouldn't do this. Luckily this should only effect
a small minority of our audience.
Change-Id: Icd1cd6e6e526068c93879e7bcffbc59d8c11aebd
commit 54b9ff5ab5889c06f75c89a2f3b3b870154f5e32
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Fri Nov 8 17:57:04 2013 -0800
Make child overlay hide the parent forcefully
So that when clicking "What does this mean?" in photo upload preview
doesn't ask the user if they want to cancel the upload.
Add JSHint configuration change so that unused parameters are okay -
describing the interface is more important here.
Change-Id: Ieb75812bb9f1eb603a6e66aa09469feb97b27a5c
commit bd81682849f8ab3bb0497f42d16f2dd1ea14e731
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Fri Nov 15 14:07:46 2013 +0530
Hygiene: Merge @contentMarginLeft/Right into @contentMargin
Change-Id: I46e67bf9fc0a83692ca957a359d336c99db7c774
commit b0fe2e289f3ecfdef188f83ade1514a7be017371
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Fri Nov 15 20:25:13 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I786989fbffdbe767406e3f32e7f4ff28fed94ed3
commit b6872e90ad094266d93e507faec4b69968863dde
Author: jrobson <jrobson@wikimedia.org>
Date: Fri Nov 15 10:38:03 2013 -0800
Hack: Hack around ULS issue
Bug: 57091
Change-Id: I8d4983a432bf7f6197a0ae4159d9e07819f6c174
commit a98eae6a3bde953629aad7d87706b292cdc57ec3
Author: Juliusz Gonera <jgonera@wikimedia.org>
Date: Fri Nov 15 14:00:22 2013 +0530
Hygiene: Remove unused LESS variables
Change-Id: I3a6571961e985ac354099b96470ec80ed147be7b
commit 5ef6af687e2b1f3237d5132ab75c3a2d9a3607e9
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 14 15:55:47 2013 -0800
Regression: Fix upload button on Special:Uploads
In stable the icon overlaps the text on Special:Uploads, this fixes
that.
Change-Id: I144129a84cc4d9c3441f548d7552cb66a1c666a1
commit d92e1920cda0aaa81d4428d70ffe1e143c2efb02
Author: jrobson <jrobson@wikimedia.org>
Date: Thu Nov 7 13:23:34 2013 -0800
Hygiene: The big skin cleanup
By exposing a way to add to template data in core
a lot of our skin code disappears magically
Note: Toggling does not work in the desktop version of
the Minerva skin. This is a known problem and being addressed
separately.
Change-Id: I43fc26bf334753b189e20921f142bade7658ac31
Dependency: I0a9a7f10ea6a2e9c90c2a83e7c5f7fa56fa0fb93
commit 972c0a4ca76cff7592f6990720f089ee96cd22d3
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Thu Nov 14 20:35:59 2013 +0000
Localisation updates from http://translatewiki.net.
Change-Id: I76c75636afe9883c312321fe4f081c136c684e58