Extension:MobileFrontend/Deployments/2013-07-16
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/980 * Use pencil icon for section editing
* https://mingle.corp.wikimedia.org/projects/mobile/cards/931 * Editing guider text
* https://mingle.corp.wikimedia.org/projects/mobile/cards/839 * Save from preview in editor
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=51261 * Wiki name is double escaped in left nav
* https://bugzilla.wikimedia.org/show_bug.cgi?id=51052 * Non-existant pages do not show in watchlist
* https://bugzilla.wikimedia.org/show_bug.cgi?id=51209 * Editor doesn't retain my position
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50136 * Cannot edit my vector.css user page
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50145 * $wgMFLogEvents = false causes problems with EventLogging dependencies are present
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46581 * Compilation failed: regular expression is too large in ApiQueryExtracts
* https://bugzilla.wikimedia.org/show_bug.cgi?id=51067 * Bottom bar with summary input field jumps down (editor)
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50699 * MobileFrontend: 'Logged in as X' alert has weird appearance and shows up inconsistently
* https://bugzilla.wikimedia.org/show_bug.cgi?id=51069 * Preview content visible through editor chrome
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50701 * MobileFrontend: Edit and watchlist buttons need pointer cursor
* https://bugzilla.wikimedia.org/show_bug.cgi?id=51078 * Watchlist url wrong when logged out
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50680 * Search field swallows the first character on Windows Phone
Uncategorized
[edit]* QA - Correct acceptance tests for main page * Make editor button work on Android 2.x * Localization changes * Cleanup .loading (spinner) * Remove dead code in editor overlay * Hygiene: Use consistent upload module naming * Reorg: Rearrange upload code * Updated Ruby and Ruby gems * Give EventLogging total control of whether to include itself on mobile * Fixed path to file specifying ruby path * Rm special casing for Zero on main page * Show special edit messages on significant landmark events * QA - Update Readme * Expose DOM to zero * Fix Qunit tests in Firefox * Regression Deal with cleanup template inconsistencies * Makefile Add make cucumber command * Prevent cutting off license image * Make photo upload overlay look consistent * Remove redundant CSS rules * Remove CSS rules for #mw-mf-header * Provide a higher resolution AJAX spinner * Add educational prefix to all less files * Remove device specific stylesheets * Quick hack to remove useless device modules * Small fixes to page actions * Fix JS errors reported by jshint 2.1.4 * Regression: Correct styling of the talk button * Fix text being cut off at the bottom of inline buttons * Make editor license links open in separate tabs * Style all the inputs and textareas in the same way * Output unchanged main page instead
Git Log
[edit]commit dde89a9b7e585c21dca05516b63f5867ac83f4e7 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jul 11 16:01:40 2013 -0700
Story 980: Use pencil icon for section editing Change-Id: Ib1e6b8f46555eb545a8de3bbed7a1e083212c1b0
commit 973bb4f1d339e7a26a121950e41f54c9f6bc658e Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 13:43:41 2013 -0700
QA: Correct the acceptance tests for main page A whole bunch of refactoring. Change-Id: Ia5fdaba8450266735981a470cbc0ae376f4f792c
commit c4c68443dce111ba024ffb3baaaa3eb41d85014c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 15 16:27:09 2013 -0700
Make editor button work on Android 2.x Apparently, the event object passed to hashchange callbacks in Android Browser 2.x does not contain some properties available in newer browsers. This patch changes the way the hash is fetched making the Router more reliable on older browsers. Change-Id: I25716393e7c8526c709f39375b06453a6dec26ef
commit dab0d9b78fbae364a175904896094c238418e35e Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 15 15:21:34 2013 -0700
Stop double escaping wiki name Bug: 51261 Change-Id: I5de71264862320701e9606e4d4b8bd2cabd69872
commit f5785d3a40b36e7d1d94e761676bbffb2446e6dc Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 12 19:07:24 2013 -0700
Story 931: Editing guider text Also, scope p inside .content in mf-typography.less to avoid unnecessary rules for p in other places. Change-Id: I3622840e3ce8be34bf14469084a271204fdffd43
commit 3ad02ce34e80090931be89991c34971d583142c9 Author: jrobson <jrobson@wikimedia.org> Date: Thu Jul 11 10:39:23 2013 -0700
Bug 51052: Show non-existent pages in watchlist Change the color for the .new link to be less harsh Reorganise pagelist css (it was confusing) Bug: 51052 Change-Id: I85a5f12e8a34c92f3a9e98ec1e1d8934ec4d0b22
commit 218d9cb99c8adcc0f13d2a6afb261470b6c5f8cb Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jul 15 19:28:26 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Idc719ee06f3fe87a4428e3c4747dc6ae4b2319c7
commit 3374404ea35e737df0af12c41dee43823cde4a7c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 12 13:57:50 2013 -0700
Cleanup .loading (spinner) CSS Also, make the talk button show the spinner when talk overlay is being loaded. Change-Id: I1a74774841045f820c4e8db338a819e5d08e24e6
commit a016be6e2483c8bc7a03bc53373dadada408a155 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 15 11:15:41 2013 -0700
Retain editor position when going back from the preview After clicking "Keep editing" Bug: 51209 Change-Id: Id5dde34d186c53f1f297905886aa63db94eed228
commit 1f204f2fbda65bde14d9b71c793ccdb24794ef8f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Jul 14 19:17:04 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I95c35377ffac3b5592440a0b634131baec1d6005
commit 2b9af6eb532d9e20dae994611ff6a9016862c03e Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 16:48:02 2013 -0700
Bug 50136: Allow editing of things other than wikitext This allows Mobile.js and User:x/vector.css and friends to be editable. Remove code responsible for multiple section editing in the process. Change-Id: I2057a86bf2b1c140ecb95e76376de5aa40cfaff7
commit ce68e53e430a02ad35ff19f2b0229fc05e289cc0 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Jul 12 20:15:28 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7d49dd4f10b1f9ed41b1b9bc9d20d977b764a714
commit c164007b5311e0a2f6f693c749ab5039cb7b0cc6 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 12 13:06:49 2013 -0700
Remove dead code in editor overlay Not needed since the preview is no longer a separate overlay. Change-Id: I78d055ebbd8f4007be373ef02dc22deafff63296
commit b560f672a2ae1ded58039fe8c704fe8e3bf801b3 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 12 12:17:48 2013 -0700
Hygiene: Use consistent upload module naming Follow editing naming convention Change-Id: I441fa8ac018ad7a4f61df21ce4d2ce31bdabd806
commit d1f29fa447b0817f28b5ab6aed8d544a0529c4b5 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 12 12:04:12 2013 -0700
Reorg: Rearrange upload code Create uploads directory Move everything into that directory Change-Id: I2760d9e2ac3745c727e47c01d240dc039a3541dc
commit ed9c9740e39559a4b5355ceb51eaeac6b2f7d195 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jul 12 15:22:29 2013 +0200
Updated Ruby and Ruby gems Change-Id: I33be446f35c0c2c4777a401cac075b298a2b8bb6
commit 557a44753c5a4b3026668c8124996ba584263693 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 12 10:19:04 2013 -0700
Give EventLogging total control of whether to include itself on mobile EventLogging has been running without problems for some time It should be given full control of itself in MobileFrontend This removes $wgMFLogEvents from MobileFrontend Bug: 50145 Change-Id: I2f49ad6b8eadb166728d82fabf06613fd75553e9
commit a4b5c2d618f9e72050af179e0210b0264bf1d79c Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jul 12 15:07:18 2013 +0200
Fixed path to file specifying Ruby version Change-Id: Ie91fbcecaae4074e3df4b765a42aac854cd95ed8
commit ec311fb6930014985a14826300baa8155f9997fb Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Jul 12 16:12:05 2013 +0400
Fix regexp error in prop=extracts Bug: 46581 Change-Id: I6d553d34cff347b7e0772ee1d1eab0843b303827
commit 6c78c90e8e3ce996b078330d7fd8a2a683ecf27c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jul 11 16:36:05 2013 -0700
Fix jumping bottom bar in editor on Android Bug: 51067 Change-Id: I184850955a68e73dac93905eff3c02a43a3b79d2
commit e3fc61e6370e4af13bbef0905aebf4845da9869f Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 16:29:57 2013 -0700
Bug 50699: Remove the logged in toast notification welcome=yes remains appended to the login link in the left nav as this allows us to log accounts created from clicking login in the left nav. Change-Id: Ibb9a4a601a3d7dba5ea5c102b53cffce803b433b
commit 01e322ab997f71ce26560b62a1f202af782b2da3 Author: kaldari <kaldari@gmail.com> Date: Thu Jul 11 15:12:09 2013 -0700
Cleaning up some old bogus CSS Bug: 51069 Change-Id: I78c640f59ab7e2501322aeb4c16aab96436890e3
commit 2225f2371243d8f8f0371bc891a1e776624f3cab Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Jul 12 01:14:43 2013 +0400
Rm special casing for Zero on main page Now Zero does it in a different way Change-Id: I3e9390cd3cc9488cf111088de6944c406991560f
commit 6fcc41bdbd24ddcb4d5e8d43d1652e64fdc21ca5 Author: jrobson <jrobson@wikimedia.org> Date: Thu Jul 11 13:26:24 2013 -0700
Show special edit messages on significant landmark events. Change-Id: I61b7a23c2292d2e99e22de92235b5e2a3198e826
commit e99ee1cbfb832581e8066f68657c3421fa22b10c Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 13:50:03 2013 -0700
QA: Update README Add note about user account setup Change-Id: Ia3ab7994634e97a936fea66656f29ecd31f36431
commit d3eaf91cd730f655d3076d63b9e31ddeb36407ef Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Jul 11 22:40:37 2013 +0400
Expose DOM to zero. Change-Id: I60fec71e9b9d4e5869e7825e75c29d911e6b6d87
commit 89c4ed6a770470818ff208b8a0e989bd0751c018 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Jul 11 19:13:04 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I39a2024f3822fe2b36bce3916ef367c5d6ea974a
commit b067eafbb8505ee4bddc04211c0aa986e4e059db Author: jrobson <jrobson@wikimedia.org> Date: Tue Jul 9 17:11:21 2013 -0700
Fix QUnit tests in Firefox Change-Id: Iab212a91b5a8a2c65e7c116b1cf15cd77d77f222
commit 5acbe78c84bc2beaa837fb09972669ef36acef01 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 12:03:49 2013 -0700
Regression: Deal with cleanup template inconsistencies Some templates use ambox- prefix rather than mbox- prefix e.g. es.m.wikipedia.org/wiki/Collage Without this the issues section may be empty Change-Id: Ie9e7e3f5e09a2fa66d0558b28524684743279983
commit 6811c22ec2bfe6392a0edb2b4a92ff31724ab4ab Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 16:34:20 2013 -0700
Bug 50701: Add cursor pointer Note on Chrome this doesn't seem to work for the file upload icon always. Works fine on Firefox. Change-Id: I9d1e52c4b5121ec10def8f744014f2789bdc6979
commit 9d4387fb82bfeb11d55a7463cc0e239ebe9ab622 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 13:43:14 2013 -0700
Makefile: Add make cucumber command make it more obvious how to run the acceptance tests Change-Id: I677a42afeaaaf61d3a839cd484d3017f3d38cc3d
commit 7f43451c93e035b71646053490ef54d5c922b251 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 17:20:30 2013 -0700
Prevent cutting off license image On big screens when license text is only a single line. Change-Id: I3cb28545d6cfd9a969c3496b8fbfde949cb8decb
commit abf8e3585e88e9572b53d61f458890888936087c Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 16:07:23 2013 -0700
Make photo upload overlay look consistent with the editor Move the license below the buttons. In the process make the photo preview an overlay. Change-Id: I00010926affb48fa3bda69d08e1452d821941350
commit 3eb52446c48843196e47391844f923450ee46b55 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 17:08:03 2013 -0700
Remove redundant CSS rules Style headings only inside .content, don't make h1 black, leave it the same color as other headings. Change-Id: I75bb9cff3df62ada0fbbdf74a18dbbc185683c6e
commit 328bb208f763d0097493e6a250f4f5f2e90f905e Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 12:16:13 2013 -0700
Story 839: Add preview header (follow-up) I forgot to add that in the original commit implementing the new preview. Added now to avoid Vibha's wrath. Change-Id: Icbdfe1fc5bf42e7978db4660d3e4ef4335a22ea3
commit 97031179767b75797e6b16d9bcf99a76b1ca3914 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jul 10 15:42:27 2013 -0700
Bug 51078: Correct anonymous watchlist url Tested against Iaa00ab48ac4d802b68c1c87ea14104cac01324dd Change-Id: I8e5339571724bf7a008bdc58558454528dfeb664
commit 1baeead7bc2dc078dd10cf4b183dee5d63536ebe Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Jul 10 21:28:40 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7c3a78084bdb46b413a1739b9576ed28830a48ae
commit 972a88d80021e843740ef0bb491d19f7a4a89790 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 17:15:31 2013 -0700
Remove CSS rules for #mw-mf-header This was removed May 7th, no longer in cache and can be removed. Change-Id: Ib352c3321ec7261229bc68353afca75d652b10cc
commit 126c7309448783da1df122c2ce889f96b5c7f319 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 16:06:51 2013 -0700
Provide a higher resolution AJAX spinner The previous one was only 32x32 and looked blurry on retina displays, the new one is 64x64. This one was generated using only 5 colors and optimized using gifsicle to keep the size small (2.2KB 64x64 vs. 1.8KB 32x32). Change-Id: Ie4db93ce819fe8a41fa98b717b2ff5443258b7df
commit 37c805e632d58e56027c92f560bacf81806c874e Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 8 11:12:55 2013 -0700
Add educational prefix to all less files It can be confusing that we auto generate CSS files from LESS files - let's make this clearer to our development community Change-Id: I7782f9624e0dc9d12bd7b7fdf27803020cbae4b6
commit c6f4a2f68f0de1a59750bd598c20c10f346e5312 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jul 2 15:00:08 2013 -0700
Remove device specific stylesheets Create a happy Max. Removes $wgMFVaryResources as not needed Change-Id: I9e45dc82690ee2e73f5d022b9a96efabc314f21f
commit 08bf543fbf49581b02a2e5389d333bc7f47a5596 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Jul 10 00:24:47 2013 +0400
Quick hack to remove now useless device modules Fix errors in server log caused by missing directory Change-Id: Id96853c84a44ae87a0c9eb57218bf47963586e0d
commit 7cb26ecb816dde5fd9b06786595e19e8474bf3c4 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Jul 9 20:38:03 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ica16a1c8ee782298b3d1392893e60370561ad9aa
commit 52b721463a0fda45cb3f722906ab75e2380b6570 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 13:01:05 2013 -0700
Small fixes to page actions * Reduce page actions top and bottom padding slightly. * Align the pencil icon with the left edge of the content. Consulted with May. Change-Id: Icb94f9cec460ec9b773fcdf5deb93bd47cd2d5aa
commit 51615caf3581067f3a226aaf55bab1c95b044c58 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jul 9 11:02:50 2013 -0700
Fix JS errors reported by jshint 2.1.4 Change-Id: Ice92f6102e285d3f92d13d839589aa6a1924e666
commit 9b9775f4c78dff3dff29cc6f84b9da94763eef98 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jul 9 10:15:02 2013 -0700
Regression: Correct styling of the talk button Change-Id: I3508299a851279dfb7224aff0d002fc115209c5e
commit 1e37276f7225ed4248f4f6f369e0ed03175b08a5 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 16:57:01 2013 -0700
Fix talk overlay button Regression after redoing editor preview. Change-Id: I6e9087bd0cdcca3c28b553ef4f936c299a104e5d
commit f6043514b0186bf7a1c13bfedd59a9ea7c6adfeb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 16:11:39 2013 -0700
Fix text being cut off at the bottom of inline buttons E.g. letter g, y, etc. Change-Id: I2614e583ae2c4177f5be70e7c1be6f7019a198d1
commit e8597a966519b9254ad95add28e9707f73d144eb Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 15:10:25 2013 -0700
Make editor license links open in separate tabs Change-Id: Ib2588d6e34b14e0d7ad950496296af44158d979a
commit 4f7ea845c770427a8acb61aa5e5f3f5c27c0fece Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jul 8 15:33:47 2013 -0700
Style all the inputs and textareas in the same way Rounded corners, same kind of border. Also, simplify search input's CSS a bit (and its clear button). Change-Id: I9775185114bffe45debaf167e1b80e15ef7f0f67
commit 17bb6bd3be38a72a46c50b9992e515d6e94c49ec Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Jul 5 18:08:23 2013 -0700
Story 839: Save from preview in editor Remove PreviewOverlay and treat preview as the last stage of the EditorOverlay. Add summary to EditorApi. Change-Id: Icac5b5f1418528ef08acfb6b5047d7d24e0e924e
commit ccee3043c6feb32df6040c614d32eeefcd5ff758 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Jul 9 02:00:01 2013 +0400
Output unchanged main page instead of nothing if no special cased ids Change-Id: I6afebbafac7b0a05a2c6ecfd883cc90be7d57bde
commit 17cb0c251455888546f45e2aaf8aad5249431088 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 8 13:48:17 2013 -0700
Bug 50680: Use mouseup rather than keyup to open search overlay Keyup seems to work on both Windows Phone 7 and 8 If statement and waiting for keydown seems unncessary. the focus via a mouseup or touchend is enough Bug: 50680 Change-Id: Iab1de24c21d1f937a793830ec23d90ab5c30f9a2