Extension:MobileFrontend/Deployments/2013-07-02
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/856 * Whitelist some pages on WMF wiki
* https://mingle.corp.wikimedia.org/projects/mobile/cards/867 * Update description of watchlist * https://mingle.corp.wikimedia.org/projects/mobile/cards/884 * Login/signup CTA from edit button
* https://mingle.corp.wikimedia.org/projects/mobile/cards/836 * Promote language overlay to stable
* https://mingle.corp.wikimedia.org/projects/mobile/cards/883 * Remove previous and next buttons from editor
* https://mingle.corp.wikimedia.org/projects/mobile/cards/831 * Improve left nag
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=49209 * Cannot handle opening two CTA's
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50133 * Make Nearby on Commons search NS_FILE namespace
* https://bugzilla.wikimedia.org/show_bug.cgi?id=49276 * Clicking links in preview loses my edit
* https://bugzilla.wikimedia.org/show_bug.cgi?id=49208 * Edit button sometimes chooses wrong section
* https://bugzilla.wikimedia.org/show_bug.cgi?id=50205 * Scary flash of unstyled William McKinley * https://bugzilla.wikimedia.org/show_bug.cgi?id=50255 * Talk page shows a talk button
Uncategorized
[edit]* Regression: Fix special pages on alpha * Fix qunit tests * Ensure the toast lasts for at least a second * Remove global fixtures * Tweaks to PHP ResourceLoader modules * Remove #mw-mf-page-left id * Introduce NearbyApi * Alpha: Surface nearby articles * Alpha Regression: Fix the main page * Restore edit section links after a successful save * Run qunit in debug mode * Make qunit work without debug=true * Regression: show uploads tutorial * Tweak variable description * Localization * Enable animations in nag overlay (stable) * Make inheritance model more consistent * Rewrite language overlay * Correct left padding on headers and footers * Sandbox alpha and beta skins * Remove support for api.php?action=parse&mobileformat=wml * Remove HTML comments * Remove unused .full-screen-search CSS rules * Alpha Regression fix search * Fix issues with uploads tutorial on iOS
Git Log
[edit]commit 2caca8eb4128916a1e0c6da4e2442a7bd26a1e3e Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jul 1 19:57:28 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Id4a7c3f9faa6a8b569c3b99300fd0fa1037152a4
commit be9c64eb267de6c222bc88ef83aa121f8a176ad8 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jul 1 11:59:36 2013 -0700
Bug 50255: Talk page shows a talk button Correct bad css rule Replace it with a css rule which hides talk button on talk pages Change-Id: I89466dcc5cc6cea8bdcbb3d4e821b3da5fbbd184
commit b1b76a923d35b73409b89c407eabf44dce7aafde Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Jun 26 00:54:26 2013 +0400
Card 856: Allow to disable mobile view on some pages Change-Id: Ie14ead1220eeb5bde2475a5482bcd4f94c603ec4
commit 43f5e385a24f6318208108e9982dff06f389adc0 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Jun 29 19:37:01 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I0c7bf81f5bbcb82389fdb4aca6a61169518671c5
commit 129991daa8f6d0805bde7e304602d94d9fe7b75d Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 17:28:42 2013 -0700
Remove global fixtures Change-Id: Iae69e9d4d4617e97689d0cca4605c5191d02b3e8
commit c13774768f63425a4dbdf81a8e35f77fedab9935 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 16:41:27 2013 -0700
Ensure the toast lasts for at least a second Currently a scroll event can hide it without the user having seen it. This can happen when an overlay closes Change-Id: I6fb63869825a5fd6b2352471cd6111a73e3f6db1
commit 79685575ecb389e5276dbf1a8cd09869c9a21dd2 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 16:39:06 2013 -0700
Fix qunit tests Change-Id: I168170e5383ac738e87ed7037b8c247c4fd12447
commit 5a026560b3442671696c8d4e903ff9e120157e67 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 14:34:54 2013 -0700
Regression: Fix special pages on alpha The history link is not always present... Change-Id: I98de3be8b29a0417269c6ae6dbbd10b91fa5f142
commit 7ac945eb494b7ba676149541c5d929e745fa4ad7 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 15:18:46 2013 -0700
Alpha Regression: Fix the main page Change-Id: If687518b427ea5eb2ba73c9c84c42a707689d5c3
commit 7431f5e52607029af43aac0acb8951a847b17458 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 21 17:47:56 2013 -0700
Alpha: Surface nearby articles Create a reusable Nearby view Note: currently for convenience putting all messages in mobile.nearby module in anticipation of refactor Moved mobile-frontend-nearby-link and mobile-frontend-nearby-directions to correct module Change-Id: I99eecdcd20eed8b4df88152f0eeecc6e730522cb
commit 646bcd4a7aabb5c6e7f097a412c3e6039a6a1074 Author: jrobson <jrobson@wikimedia.org> Date: Thu Jun 27 15:58:25 2013 -0700
Introduce NearbyApi to make nearby code more generic and reusable Add some more tests Change-Id: I5bf213346dba14a633cad2b2ebd1dbe15bc64a12
commit 9540f0c15da51e3effd5847993bd939d899f1c68 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jun 27 16:35:56 2013 -0700
Remove #mw-mf-page-left id Also, make JS use #mw-mf-page-left instead since that's what contains the entire left nav now. Change-Id: Id42763987186b1025ced30c9985cc65b57b12a38
commit eee213aac858745f0ced9b1afd37ab0720a272ab Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 10:51:04 2013 -0700
Minor tweaks to PHP ResourceLoader modules Don't assume the directory structure of the MobileFrontend extension as Krinkle points out it may be different and throw warnings Change-Id: Ieff90c87bd8656e9c3476cf0e1e11a33ff6c6f25
commit 588f355e144b089bce3fadbc186a4d40f3f0eebf Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Jun 26 14:52:57 2013 -0700
Story 831: Improve left nav
* Make left nav scrollable on smaller screens if it doesn't fit.
* Remove nav headings (new layout approved by Jared and Maryana).
* Make two bottom horizontal links text more dimmed (Jared's
suggestion).
* Make menu narrower (fixed 15em on small devices, Jared's suggestion).
* Fix a slight misalignment of the blue left border of hovered menu
items.
* Add shadow to the menu (consulted with Jared).
* Remove and refactor lots of CSS in the process.
Also:
* use mouseup fallback for closing the menu (touchend doesn't work in IE)
* don't close the menu when scrolling
* append toasts to #mw-mf-page-center instead of body to be consistent
with drawers and avoid weird bugs
* set default background for body (#fff)
Changes tested on:
* Safari on iOS 6.0.1 and 6.1.2
* Android browser 4.2 and 2.3
* Chrome for Android (latest)
* Firefox for Android (latest)
* IE on Windows Phone 7.5
* latest desktop Chrome
* latest desktop Firefox
* Opera 14 for Android
* Opera Mini 7.5 for Android
* Nokia C3 browser
Bug: 49455
Change-Id: I670d81eb949b866472dde0498bf2402dda254214
commit cd77a7850ef3d466a1bb7e780f7c48ba010e4942 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 13:59:33 2013 -0700
Restore edit section links after a successful save Change-Id: I2349d4f875a51d5def819155faff47ead1bca9bc
commit 5cfecd36f16bbcbaea9542915f71e1364995d4f3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jun 27 18:20:03 2013 -0700
Story 883: Remove previous and next buttons from editor Also solves bug 50301 since we never try to load more than one section per editor overlay. Bug: 50301 Change-Id: I15522e6e52dfef505f1d6322ceacc9eca33856c0
commit dcfa0d72670cc2040ffca594fb77ed62e49b60a6 Author: MaxSem <maxsem.wiki@gmail.com> Date: Fri Jun 28 19:21:55 2013 +0000
Revert "Card 856: Allow to disable mobile view on some pages" Tmp revert due to interaction with mediawiki-config This reverts commit d4b8bd6029083388b2568ba870bf8283a2e0711b. Change-Id: I7fe4792444cc754977b6d9b9c8de992fbb62cd91
commit 4d8e8c39d6a7eab899a91f6673506980fef7ad14 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 12:22:04 2013 -0700
Allow running of qunit in debug mode Change-Id: I5974a6b68e5f206f7629e365158d8724100e4db0
commit da525ecd3880d685000c250a44d92b57ac722b03 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jun 28 12:06:12 2013 -0700
Bug 50205: Avoid flashing of section content * Load toggle.css in the head of the document * Deprecate togglingEnabled * Use nesting in css rules * hide scary photos in the sections rather than flashing them Change-Id: I5c8baa6c1d85ec00aff1942deed1889be6618547
commit b189fc81d79532bcf5f35a86787a9f19ad96e1f2 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Jun 28 13:56:52 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I6cbefc72d10f4939c5c8f88688df96a6255647f3
commit 8f4f330c6b0f75db4ba316492ce9fefbc3fdb087 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jun 27 17:46:20 2013 -0700
Evict demons from uploads tutorial on iOS Showing the tutorial overlay in Safari triggered a scroll event which in turn triggered an empty event of PhotoList which created another tutorial overlay which then again triggered a scroll event, etc. Bug: 50201 Change-Id: I0385440102abe4c83b8f4cc453e8ab936dd00d0e
commit 931fd86b149b4c7599b8d2a654b4fa47cd41d83d Author: jrobson <jrobson@wikimedia.org> Date: Thu Jun 27 17:39:19 2013 -0700
Alpha Regression: Fix search Make sure lazy loading occurs Change-Id: I2bf74146a728abf3f7d37209a312a94506661b1e
commit a5c364b4bbb20e0fc1a1140ae97eff4585415621 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 16:55:46 2013 -0700
Story 867: Update assets to reflect new article action bar (2/2) Change-Id: Ic079a96fad1cb1c547269a22750ca2d2c7eced7c
commit b507be9089928c1e95b0158ba13c128deeb12239 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jun 27 16:18:03 2013 -0700
Remove unused .full-screen-search CSS rules They are not needed anymore since search is an overlay now. Change-Id: I7eacdab23a81a81b436918408fc3f7569f10a6cb
commit d1646c939224633290f6e313689d21a0b121de73 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Jun 27 16:13:31 2013 -0700
Remove useless HTML comments They are not needed. The code is indented and when inspecting code in Chrome Developer Tools or Firebug, they provide absolutely no value. Plus, we don't strip them in production. Change-Id: I2cad742d26a6bbe50e8f21a26b2b562df37c6e83
commit ae67d3692d5af22d25c4ab3931944a8d4aa2b928 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Jun 27 19:55:14 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I935bc4fcbec995244eae3838ac64d779663976cd
commit 7e6aa22b889647d6dfbda8b9ccfb333a13958553 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Jun 25 01:16:06 2013 +0400
Remove support for api.php?action=parse&mobileformat=wml It's messy and unused. Instead, return HTML and set warning. Change-Id: I4b87ae34e9ff7d11fa834dee1a2571d4f06d2454
commit 4d467d5a4429177fcf72be5962ec52cd3c5e15a8 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 24 14:18:23 2013 -0700
Sandbox alpha and beta skins from stable
* Add logic for beta and alpha skins into their own classes
* refactor MinervaTemplate to have two more
overrideable methods - renderHistoryLink and renderMainMenu
* Add the logic for main menu headers into MobileTemplateBeta and
reflect changes in MinervaTemplate
Change-Id: Ie848c604e25784b7c82175956e71a6f81edbbccb
commit a5f0b6447543ef451408cbd1908529d65eb5dc60 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 16:34:58 2013 -0700
Story 836: Promote language search to stable Change-Id: Ie44d9e24b2c1449ed112addf0048ed13d812662b
commit fd4ed49699301929ba876aa425713f1ad5560199 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 16:26:11 2013 -0700
Correct left padding on headers and footers in 'list' overlays On search, talk and language overlays the header doesn't line up with the list of results. This fixes it. Change-Id: I78f608b43cc6b9c304fef08cd29edbb250dc21f9
commit 89cd4cd794e86407eeae37779b81be2282e26df1 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 16:11:52 2013 -0700
Rewrite language overlay * Stop copying and pasting HTML into template * Add serialize function for turning HTML in language list * Separate language overlay code * Separate preferred languages code * Make article title render in the language overlay Change-Id: Ica241c6ec7743fb5d07240b022d28eb24d9dfac7
commit 98dff6c3a3f3f9d6ebd97de91391fd25b010ab1b Author: jrobson <jrobson@wikimedia.org> Date: Wed Jun 26 14:16:05 2013 -0700
Bug 49208: Make sure the edit link chooses the correct section Change-Id: I6a9eb693c580f06e1ff3b4d228a9338bfb50f7e2
commit 7017d6f08b4b01dec165f95754b65c2879763f28 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 17:10:22 2013 -0700
Story 884: Add CTA for edit icon Change-Id: I51d20099aae9de18608d2cbe8b20c8b6f354e46d
commit 6f56e00599ae85c1ee8fa95be7758e3c8a7594e8 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Jun 19 15:12:52 2013 -0700
Introduce Class Make our inheritance model more consistent. This is mostly copy and paste + making sure that child classes call parent's constructor. Change-Id: Ifd38f20ab08cbb311adfef5c53e6707cf1789410
commit b2e876a57a4c30ed3f356b6771a4eec149dc1a80 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Jun 26 19:22:20 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I2031b74f1f6f7101e90697fc71582955e6a02ef1
commit 4daa68db2da0974d214717984d00944e7ec21749 Author: jrobson <jrobson@wikimedia.org> Date: Tue Jun 25 16:55:05 2013 -0700
Story 867: Update copy for empty watchlist (1/2) Change-Id: Idf6e3f17031eadd60635483068a741810b826914
commit d4b8bd6029083388b2568ba870bf8283a2e0711b Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Jun 26 00:54:26 2013 +0400
Card 856: Allow to disable mobile view on some pages Change-Id: I6e65b4928ea745e9796ebba297323759fc52c3b2
commit 001e4963a85c9e0d3807499598c4d1229be3fb36 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jun 25 12:19:35 2013 -0700
Enable animations in nag overlay in stable Make sure others only run in beta / alpha to allow for further testing. Change-Id: Idfe4182f8835f5e879dfa96489f482cd5b5afc0c
commit 969985d727d95630dc04d55720919968a346938f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Jun 25 19:57:01 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ida79d52406c706b87bd389b242a7907d471e037a
commit 3b47d877fb11b0f6f7c7bfad4af34267fcefeafc Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Jun 25 23:15:46 2013 +0400
Tweak variable description Change-Id: I8b963886288489712e1256e8a6668622e3f5524a
commit 7062c5bc4a8d27628124fa0e7d1423c6dcea3a3a Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Jun 25 12:12:28 2013 -0700
Regression: show uploads tutorial for users with no uploads We missed that after adding infinite scroll. Also, remove the code for hiding the uploads count, this is done in PHP now. Change-Id: I60a09354052613312fc88eeafd1c097177ed3ac9
commit 8f57274bf106273966ab9e0179e2e7f828a09fd6 Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 24 20:54:55 2013 -0700
Register sinon as a true global make qunit work without debug=true Change-Id: Iac1e96be9bc0169849ec2fd323f6de3559eea32b
commit 1761974d15c5250176f3bb8480c9da85123edf1b Author: jrobson <jrobson@wikimedia.org> Date: Mon Jun 24 16:54:15 2013 -0700
Bug 50133: Allow Nearby to be configured to different namespaces Will allow us to enable Nearby on Commons Change-Id: Ia9b3bf27a397cb0365d3b7681f0c22818a74f61b
commit 151ae4cc27fe2445f9d712deb2ffc5e8f6b177ab Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Jun 24 14:55:30 2013 -0700
Hide a drawer when another drawer is shown Bug: 49209 Change-Id: I8b32c2f559b5a380b681a548d9196c5ffef60835