Extension:MobileFrontend/Deployments/2013-05-21
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/483 * Show intermediate copyvio/scope message * https://mingle.corp.wikimedia.org/projects/mobile/cards/762 * Refresh button on Nearby
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=48513 * First-time UX on Uploads page: flash of 0 uploads
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48190 * Flash of unstyled content (FOUC) in diff view
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48512 * French Nearby doesn't work (If geodata is not installed the special page should 404)
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48540 * MF beta/dragon mode section expansion fails in non-main namespaces
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48525 * Error/loading messages while Nearby loads
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48485 * Mobile leakage in Special:Nearby on desktop
* https://bugzilla.wikimedia.org/show_bug.cgi?id=48490 * wgMFMode lies
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46581 * Compilation failed: regular expression is too large in ApiQueryExtracts
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47374 * "Donate Image" button shows on Windows Phone 8 (mobile IE 10), but does not work
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47925 * Section toggle editing broken in beta
Uncategorized
[edit]* Remove CSS rule * Localization updates * Add profiling to mobile action * Copy text tweak * Make toggle dynamic * Use grep to find usages (mf-photo.js) * Move RL modules to their own file * Fix captcha field margin on create account page * Anonymize nested function to fix PHP fatal on multiple * Code cleanup * Use ' instead of ' for consistency * Fix special pages to avoid the side effect of adding modules to this page separate out of the constructor * Animate refresh icon correctly * Remove red border on error toast messages * Make footer links clickable when drawer is hidden (beta) * Add and use message for toast to the module * Re-enable mobile.site module and remove mobile.stable dependency * Don't add parent property to Overlay's prototype * Add refresh button to nearby * Tweak disabled and cancel button colors * Regression: Make login submit button's corners rounded * Regression: Fix Login button in CTA drawer * Remove unused variables * Allow template tweaks before rendering * Drop Skin from names of templates * Remove unnecessary template variables * Tweak the nearby preview
Git Log
[edit]commit 309a74a1312c1eddf3e2c8841259bcd1525fa8b9 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 11:44:24 2013 -0700
Bug 48190: Avoid flash of unstyled content on diff view Move modules to top of page simplify dependencies for diff view and add to top of page update test code to switch order of jQuery and mw.mobileFrontend for consistency Change-Id: I6c0e3d6d331934a7460cc4efcd5513a3652ce7d4
commit 6f350cb159a0b9aced44608f1ec978582fed9ae3 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue May 21 00:17:07 2013 +0200
Rm unused variables Change-Id: I7e09b0504ab8c3d157091c28819b9dcf8698c40b
commit 325c4b24416796d8642afff1ee197280b9516f96 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 11:10:57 2013 -0700
Add hook to allow template tweaks before rendering
Things like Zero want to override certain data keys. This allows
them to
e.g.
public static function onMinervaPreRender( $template ) {
$template->set( 'privacy', 'New privacy label' );
return true;
}
Change-Id: I89a89e9994b074d066e2a318aad0a160a634d7ae
commit fecb702e63f9fce324228ca0c92da30eb7ed8db1 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 16:27:58 2013 -0700
Drop Skin from names of templates Far too confusing. I wonder if this is why skin code ended up inside templates Change-Id: I0e79c5899aa1bc5adc8e567b1d098e5534d75491
commit 3e4021dc3ab663b6b802b9267db0d38ef431f881 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 15:51:25 2013 -0700
Kill unnecessary template variables Change-Id: Ia249491cc649e9bd6018df9beaa10d467f2f7a1a
commit 797adf572b437806319b9ebdc4c342969ecfc819 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 13:07:10 2013 -0700
Tweak the nearby preview * Move heading out of header * Make the preview only show first paragraph and show the page image * Make the listThumb class more generic so it can be used in the preview * Update retrievePage to allow access to lead section only Change-Id: I372d76d54b48f50c2aeb614bc34c0ed1e9f8a033
commit 4dc093a69ae10eff1c6a5827a1ffdf702536d944 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 11:22:17 2013 -0700
Bug 48513: Hide uploads of zero Hide them and only show them after that first successful upload Change-Id: If77c936125c7b715ae28261870279c9dddaf9328
commit 60d7c17ffcc60b85ee7db49f5190d22b725c68ef Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri May 17 15:29:48 2013 -0700
Remove unnecessary CSS rule Already in mf-common.less Change-Id: Ib219503cfb583fa2ae0fd1624fad59d7d0392191
commit 83d694bf706bd61748e72c7001ef444caeba5340 Author: Raimond Spekking <raimond.spekking@gmail.com> Date: Fri May 17 21:04:22 2013 +0000
Revert "Localisation updates from http://translatewiki.net." Overwrites I58d4ff45518ac3e70c1c1ccbda82816ec89f0bef This reverts commit dc2b42f82b8d1e5421497048eb6594da758bcc0a Change-Id: Id652377b2b72efd7811ec28a24c81599bb50e855
commit dc2b42f82b8d1e5421497048eb6594da758bcc0a Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri May 17 20:46:55 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I58d4ff45518ac3e70c1c1ccbda82816ec89f0bef
commit ceab7de1d9768a09522aac086fe48b2ef7808d56 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri May 17 23:12:07 2013 +0400
Add more profiling to mobile action=parse Will allow us to tell how heavily it is used Change-Id: Ie743466f79123e0df56640f0c44978dfcf9c5b12
commit 1ce808b5fd2e3a403c1531855f1b817b72b79d65 Author: jrobson <jrobson@wikimedia.org> Date: Fri May 17 12:08:23 2013 -0700
Copy text tweak Change-Id: I5597a5b9fef3286f86aeaa265067d250959b3228
commit ccd872836d4d56804dfb9bec31a7b6c1f60f8f1b Author: jrobson <jrobson@wikimedia.org> Date: Thu May 16 12:33:34 2013 -0700
Bug 48512: Fix more API stupidity Change-Id: Id3cb6fcf3c7bc268ddab4edb5bade56a7a595b73
commit 4ed620498dd56c86c369853676bef54f75966e78 Author: jrobson <jrobson@wikimedia.org> Date: Thu May 16 14:40:05 2013 -0700
Bug 48540: enable toggling same way in JS as in PHP Change-Id: I97a42df9f5c9c2a05bcfcc64a3319301e4102377
commit c494f352710c16ef238c221297aff2e7ab5e43b6 Author: jrobson <jrobson@wikimedia.org> Date: Thu May 16 14:30:34 2013 -0700
Make toggle dynamic an extension of toggle.js This makes more sense Change-Id: I1d45ffe033f894eeaa2cee62b4c70f17bc012955
commit 5b4590499ebe738e3126c4026a5cbafa2e326aa9 Author: jrobson <jrobson@wikimedia.org> Date: Thu May 16 14:02:48 2013 -0700
Bug 48525: Improve error handling in nearby Change-Id: I01bc59f83b3b7841530ab9c4026b9ebc13d516fc
commit a035c56b6d60f115ecdef91037f4dda97e44d1cf Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu May 16 20:14:16 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I90fb472a3e6022211c95b90f12f18416dcd1ca2d
commit b23a6fd04d971edc1cf2ed4be08288f3638d02da Author: shirayuki <shirayuking@gmail.com> Date: Tue May 14 07:43:25 2013 +0900
Give grep a chance to find the usages Change-Id: I426078248a02b231e50040bc0567ea7e64bd0fdc
commit 1afd100cfe1c505184a3df3a13b92602aec79fbd Author: jrobson <jrobson@wikimedia.org> Date: Wed May 15 16:23:58 2013 -0700
Move ResourceLoader modules to their own file MobileFrontend.php is becoming too messy. This copies what core does. If it's good enough for core... Change-Id: I4505258f28eec0ff1342b5fd0cd2449324a8361f
commit c0b3d399e30cd5f9ac0006151c2c51e205a2c9d6 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed May 15 14:19:12 2013 -0700
Fix captcha field margin on create account page Bottom margin creating unnecessary big gap after the recent CSS cleanup. Change-Id: I9fa6757fa8221478fde632fe50e606adc9172bb4
commit b750efbce57b03faf9299fc7f064f905a4c80a85 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed May 15 21:08:49 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I49816a1862ed4d82b097e69b47be81ad4b132bb5
commit 72fc2667038945c82b31714d8e8d4bb5f66c1ff6 Author: awjrichards <arichards@wikimedia.org> Date: Wed May 15 11:22:48 2013 -0700
Anonymize nested function to fix PHP fatal on multiple executions Change-Id: Id5be2aec43dbc2c1acdf92309eba982fd9967773
commit 9131ea5d13eea05f9c8f479de9cb93908a1d29db Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 19:45:15 2013 -0700
Bug 48485: Stop mobile leaking into Special:Nearby on desktop Shuffle around dependencies. Init watch star module in initialize function Change-Id: I0c33637d491ac5d436c30a0a958ea5ecb9b86226
commit 559063f3b6d20d2258d60db2697038e22590a7f4 Author: jrobson <jrobson@wikimedia.org> Date: Wed May 15 10:36:29 2013 -0700
Code cleanup: [ '..' ] to [''] Address FIXME Change-Id: I0f42c06d084c9cce5094d4d499ca2c077714bbce
commit 777f98dea82b108813ccab672c3ed6c27ee1bb38 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 19:35:27 2013 -0700
Bug 48490: Report correct mode and whether to disable images or not Move definition of wgMFMode into application.js Move wgImagesDisabled into makeGlobalVariablesScript so it gets added to HTML rather than JS which doesn't vary Change-Id: Ic5f45299e57fa55f1b95ca1753a488b9c4bf7b18
commit 2d188474aded73f9bbbddee4d63438ac70c9aef3 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Wed May 15 17:21:57 2013 +0200
Use ' instead of ’ for consistency Change-Id: I34449a066fde687e46ed40d418ae226601e16988
commit 7712e573d4d26d8fbe5449ec9871b7439288962e Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed May 15 04:07:35 2013 +0400
Fix special pages spewing modules to Special:Specialpages Special:SpecialPages constructs special pages. To avoid the side effect of adding modules to this page separate out of the constructor Change-Id: I0d6865fc619d1017a5e5152e2576f501483672cb
commit a81ebe4c20e8aa89c25f74395b5d8aaa6edf4af6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue May 14 21:25:29 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ia53a00fb3e2a5bb6f0b24d40415d1502565b0c78
commit 73e9035f003770eef211f3f3c86ce0500f8d8084 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 14:07:32 2013 -0700
Animate refresh icon correctly Change-Id: I2af15a27c3b6bc8eab075489e2c1dcef68e86c8b
commit c1c023eecb3a50f8ac1984395cbda05568c71a63 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue May 14 14:04:02 2013 -0700
Remove red border on error toast messages Regression after adding the border to non-toast error messages. Change-Id: Ibe96c3a5b7cd637814eec18d29aef029621386db
commit 0897a27b21a37d37e0b4604eaf64b7114f1f1fab Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue May 14 13:51:41 2013 -0700
Make footer links clickable when drawer is hidden (beta) Change-Id: I80792dedf8c542c044188f83d178af5623f57022
commit e4a6f221260781a23f026f117136c29fc0b9ffe8 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 13:35:23 2013 -0700
Add message for toast to the module that uses it Change-Id: I0150d0ea1fa452cef404efb55c4162d61001e8cb
commit 6f701b1c03788be92f828e736461926b83ab4e09 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue May 14 13:28:50 2013 -0700
Make elements at the bottom of the nav clickable A hidden drawer prevented elements at the nav from receiving click events. Change-Id: I48274e0e68d1783f1b1fa3e0290f082a2b901502
commit c6afb2a120b8d9e6086aa4f301fc4e5a402eb58e Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 12:13:02 2013 -0700
Re-enable mobile.site module Stop mobile.stable being dependent on it Change-Id: I4cc415bb0ca45a9c3d86a19dd727a6fc9cef96f2
commit f79ed09c6e078d295a7b7c3ef0d503d02ab95c25 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue May 14 22:02:42 2013 +0400
Add debug logging for bug 46581 Change-Id: I1f132f03930c02b259ad03987aef52cc24f4a848
commit aaf2c2ba3061d76c5928edbbada94528dd766077 Author: jrobson <jrobson@wikimedia.org> Date: Tue May 14 10:37:18 2013 -0700
Bug 47374: Deal with false positives Based on https://github.com/stucox/Modernizr/commit/d7ea4878b862367ad7eef0ed26a9d589c5de576a it seems that we will have to browser sniff to blacklist WP8 Change-Id: I4e18b23510df67e2e8131d645184673f419830c4
commit 8e17fabd2b6603621ca14cfe6df231f9f5814502 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon May 13 17:28:58 2013 -0700
Don't add parent property to Overlay's prototype It should be per instance and is set in line 71 anyway. Change-Id: If31055991f7060d02bb6349fee12619d10e6d612
commit a13a3e158642bfe2838dfcbf4a95d53fb2e5da5b Author: jrobson <jrobson@wikimedia.org> Date: Mon May 13 16:34:43 2013 -0700
Bug 47925: Let people toggle sections in editor Although we are rewriting editor lets make the existing one work again!! Change-Id: I7eea4b82d26c982776c48afb405a8d87dfa5afdd
commit a629f17b53900051f6bd723f45f95879ce0a13be Author: jrobson <jrobson@wikimedia.org> Date: Thu May 9 14:51:12 2013 -0700
Add refresh button to nearby Fiddle with the search button so that the nearby page can have both a search and refresh button Animate it when clicked when animations available Change-Id: I36758885d91e0afc08ff80f46c423545e4c35e28
commit 6162bb00d8285d56fe1a90452b116060d2853aa9 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon May 13 15:00:45 2013 -0700
Tweak disabled and cancel button colors Make the disabled button look more disabled and the cancel button less disabled (can be observed on the photo upload overlay). Change-Id: Iac68ef7351c515a182816f716ba46d655f066704
commit 0ecf70e2c1bafe7d1d4febd012fb3b59aba06f26 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon May 13 16:24:54 2013 -0700
Regression: Make login submit button's corners rounded This got messed up in one of the recent commits. Change-Id: I54a431360202ec18ea208e8d2dc256e391f76870
commit ee01d53297e7e76b77f5c453280f59129606b383 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon May 13 14:53:26 2013 -0700
Remove unused CSS rules .disabled was never used. :disabled:hover doesn't seem to be necessary. Introduced in first commit of button styles (Ie0b9ba777f41788d8d6bc1b02fae37584ce2908f) Change-Id: I139944c3bc4e1ee7ddbed3bf97698a492b4de243
commit 5ae0a01e7204efc389695516e06ce810b42f0cbd Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon May 13 14:47:42 2013 -0700
Regression: Fix Login button in CTA drawer It was no longer styled as a button. Change-Id: Idf0e811e34efeab57ccd1098f9a3a8c7041805ee