Extension:MobileFrontend/Deployments/2013-04-23
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/438 * Log uploads coming from Nearby
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=46473 * desktop view on mobile domain * https://bugzilla.wikimedia.org/show_bug.cgi?id=30405 * MobileFrontend extension should stop special-casing main page * https://bugzilla.wikimedia.org/show_bug.cgi?id=47133 * Some api responses do not contain coordinates unless you provide a colimit parameter
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47290 * Search button not clickable in non javascript mode
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46906 * special mobile options javascript runs at bottom of page
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47320 * Titles in Nearby run into distance
* https://bugzilla.wikimedia.org/show_bug.cgi?id=44959 * Open translatewiki tickets
Uncategorized
[edit]* Localization updates * PNG compression changes * Ruby gem updates * Promote banners to MirervaTemplate * Remove navigationStart * Define render function * Promote menu button generation to MinervaTemplate * Make sure global variables are not overwritten in MobileContextTest * Build content navigation menu * Cleanup Skin language and variants * Allow touchstart to move checkbox * Use super for language overlay * Fix format check * Profiling changes * Deprecate M.utils * Renames MobileContext::getMobileHost() to getMobileHostToken() * Make sure phpunit runs from the makefile * Add _super() to View * Give PhotoUploaderPreview access to log function * Use the correct logging function * Funnel for nearby/watchlist not working correctly * Rewrite search as an overlay
Git Log
[edit]commit e555ac20225f4f585638dffc5e468ffe53de8eb9 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Apr 23 20:20:28 2013 +0400
Uber-compression Change-Id: I8e2cfa330a9ee52fc48df97e07f02cee08953bb4
commit 9a68268529255847a4afc5e63879eccdc986f283 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 22 10:06:28 2013 +0200
Updated Ruby gems Change-Id: I4d0063dea24881d752f71ba0a2a0af2966e3b2d8
commit 05dd3852b8721065dc28c33b762fde5de108716f Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:24:08 2013 -0700
Promote all the banners into MinervaTemplate Use the time to refactor into one variable Change-Id: Ic065c8b358e736f5aa281efa05f2cb5ad389e368
commit 35346faf716a058280f1dcd6d55282f84bbfc119 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:17:04 2013 -0700
Kill navigationStart make it part of MinervaTemplate->render Change-Id: If631c77ad98cd126ea1b48f342e26dfbb2f22b48
commit 760e6f9c360541bfe19bac9e01a13bbb6054c879
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Sat Apr 20 22:42:49 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I1454b20ca3b517eb7bc302ef5fe3ba7310f788c7
commit 05dd3852b8721065dc28c33b762fde5de108716f Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:24:08 2013 -0700
Promote all the banners into MinervaTemplate Use the time to refactor into one variable Change-Id: Ic065c8b358e736f5aa281efa05f2cb5ad389e368
commit 35346faf716a058280f1dcd6d55282f84bbfc119 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:17:04 2013 -0700
Kill navigationStart make it part of MinervaTemplate->render Change-Id: If631c77ad98cd126ea1b48f342e26dfbb2f22b48
commit 237b2261be547b24ca9ada6071aceef18aeae249 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:10:19 2013 -0700
Define render function in MinervaTemplate to output page Make prepareData a public function that gets called in MinervaTemplate execute that mobile overrides Change-Id: Id34e1a6af58aa16f231379a379e391880c65d8e2
commit 0ac202dfa9d773276d6fa5c699524b1ca1f35003 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 11:05:52 2013 -0700
Promote menu button generation to MinervaTemplate This will allow reuse by desktop skin Change-Id: I4dda1436a1ef5dbdba72d3959c947f958d36aa74
commit 93a8847e8e4ac33411828a9449a401acdbdaebb9 Author: awjrichards <arichards@wikimedia.org> Date: Wed Apr 17 18:02:57 2013 -0700
Do not display desktop view on mobile domain I initially attempted to do this a less hacky way by attempting to more accurately determine whether or not a user was on a mobile-specific domain, but unfortunately it was an untennable solution since $wgServer will always evaluate to the desktop domain. This solution should work, although it will cause problems if there is a separate desktop and mobile domain, X-Device gets set by proxy or webserver that handles desktop domain, and the user attempts to access desktop domain. This seems like an unlikely scenario (why would you ever set X-Device for a desktop-only domain?). Also, I would've liked to have added tests for this, but unfortunately there's no reasonable way to handle cookies in phpunit :( Bug: 46473 Change-Id: I56f2c8a2626042bf7b9a1d94fbf14ec8e2f089c5
commit 2b378f754c2e7614409adeaacf9733c1df02aca9 Author: awjrichards <arichards@wikimedia.org> Date: Wed Apr 17 16:35:48 2013 -0700
Make sure globals are not overwritten in MobileContextTest Includes whitespace changes for readability Change-Id: I12299805b094c7dfa44203bd6af3b04ab13ec553
commit 87388009042f93360c11bdb489713950b8c243f2 Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 18 23:08:39 2013 -0700
Build content navigation menu Remove need for our variant code \o/ for a big red diff! Change-Id: I1b72dfdfa0fccd360b41e4bba713f93f9db1b2eb
commit 976a03e834f694d156ba7941db6caf96aa951d96 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 1 14:06:11 2013 -0700
Bug 30405: Don't special case homepage HTML in alpha Because it's always been horrible. Start trying to find other inventive ways using css to fix problem Disable table module on homepage (as tables are frequently used in this context) I've been walkin' these streets so long Singin' the same old song I know every crack in these dirty sidewalks of Broadway Where hustle's the name of the game And nice guys get washed away Like the snow and the rain There's been a load of compromisin' On the road to my horizon But I'm gonna be where the lights are shinin' on me Like a rhinestone cowboy Riding out on a horse in a star-spangled rodeo Bug: 30405 Change-Id: I444b061796b3e3344852327cf26b48e83381f457
commit 3ec7f23aa8176d2ae95e9a659c87c696ec921921 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 22:37:51 2013 -0700
Cleanup Skin language and variants Also introduce generic MinervaTemplate as a placeholder for a template for a future desktop/mobile skin. Change-Id: I2e339b52e780a686ebc77cf341e346aa90550571
commit 43adc37cda0d09c701389ac9c243b685894df84d Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 17 09:52:19 2013 -0700
Add protection for bug Currently the nearby page will 'explode' (not render) on this bug. This wraps the offender so that the page is still rendered and it is obvious which page has been effected by the bug Bug: 47133 Change-Id: I392a837af485f2528800c665088c8ae8e6f25f81
commit 66c272e353b855d5a899414686cbd80947034a39 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 16 12:28:37 2013 -0700
Bug 47290: Fix search in non-js mode Due to a combination of the negative right value and an empty meaning no users on the simple version of the mobile site or with javascript disabled can search. This is bad! This makes slight adjustments to form based on whether js is enabled or not. Change-Id: I1bcffd26e5770e3cec1865c0c4fd614b6835a905
commit 08f770258e9c8ef0a31cd5231c75ad271265bfcd Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 14:26:37 2013 -0700
On settings page allow touchstart to move checkbox Many demos have revealed people expect to be able to swipe these This gives the illusion that this has the desired effect. Change-Id: Ifd0cdf679fce42a2b6c2831690a9cc9ae33d7fba
commit ce974bc2e76b6971423e41316c965ee238b88081 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 14:04:25 2013 -0700
Bug 46906: Load mobile options at top of page Remove dependency to mw.mobileFrontend and add dependency to jQuery (rewrite in jQuery) Change-Id: I70dd777fb208439baf17066104cd7cb95a3e23dd
commit a84bf1e74a70b49d5eb411ba1a744a48ee13a2f1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Apr 18 19:43:53 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I86fb1d93953b43e473e316a7f5de65e5ee76c553
commit d1e02c2f7014975301d72b25c5d2abb6fa2f517e Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 18 11:34:31 2013 -0700
Fix FIXME: Use super for language overlay Change-Id: Ie51a2e0b616dde29a50687dffc2abad9a2c85998
commit 974801114ea7bf99e02552f5b2e095808a11d7bc Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Apr 18 16:26:58 2013 +0400
Fix format check Change-Id: Ia8fd129a604d1672641ad3e3d1e1308d5bbd2bc4
commit a359f67e0e5ece68e55fa3bf74a77c544c3ff641 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Apr 18 16:26:21 2013 +0400
Profiling Change-Id: I6d1a96b44cdc1f02425a5ebbc9729cf735ac1ae3
commit 1a03333654fd5a8bc51cdfc3acd38b386bfdb87d Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 13:33:32 2013 -0700
Deprecate M.utils With rewrite of search and jQuery-ification of toggle this is now surplus to requirements with this change Change-Id: I71ac0dc41dedbd654bbe1d7d6f98844b0c65bd37
commit 9abbb678075913b6f17e03a4402a7a071d68563f Author: awjrichards <arichards@wikimedia.org> Date: Wed Apr 17 12:43:47 2013 -0700
Renames MobileContext::getMobileHost() to getMobileHostToken() This method returns to the mobile-specific token from a mobile domain or mobile domain template, so the rename aims to better clarify what this method actually does. I updated the docblock to also help make it more clear. Also, added some test cases for this method. Change-Id: Ibcc8b5082cdda8223f69c748c0713abaf8385fd1
commit d13051246eab609f7ee8c4005ed5751c3fd38b44 Author: awjrichards <arichards@wikimedia.org> Date: Mon Apr 15 15:29:35 2013 -0700
Ensures phpunit run from the makefile respects MW_INSTALL_PATH This makes it possible to rely on the makefile for running phpunit tests in MobileFrontend on setups where MobileFrontend doesn't actually live in a standard location. Change-Id: Ie28dc4119b6e6d0a8f7e266db66529b17af55538
commit 02201237f20a4e6733df05eaadc2668d2958d37b Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Apr 17 18:57:30 2013 +0200
Add _super() to View This adds a possibility of calling parent's function from within child function. Change-Id: I9ce59f9af278f88c07f77629691ab14921b00dcd
commit bf17be93b97a1d8ca39795c52ad0f2909d75c094 Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 17 09:56:07 2013 -0700
Bug 47320: Make proximity right value consistent with watchlist page star
mimic li a.watch-this-article { right: 12px; }
Bug 47320
Change-Id: I81f02e27b53c24356a0d2a9b944d34b1c2875596
commit 169bb457f8cb101dae6abdc8be010a526d689525 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 16 16:39:05 2013 -0700
Give PhotoUploaderPreview access to log function Change-Id: I3ebf8f2aefdfa8605da533f3e3af7046458e198f
commit 44a707e31f2220b716eb2de70c2466b1faa7c21c Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 16 15:46:49 2013 -0700
Documentation: Link FIXME to bug A bug now exists so updating the FIXME Change-Id: Ie6c112e1ac237d1aa9ebdf4cf1176045cec1cc43
commit 8e8b8669f8a0db73bdea71c1393e5eb2c62dc8d7 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 16 15:17:44 2013 -0700
Use the correct logging function This is currently throwing a js error and not logging clicks to what does this mean. Eek. Change-Id: Icf31bfba3204d4e1abf16fc0e5184a3b590e8617
commit b867b70b5afe6eb43dc2a2a5b97d2afff48c9782 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 16 15:03:41 2013 -0700
Funnel fail The funnel for nearby/watchlist is only being flagged on the photo upload form on the uploads page. I changed the wrong file. Doh. Change-Id: I105a0c5935bfae33a3e462903b88359fbca33d3e
commit c090bfe0ccc54aec4fa57763dc71f8c63e897cdb Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Apr 16 19:45:54 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7e3c5a378004451b005d04ba69ed7e27d195fd1e
commit a3acf0ea76b611ba6f23f0cdeaf9ddac92c3174a Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 11 11:04:29 2013 -0700
Bug 44959: Allow overlay heading title to span 2 lines As raised in bug 44959, In some languages it is not 1 line. This fixes up the header so that the padding belongs to the header itself meaning the title will never overlap the 'hamburger' left menu button e.g. Special:Mobileoptions See https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-main-menu-settings-heading/en Change-Id: I27c719e85ba3e1c29891b2bf74d971bb433c2f5c
commit 3605a2d182876b1fb653a7a199ec1cd712b53750 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 10:27:28 2013 -0700
Rewrite search as an overlay This also has the side effect of fixing bug 40986 and changing our autocomplete so it only matches strings at the start of a search result Change-Id: I1f35b7360dcb69f832679ed3fe58889ff3a018d5
commit dd3308d4cd1bea8b3141970f663739b3739c2b4a Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 17:46:56 2013 -0700
Story 438: Log uploads from nearby and watchlist Sets a cookie with a short life time (1 minute) If that cookie is present on loading the article page it becomes the funnel. Change-Id: I55ca707b41d49859a1f783fb5b7e8fb8179f4946