Extension:MobileFrontend/Deployments/2013-04-16
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/438 * Log uploads coming from Nearby
* https://mingle.corp.wikimedia.org/projects/mobile/cards/394 * Styling Nearby
* https://mingle.corp.wikimedia.org/projects/mobile/cards/419 * Nearby enhancements: distance
* https://mingle.corp.wikimedia.org/projects/mobile/cards/430 * Promote Nearby to Beta
* https://mingle.corp.wikimedia.org/projects/mobile/cards/141 * Generic banner/notification system
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=44959 * Open translatewiki tickets * https://bugzilla.wikimedia.org/show_bug.cgi?id=47167 * wmf-selenium-bot should not report SCM changes in IRC notifications
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46480 * MediaWiki:Mobile.css and MediaWiki:Mobile.js no longer loading, breaks 'complex' lists types
Uncategorized
[edit]* Nearby fix using colimit * Device-specific styles should be last in the list * Localization changes * qunit with debug=true parameter * Fix automation tests * Updated Rubygems * Link to php guidelines in README * Fix jshint error * Style changes for page images on Nearby * Style Nearby distance * Suface page images on Nearby * Rewrite Nearby as an overlay * Allow Nearby page to run on a different api * Update Ruby gems * Refactored tests touse only one MediaWiki URL * Watir-webdriver Ruby gem * Rewrite menu generation * Make footer CSS available for all pages * Cleanup unused vars and doxygen * Use JQuery with toggle.js * Remove old b/c code * RL Add modules and styles * Remove the need for a button in sections * Fix broken phpunittests MFResourceLoaderModuleTest * Don't set $wfResourceLoaderDebug * Log 'what does this mean' clicks * Make device modules mobile-targeted * Regression Add handshake javascript * Automation tests - upgrade to stable version of FF * Automation tests - update to Cucumber 1.2.5 * Refactor the way we run mobile JavaScript tests * Regression: Fix menu button on watchlist * Fix search rename to #searchInput * Make special pages declare their modules * Disable upload CTA when $wgMFEnablePhotoUploadCTA is false * Moving zeor specific code over to Zero project
Git Log
[edit]commit 63ccfaf660589575d1a684dc4968aca5cb3484d0 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 15 11:29:35 2013 -0700
Address nearby FIXME using colimit just removing if statement and adding colimit parameter Change-Id: Iadf9db7d6cbf40e5703ebed45f7cabc1487724a6
commit dd3308d4cd1bea8b3141970f663739b3739c2b4a Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 17:46:56 2013 -0700
Story 438: Log uploads from nearby and watchlist Sets a cookie with a short life time (1 minute) If that cookie is present on loading the article page it becomes the funnel. Change-Id: I55ca707b41d49859a1f783fb5b7e8fb8179f4946
commit d3f8ec4c7b017014f421336aa146ba564a53313f Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Apr 15 20:19:25 2013 +0400
Device-specific styles should be last in the list Change-Id: I35a2a18978bf5c0965379e204641da910317d525
commit 386d34ca4a136c56e32a94998b4cda35e105376f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Apr 15 21:00:33 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ic0c4b21dbe70572e9089ab552a415316a48a2339
commit f61402194ed3dbafdb1b05370fc7f03810cef9a3 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 15 12:02:55 2013 -0700
Story 394: Show CTA on nearby when no photo Default when no page image to show a camera image to tempt people to upload photos This completes story 394 Change-Id: I7588246bbdaa90be221d7cb531373eb5b1233bf2
commit 9dde59b3925649e01fc83477b84b4dcde866a99b Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 15 11:30:42 2013 -0700
run qunit with debug=true parameter this is currently needed to ensure dependencies are loaded in correct order and avoid sinon complaints Change-Id: I1376e3113ac40b93bc387c1514b442e38d81bfc4
commit e756ea19bd674555f9e1bfc332430df078d7d74b Author: Michelle Grover <jcmish1@gmail.com> Date: Mon Apr 15 12:03:01 2013 -0400
changed element for searchbox to new name in order to fix automation tests Change-Id: I32618a13f87b605f881ff8ca74ee43f2b3bfcd1f
commit bd892b8e4afd33072492b43511f472e306dec0f1 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 15 17:30:22 2013 +0200
Updated Ruby gems Change-Id: I6ac8325e16426927edc951e55cd16b23f88b535d
commit 3f16a78dfc8de990c75a0a7c22c23446b0453a36 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 14:52:20 2013 -0700
Link to php guidelines in README Change-Id: I66ddc685f9c1794e42ae6d98ea20e09ce4a5ff95
commit 2de55186f9469894f3d405fb7255a14c7b0b2a6a Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 11 18:11:24 2013 -0700
Story 419: Nearby distance enhancements Change-Id: Iea3a3776eb05d5c1e8d5b0ad9964895aed2d64d6
commit 97faaad1069b3d792f417a07b0e954b3db018a96 Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 13:19:16 2013 -0700
fix jshint error Change-Id: I49ae1c9f7acb1c4d6f736cc334a8da7c199a11c0
commit b2695015fc00b71c2d58cdf470ee64b4c271155c Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 11 16:49:06 2013 -0700
Story 430: Promote nearby to beta Change-Id: Id93cfc77eea56c2a999e5ebf18f3c2035e2f1628
commit 9515ed8be8d74ec400be97802d5e864b31ae6bac Author: jrobson <jrobson@wikimedia.org> Date: Fri Apr 12 13:18:16 2013 -0700
Unsquish pageimages on nearby Take into account whether they are portrait or landscape Change-Id: I45aaaa0ff897febf8d8201fe87f310be88394cd9
commit 2bfc65bbee4d012de3eb7c887fdbc41a62b2ebf1 Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 11 14:09:37 2013 -0700
Style nearby distance Position to right Change-Id: I316f9bdf05d76e40780ade216a858f16a0ec0f4c
commit 649670a4f11e8430b4081b4b637086a64532d9c7 Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 11 11:14:04 2013 -0700
Bug 44959: Translate wiki related fixes Update qqq codes where ambiguity/confusion (open translate wiki texts) Allow nearby to support plurals Use elipsis in error message Change-Id: I3c3cd80f1527c65b852b583e6b3075ec98a4ebc3
commit f886658f73f93fe3909095126935e0c14735d000 Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 18:31:44 2013 -0700
Surface page images on nearby Using the geosearch api in this way does not provide proximity calculations (boo!) - so using haversine formula to do calculation on frontend Change-Id: I446dbd5d328c6a444e67aa1dd48b257b1169f64d
commit 2c0d387d2580f6fd5935ca33f34b36b07c0be62c Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 18:11:55 2013 -0700
Rewrite nearby as an overlay Reuse watchlist css No styling attempted in this patchset Change-Id: I727d606fb1c48a699b2964449fb3f33ae2d3b37e
commit 4ea883fddf8129e6104c6cafa21473d215c57d43 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Apr 12 18:15:10 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ifaa3bbabfeed0cde2631cd335c8cbd6fe420d2cf
commit 933b2c59ce44aa925f317756e2522d64e3d47b9b Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 17:51:40 2013 -0700
Dev Change: Allow nearby page to run on a different api Setting $wgNearbyHost to 'http://en.m.wikipedia.org/' allows nearby to run on a local dev instance. \o/ Change-Id: Ia5254f650da61b9faccdd38cc221b9c8c2552f3e
commit 4b874d255f7b52f243d6fa387626e8043ebee642 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Apr 12 13:19:47 2013 +0200
wmf-selenium-bot should not report SCM changes in IRC notifications Bug: 47167 Change-Id: I4dedb75902f968a1dce1e216f20dec82147e4ab9
commit 5b1a03b0ed65941c5182ac4342e844ef49a35bdc Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Apr 12 10:39:23 2013 +0200
Updated Ruby gems Change-Id: I816d14525b3f1e2e166aa0864fda6801606bc82b
commit 775994fd5677b97ce63645dbe0beeba927d16522 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Apr 11 20:22:11 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ie15100b53ee5ac8f0be6292df64e41371dcfedff
commit 43783966dd1248bab7ea7161eb29bc487201994a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Apr 11 20:00:20 2013 +0200
Refactored pages to use only one MediaWiki URL Change-Id: I9129709689edaea98690bf6c98a07079a96d685e
commit 1a3c7cdb887a27877f442122445878cb090530d9 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Apr 11 10:01:52 2013 +0200
Updated watir-webdriver Ruby gem Change-Id: Ie445c814d089759cb0b355f8b10549540fbb6c24
commit bf78071c24bfb0d422fdeacf4e7f60d93f54b0f1 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Wed Apr 10 12:59:05 2013 +0200
Updated Ruby gems Change-Id: If849ae600cf9869650ec4d97989a5a17cd90bdbc
commit 5326ce87549ce3b5b6436eeca234a7751886416a Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 22:16:28 2013 -0700
Rewrite menu generation This no longer varies the html on X-Device Change-Id: Ia8dae042f3765fc41b1c9c5144359a89906e15c2
commit 5a6c32dde64dc386918c237b779076f85c3f6903 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 15:18:34 2013 -0700
Rename scriptUrl to wgScript consistent with desktop skin template property name Change-Id: I8c1c033210ffa1b93b7302a4187d7f78df5c0ee6
commit 964337ee51ed592a17eee391ddbef40fa9d68dfa Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 15:01:18 2013 -0700
Rewrite footer how skins do it This rewrites the footer in a desktop compatible way Make footer css available for all pages Don't give the main page mw-mf-special use page-Main_Page as it is on desktop Change-Id: I1253edfaa5af3d7782a87caf2e3ab0c9b3ae66f0
commit e0b8dd72e31c0ad4211d29cc9e38bf326eb42994 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Apr 11 02:44:20 2013 +0400
Cleanup unused vars and doxygen Change-Id: I290d341f37f7560ce9441136f2ee567ce5c833ad
commit 17119f18c3b816edc682cf7ca095d514c39497d2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 08:26:26 2013 -0700
jqueryify toggle.js help with deprecation of M.utils simplify code in process Change-Id: I89d1a0b384a6e17f1d6ebcb0f23196794cee8dae
commit d69450ed590b679d2df359c866a6823b32340407 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Apr 11 02:39:37 2013 +0400
Rm old b/c code. MF now requires MW master Change-Id: I7a562887fafa232aa3caa474cc018e378c1eb55e
commit 3b5e3c07f39ef070389a00597b996912f47cad7b Author: jrobson <jrobson@wikimedia.org> Date: Sun Mar 31 15:47:32 2013 -0700
RL: Add modules and module styles to page as modules found This is dependant on https://gerrit.wikimedia.org/r/#/c/55446/ Changes: * Deprecates mobileTargets ** Fixes Bug: 47058 * Adds hook EnableMobileModules so other extensions can enable modules on beta or alpha Change-Id: I1abd8798189e1a3f6375e473ab944daa82daa1e3
commit a749b6008d464471f21d1a955f0da0756114c886 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 08:10:18 2013 -0700
Remove the need for a button in sections The fact we add an unnecessary button to the DOM has irked me for a while. It is only there for historic reasons. This patchset removes it and throws away lots of code in process This does however make a slight change which will need to OKed by design - the buttons are now always black (previously in closed state it had opacity 0.5) Change-Id: Ic501c8ccb65a72c85abbe386fe6504960b1665a2
commit a500fce370c3b37ff6376fdcece24a41753434a1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Apr 10 20:32:58 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ibab226a980748be93841de2c135da083aeb3933a
commit 0ca6112493adcd43a0ba9a4951a346f7f4e33f72 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 15:19:26 2013 -0700
Story 141: Set wgMobileDeviceName in a device specific js module Depends on $wgMFVaryResources = true Note the name wgMobileDeviceName may change in future but this is currently set in CentralNotice Unresolved issue: this must be run before the banner controller - use RL dependencies? Change-Id: I4f3a43b2172367d03504ee9318d51173f54e1623
commit 41b1bca2fa54deb8d8461304889594415af57af4 Author: awjrichards <arichards@wikimedia.org> Date: Wed Apr 10 12:21:04 2013 -0700
Fixes broken test, MFResourceLoaderModuleTest::testGetTemplateScript() The test was throwing an error due to missint files (templates/template.html). I couldn't find any such files in the source tree, so I commented the particular set out. This should be updated to use something real and currently existing. Change-Id: I7e5bcab09495bc12a6954b8451cb8e9ddb7a8d61
commit 3cb39f1dbbb9ac41efffae6631c22bc2abfa6892 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Apr 10 23:05:29 2013 +0400
Don't set $wgResourceLoaderDebug https://gerrit.wikimedia.org/r/#/c/50442/ made it enabled every time ResourceLoaderTestModules hook gets executed. Which gets executed every time $wgEnableJavaScriptTest is true. Change-Id: I3c219ff300ba3267d06c22769b5e4a700126b337
commit 216b21bd46bb7abc06ad22bb83233b7a3bebe39c Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 10 11:26:01 2013 -0700
Log 'what does this mean' clicks
Requires update to schema
Dependency:
https://gerrit.wikimedia.org/r/58551
Change-Id: Ib786bfc796596bb380c0e127e106c1f4e3a336c2
commit a400c6f2275f0a4b21ab58b52c5b945ce9639782 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Apr 10 03:19:24 2013 +0400
Make device modules mobile-targeted Change-Id: Ibee7dc880072ac59c357ef9c58f2a5c5cc650168
commit 51f27bd217a2277b631e5df518713f3fde3fc48f Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 9 15:33:46 2013 -0700
Regression: Add handshake javascript module Change-Id: I8eed07cae9d32ab46610d447f7579c66beacc314
commit 8155fccfe33bacaf9d9f032c8aab5a6a0cecf27a Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Apr 9 20:33:16 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I0ea059e4f1736c6c8d5e5a5f8111d11c58cf0746
commit e53b47fc98dbb3257891f03ca87d8de3edfdac22 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Apr 9 16:44:55 2013 +0200
Upgrade to the latest stable version of Firefox More information at: https://www.mozilla.org/en-US/firefox/new/ https://saucelabs.com/docs/platforms Change-Id: Icf30726d4625085b28f50afd95899b2158e92061
commit e503392cda887727692762c71601253209c7cb19 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Apr 9 15:44:13 2013 +0200
Update to Cucumber 1.2.5 since 1.2.4 was yanked More information: http://rubygems.org/gems/cucumber/versions Change-Id: I12f578adbee8ed8b859b9740e0ac4fc67c68801b
commit b0606e637d6aa4b8f1fd3e66f3c275ae3a38f5e3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 17:59:51 2013 -0800
Refactor the way we run mobile JavaScript tests
This introduces a few changes:
* /tests/javascripts follows the directory structure of /javascripts.
* onResourceLoaderTestModules hook automatically checks if there is a
test file for every JavaScript file we use in our ResourceLoader
modules and if it finds it, creates a corresponding RL test module.
No more dependency problems when adding new JavaScript test files!
* Messages and templates are loaded for tests just as they are loaded in
the extension itself (hence the changes in test_mf-photo.js,
test_carousel.js and test_mf-navigation.js)).
* Our JavaScript tests now have to be run using mobile version of
Special:JavaScriptTest page, this also ensures they run in the
environment they were written for.
* Sinon.js updated to 1.6.0.
There are a couple of hacks in place
* mobile.tests.base is prefixed with a 0. to force earlier loading. On
Jon's Mac Air this was loading after mobile.toggling module
* The settings tests set a cookie for 400ms. By the time the check was
run this cookie had expired so the limit was increased.
Dependency: I84e0512590de9ff2dbdf519d983a0c1c2d007194
Change-Id: I593a9c0e8edcb04a351a06a457327f63d698a298
commit 90c080bee2026e815fe2adc622b8d8c8e4225128 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 15:04:25 2013 -0700
Regression: Fix menu button on watchlist adding the button here is unnecessary. renderArticleHeader in Skin takes care of it. Change-Id: I883ad680a1773258994c63144c4fa191132482df
commit 6081c0dcb21c1d9b19fb0a9ed25b610574f34831 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 14:57:50 2013 -0700
Fix search (bad merge): Rename to #searchInput Follow up to I7867dcd4d9f7b477e19219fe6456713f15a3e714 Somehow this was undone Change-Id: I3b076e4a0db6f9f8bb55072975b46cd6d53a3b17
commit 4cf8d99c00b69a8424521c8dfb8479415ee58c61 Author: jrobson <jrobson@wikimedia.org> Date: Sun Mar 31 15:40:24 2013 -0700
Make special pages declare their modules Remove code to do this in SkinMobile Change-Id: Ifbd50a459e71b90ad662064486f3d1d329d9df7e
commit 0494cb9b1f339c8984928dbb76a4d3e056da3409 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Apr 8 20:01:34 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Id10f39a7a80257498108b5577f1136ab43a54674
commit 007625a6bff133455ca0fa3ff2eb740f614f9e15 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 16:19:20 2013 -0700
Bug 46480: Enable mobile site module Makes Mobile.js and Mobile.css work again by targetting mobile Moved into new folder to make this code more discoverable Bug 46480 Change-Id: I4eaf51af79bdda8ec758922f8d4b8d87f4b7aa39
commit f6531dc0647f1d7bed578fe0fa6494f73d74d10e Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 07:40:06 2013 -0700
Disable upload CTA when $wgMFEnablePhotoUploadCTA is false This hides the add an image to this article button when a user is not logged in. Hopefully it will reduce the volume of bad uploads Change-Id: Iba385d98874315788a8fc7393a46a465b89e344c
commit fd19c09b7d1d35d19638e42965e94ab09f460e4f Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 4 11:39:42 2013 -0700
Moving zero specific code over to Zero Should be merged at same time as https://gerrit.wikimedia.org/r/#/c/57553/ Change-Id: I1f0fe8ad1ea2b52031079f52d6e25b5fcf44d7af