Extension:MobileFrontend/Deployments/2013-04-09
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=46760 * Left menu visible on tablet view when searching on beta
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47042 * Build marked UNSTABLE instead of FAILURE
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46480 * MediaWiki:Mobile.css and MediaWiki:Mobile.js no longer loading, breaks 'complex' lists types
Uncategorized
[edit]* Localization Changes * CSS Changes - make watchlist start markup closer to desktop * Avoid SkinMobile-specific functions and properties * Don't add more than one photo upload button * Avoid exception running qunit tests * Rewrite commons description as template, use Information template * Set defaultrebase=0 * Alpha: Diff words rather than chars * Refactor the way we run mobile JavaScript tests * Fix menu button on watchlist * Fix search bad merge Rename to #searchInput * Make special page declare their modules * Disable upload CTA when $wgMFEnablePhotoUploadCTA is false * Removed step from test cases * Updated ruby gems
Git Log
[edit]commit 756eedc594032273dd5ace5a1c577d2603dc73b4 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 8 20:59:57 2013 +0200
Fixed Rake task so it reports failures properly Bug: 47042 Change-Id: I90306716321d3c66adceba6c72c4b82995898c0b
commit b0606e637d6aa4b8f1fd3e66f3c275ae3a38f5e3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Feb 21 17:59:51 2013 -0800
Refactor the way we run mobile JavaScript tests
This introduces a few changes:
* /tests/javascripts follows the directory structure of /javascripts.
* onResourceLoaderTestModules hook automatically checks if there is a
test file for every JavaScript file we use in our ResourceLoader
modules and if it finds it, creates a corresponding RL test module.
No more dependency problems when adding new JavaScript test files!
* Messages and templates are loaded for tests just as they are loaded in
the extension itself (hence the changes in test_mf-photo.js,
test_carousel.js and test_mf-navigation.js)).
* Our JavaScript tests now have to be run using mobile version of
Special:JavaScriptTest page, this also ensures they run in the
environment they were written for.
* Sinon.js updated to 1.6.0.
There are a couple of hacks in place
* mobile.tests.base is prefixed with a 0. to force earlier loading. On
Jon's Mac Air this was loading after mobile.toggling module
* The settings tests set a cookie for 400ms. By the time the check was
run this cookie had expired so the limit was increased.
Dependency: I84e0512590de9ff2dbdf519d983a0c1c2d007194
Change-Id: I593a9c0e8edcb04a351a06a457327f63d698a298
commit 90c080bee2026e815fe2adc622b8d8c8e4225128 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 15:04:25 2013 -0700
Regression: Fix menu button on watchlist adding the button here is unnecessary. renderArticleHeader in Skin takes care of it. Change-Id: I883ad680a1773258994c63144c4fa191132482df
commit 6081c0dcb21c1d9b19fb0a9ed25b610574f34831 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 14:57:50 2013 -0700
Fix search (bad merge): Rename to #searchInput Follow up to I7867dcd4d9f7b477e19219fe6456713f15a3e714 Somehow this was undone Change-Id: I3b076e4a0db6f9f8bb55072975b46cd6d53a3b17
commit 4cf8d99c00b69a8424521c8dfb8479415ee58c61 Author: jrobson <jrobson@wikimedia.org> Date: Sun Mar 31 15:40:24 2013 -0700
Make special pages declare their modules Remove code to do this in SkinMobile Change-Id: Ifbd50a459e71b90ad662064486f3d1d329d9df7e
commit 0494cb9b1f339c8984928dbb76a4d3e056da3409 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Apr 8 20:01:34 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Id10f39a7a80257498108b5577f1136ab43a54674
commit 007625a6bff133455ca0fa3ff2eb740f614f9e15 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 16:19:20 2013 -0700
Bug 46480: Enable mobile site module Makes Mobile.js and Mobile.css work again by targetting mobile Moved into new folder to make this code more discoverable Bug 46480 Change-Id: I4eaf51af79bdda8ec758922f8d4b8d87f4b7aa39
commit f6531dc0647f1d7bed578fe0fa6494f73d74d10e Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 8 07:40:06 2013 -0700
Disable upload CTA when $wgMFEnablePhotoUploadCTA is false This hides the add an image to this article button when a user is not logged in. Hopefully it will reduce the volume of bad uploads Change-Id: Iba385d98874315788a8fc7393a46a465b89e344c
commit 705e48d164e4f0d9c24ab7e649738263f2edcd6d Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 8 20:59:15 2013 +0200
Removed unnecessary step All tests pass without this step. Looks like beta mode is no longer required. Change-Id: Idc9ad1bc68744a9d09e39de3f58351446f5caac2
commit fd51f7a91553930d8ee03ba5d5c0d4f32bc1a8fb Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 8 20:48:03 2013 +0200
Wait until login page opens Fixes: expected "https://commons.wikimedia.org/wiki/Special:LoginHandshake?useformat=mob ile" to match "Special:UserLogin" Change-Id: I595c682b46408aa4809a0cf7b8e422350cb98037
commit a5064066d86a0c86a5ba8afcc0496af1ccd7d190 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 8 20:40:42 2013 +0200
Wait until login page opens Fixes: expected "https://commons.wikimedia.org/wiki/Special:LoginHandshake?useformat=mob ile" to match "Special:UserLogin" Change-Id: I396fd5201f8c77843f61ba5b0da5cf325d5d107f
commit eeb3d44d365b94058acfa1fbd07ad074240c9cac Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Apr 8 10:49:29 2013 +0200
Updated Ruby gems Change-Id: I35c852ea84f3322762160bdace40e413968cbd26
commit 5a94722213320fe9db8650813c5ebafdfd142ce3
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date: Sun Apr 7 20:53:54 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ie7705af8ecdde7004749c4458f88b75274cbd2de
commit bc382d90843e2786495a55157525b79c428bca30 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Apr 6 19:52:25 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7e5528011cf4a5b562f984f58653077337565bef
commit df4f3802fae0c9f3e8272abee0e3c7aae4afe15a Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Apr 5 22:27:46 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: If90daf9e6809efc0ab7f3ee954b6b01161cbf0bb
commit 74caea92f844ac77f68941e4eb1f8fa6caff9b45 Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 28 13:00:06 2013 -0700
Bring watch star css/html markup closer to desktop Change-Id: I4d67fd48586541e0f11c15f0088e3a2126221d71
commit 153e4e7e9823ea9d4d8e0b438e07074760fccc0e Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Feb 9 03:11:49 2013 +0400
WIP: Avoid SkinMobile-specific functions and properties Instead, use OutputPage properties from https://gerrit.wikimedia.org/r/#/c/48208/ Helps avoid fatals/confusion Change-Id: I6eabb5fb41b9f280a44c4ef8a1f2150ff092d741
commit 9a0ada681f77062e49e9e5c1f4b34595b51efa5a Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Apr 2 23:29:13 2013 +0200
Don't add more than one photo upload button Even if the page has more than one <h1> element. Change-Id: I0189617f93a1874b7133af0d3a195d67874bf9fc
commit 5e144cb2f623e06e8b7271a4714748f9fee4f9eb Author: jrobson <jrobson@wikimedia.org> Date: Thu Apr 4 13:18:04 2013 -0700
Tests: prevent exception Avoid error when running make qunit Exception thrown by ext.mobilefrontend.tests: 'undefined' is not an object (evaluating 'el.ontouchstart=cancelBubble') TypeError: 'undefined' is not an object (evaluating 'el.ontouchstart=cancelBubble') Change-Id: If579ec5d1add71d4c18fd4555d3b2aa2b8d1dd87
commit 72e1cf49b4c11146f241678759f8c07dead52b2a Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Apr 4 20:00:59 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I3c6ef9c796f89b6ee339394939ae96b9355052aa
commit 234bdc04f3af4d6eaf1f2d574a401ee56823e657 Author: jrobson <jrobson@wikimedia.org> Date: Wed Apr 3 15:41:43 2013 -0700
Rewrite commons description as template, use Information template Use <% as delimiters so as not to conflict with template markup Requires Template:Information http://commons.wikimedia.org/w/index.php?title=Template:Information (in future we may want to make this configurable) Change-Id: I15d4169f156841b7f77f571a406ff57f8e156ecd
commit 5e3e59fba34cb136d9d3593903b867224b5e1c3a Author: Catrope <roan.kattouw@gmail.com> Date: Wed Apr 3 14:17:21 2013 -0700
Set defaultrebase=0 Change-Id: I6b93571ac83f4fbbe48ccedb27a76d5d60747aad
commit 618a6cfe39720d1ee7969ba4a4e468e524ebba93 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Apr 3 19:48:32 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I3d8d1beac5432a920b559d43289e8e946892ce09
commit bcddef2aff0db7a4350a35256bf89c99aa36d1dc Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 13:44:48 2013 -0700
Alpha: Diff words rather than chars Experimenting this seems like a much better idea I think this will make jgonera happier :) Change-Id: I78b37acb0a85575870f316a9ad679a1305da7093
commit 335310ab230c6debd90bc3a0cdd508ef5b527097 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 13:27:07 2013 -0700
Add top context modules as well as styles - make login js run Currently this is not being added but should be Change-Id: I4156e53d72aa411de4045cf47bf8cda3c3836b87
commit 4b6af23436218ac434fc4e4dce1fad95f4700b14 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Apr 2 19:05:49 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iff9ae63952c2c379e972d47ac5e0c8c6b80c90ad
commit beedb9b5df3cdd0e098747913b44adf71dc577cf Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 11:16:09 2013 -0700
i18n: Reword bullet point 3 Remove repetition of word 'free' Change-Id: I7e5ecb80114b094e0981de399d0a1dc65b337f89
commit 47496d45db48da6a3dce10087fff52914b616327 Author: jrobson <jrobson@wikimedia.org> Date: Tue Apr 2 11:10:03 2013 -0700
QA Design Tweaks to copyright dialog change button to blue allow buttons with class .confirm to close overlay fix margins on list in copyright dialog Change-Id: Ic1397b6e893eab54a23f43f644559d198e5e6cb5
commit c5228db3de9877436349fa65291524f4e47c2dcb Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Apr 2 17:02:26 2013 +0400
New hook EnterMobileMode Informs other extensions that we're going to have a mobile page view Change-Id: I40734cfec8b7c955efe2e63586546f0784086f5c
commit df771f0c79eff50c3cc31cd9b10d360ae895f1d0 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Apr 2 14:31:07 2013 +0200
Updated Ruby gems Change-Id: If1b9067fee3ddec243fca32fe86a7a64c47c5ddc
commit 6729b3806fe69669c8837b4a050dc2ca296892b7 Author: awjrichards <arichards@wikimedia.org> Date: Mon Apr 1 17:41:54 2013 -0700
Fix failing tests Change-Id: I58baf0e4c61796b53bd847cf4a223989e0e3ab8b
commit fc5e90b7476801fe0d2b24bd67b1f135b5603a72 Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 1 16:28:50 2013 -0700
Bug 45622 - Allow invoking of SkinAfterBottomScripts This subtle change does exactly the same as before put also applies the SkinAfterBottomScripts hook allowing extensions like Google Analytics to be registered Bug 45622 Change-Id: I29184aa66fa6ecb527aa384b670f193e54a63f81
commit 478b5dfb1c71aeae0558694aa90a4516cd574a44 Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 27 14:18:57 2013 -0700
Rename #mw-mf-search to #searchInput This is consistent with desktops naming convention for the search box. I am rewriting the skin to be desktop friendly. Note: haven't refactored mf-search.js to use overlay - that's another exercise Change-Id: I7867dcd4d9f7b477e19219fe6456713f15a3e714
commit 20445365c43aea89d45083472572bd9220f7a71f Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 13:36:37 2013 -0700
Bug 46760: Beta Regression: Fix styling problem for search in beta click search to focus it previously the left menu was still visible. This corrects that Bug 46760 Change-Id: I7444373162d5a3b951b76c20033450fffcef930f
commit 8ea4c5bdcca5519fab6aff42597ac4e89aad0b4e Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 1 13:01:44 2013 -0700
Use embed the correct way, fix Nokia N95s This is producing invalid css which is breaking the mobile experience for a variety of older phones who cannot handle css parse errors. Change-Id: Ie0dadd0773ea1c585083de6eeff04d009442a176
commit 581f8cec7f568fc1dcd4c851eb228218350bf975 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Mar 29 12:28:47 2013 +0100
It is useful to sometimes debug problems in Firefox I need to debug in Firefox right now. Change-Id: Iad85d611fd32232c309145e6ca506cc393005ba4
commit f5bac302bd4ff11f1b4a665209549f9631725c45 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Thu Mar 28 20:26:37 2013 +0100
Added option to run mobile frontend tests at en.m.wikipedia.beta.wmflabs.org Created three new Jenkins jobs: - en.m.wikipedia.beta.wmflabs.org-MobileFrontend-linux-android - en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-ipad - en.m.wikipedia.beta.wmflabs.org-MobileFrontend-mac-iphone Change-Id: Ibb74ccb36025dc50c562a7359a314db600ad3312