Extension:MobileFrontend/Deployments/2013-01-08
High Level
[edit]Stories
[edit]293
Bugs
[edit]40904 42805 42745 36109 43305 41518
Uncategorized
[edit]Git Log
[edit]commit 59d4506f2b27ccda732ccf2eb098fc07d7c4d4ec Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Dec 21 16:03:40 2012 -0800
Overhaul watchlist UI [beta] * Make watchlist main tabs adhere to design (fix colors, add border, make corners of 1st and last button rounded, change text to "All" and "Modified") * Make watchlist items look similar to the provided design (fix padding and margins, make all the item, not only text, clickable) * Make second level watchlist tabs adhere to design (and make the whole tab clickable) * Remove date rows from watchlist (design uses "x days ago" instead) * Make the recent changes view look like in design assets (adjust margins, padding, colors, add user icon) * Fix thumbnails styles * Small fixes in diff view (colors, make the end of the diff visible when scrolled to bottom) Change-Id: I78ef0a9c75dd74ab8badbaea140a3cdd9137175c
commit 917fb5ac82b76c5df19b85c2d8f455682aced7e2 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Jan 4 03:14:44 2013 +0400
Fix https detection, disable secure login by default Otherwise, lots of wikis, including dev ones, will break Change-Id: I86ef72107b440651f8fc98a8327f9310c1982855
commit 67e8d86abc7c7edae8e2140519199de02c02f17b Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Jan 7 20:58:16 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I798066623d42175b0bbd96f83a902f83e88cb008
commit de7d5d8006869fe91455d614a865ad10dc6b190c Author: jrobson <jrobson@wikimedia.org> Date: Fri Jan 4 15:09:38 2013 +0100
move account create into center just like login form currently too squashed at edges Change-Id: I571f07256db60e56c226a3ef8e5dc2f452bac8fb
commit 9e46d47a98787ccd1a2de7e5823fb49084b9d5f6 Author: jrobson <jrobson@wikimedia.org> Date: Fri Jan 4 15:19:45 2013 +0100
ensure diff/watchlist is styled regardless of whether js available previously with javascript disabled the page would appear completely unstyled. This is significant when we consider browsers without jQuery Change-Id: I0199b2a8780adac3323b018ca6ed6465ad46aa8a
commit 05759f876e7aa9d5464acd3b5fc33ed686da3f9c Author: jrobson <jrobson@wikimedia.org> Date: Fri Jan 4 11:55:00 2013 +0100
move jQuery history specific code to mf-history-jquery untangle messy code isolate to beta to allow more experimentation without fear of breaking production Change-Id: I39e1ad46d6033e6e3ba95b73341a8d80b828b343
commit e995c2d9c7d3236c63d7e841c79ff4f0634dfec1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Jan 6 20:12:26 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I2d40c11f16f49cda08f03fede22e986463c87f0a
commit d59c5e9f6d06af59067773143aca3b967be9fba1 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sun Jan 6 04:03:41 2013 +0400
Clean up items to remove Lots of this stuff became unneeded after we stopped screen-scraping. Improves performance a tiny bit. We should remove more selectors, this commit removes only a 100% safe set. Change-Id: If8e3cc9262a87a7085b3883dfb20fa4ff6b6001c
commit e8f2e6d0140f913ebbbd9bd57a4c9aecf2026221 Author: Michelle Grover <jcmish1@gmail.com> Date: Fri Jan 4 00:45:44 2013 -0700
add/remove articles to/from watchlist Change-Id: I8f26582e0b30c0bc8649077e6d4cc42e093ff74e
commit 408ebfde8a8f1a79808abc074de4c3c62604f9c3 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Jan 4 21:28:29 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I3977c33a189ce52741536fb16a3eead21a5e74fe
commit 14083228b20a172f77dea5832fc68d92f3a9276a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jan 4 21:42:52 2013 +0100
Renamed readme file Github should now automagically create nice landing page. For example page see https://github.com/zeljkofilipin/mediawiki-extensions-MobileFrontend/blo b/master/README.mediawiki Change-Id: I5cb1b013b28242b60d4cbb08d981bb7565983aa9
commit 9be29222bf4e36241a2a63023567137344faa445 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jan 4 15:48:30 2013 +0100
Cleanup: remove unused code Since tests are not running on Internet Explorer, there is no need for marking test as pending. Change-Id: I22429917bead28f7a8c135a1b783d986a0712002
commit 56fbf0f2a07b2687916fa0be7392abd37f7e4ac4 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jan 4 16:04:03 2013 +0100
Remove all unnecessary "mobile" From file names, class names, feature names and scenario names. Change-Id: Ie1489f6b567e271cd5ede4d4a02af6c4c2d0cae0
commit e38b86388f6d0d0f134fdc8ed3edc8d286731073 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Jan 4 10:28:21 2013 +0100
Updated Ruby gems json, page-object and parellel_tests Change-Id: Ib402223db49b0d823e7b79ed5e37015eb7765b84
commit 9f46fb27cda518490cfaa91f5fd8362aa6c539f5 Author: Raimond Spekking <raimond.spekking@gmail.com> Date: Thu Jan 3 23:30:44 2013 +0000
Revert "Localisation updates from http://translatewiki.net." Changes in qqq were overwritten This reverts commit 59aceb56071f41e9310b075dd0ba9e382be12c33
commit 59aceb56071f41e9310b075dd0ba9e382be12c33 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Jan 3 23:12:20 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7abb3191f28a3f5f4d12e2af5259fb5c3afc17db
commit 1d6257404264d1d89637bdbd4a52152c977e635b Author: jrobson <jrobson@wikimedia.org> Date: Thu Jan 3 22:50:23 2013 +0000
remove enhanced search from no jquery beta (RL integration) this removes enhanced search from the beta for phones which cannot handle jQuery to see if anyone complains. This means in beta there are only 2 modes - no jQuery or no javascript. In future phones which cannot run jQuery will not run any javascript at all meaning we can simplify our codebase by having 2 modes - jQuery with ResourceLoader and no javascript. We can also simplify the search javascript code. Now if we just finish implementing dynamic sections... Change-Id: Iad8de26c0bee11613201acb42391a9806f692c2b
commit 51a1c6ce57c0deb471ad0aec6b895f3861d5120f Author: awjrichards <arichards@wikimedia.org> Date: Thu Jan 3 13:21:24 2013 -0800
Fixes broken invocation of hook recentChange_save Change-Id: If32c8150b685301bc7b3276c1a37401ed771a95b
commit 21faa72729a70961aea0a2dc27025adcc589d803 Author: awjrichards <arichards@wikimedia.org> Date: Fri Dec 28 15:46:21 2012 -0800
Always ensure Special:Userlogin is handled by https, if enabled This takes advantage of the SpecialPageBeforeExecute hook to redirect a user to the https version of Special:Userlogin if they are initially requesting the page from http but have wgMFForceSecureLogin set to true. Change-Id: I23a1db6b9e79c17820556be428118121cb4640b4
commit 0af27495da2f869134b92ee5bc503e6ef84b38e0 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Dec 13 18:01:47 2012 -0800
Add Last modified Add first version of last modified which shows last revision date and time. JS module takes care of changing the date and time into "X seconds/minutes/hours/days/months/years ago" Change-Id: I37fe8d5598fb5f38f01aff9cc6fa531fc8d88e10
commit 858144369c4334e6645e9b064087e9019d677b2b Author: jrobson <jrobson@wikimedia.org> Date: Wed Jan 2 22:52:02 2013 +0000
never try to run js on a bad phone it's just not worth it Change-Id: Iaec3c9869ec97e3e3dd5d9c9f9d92d9b5b2bdddd
commit 0fb2c72dc7d89974a3e0bc8e87c37830e4bce8f3 Author: Ryan Lane <rlane@wikimedia.org> Date: Mon Dec 24 00:43:35 2012 -0600
Add support for Apache Mobile Filter Apache Mobile Filter is an apache module that provides mobile detection. Adding support for this adds an easy avenue for MediaWiki users to enable MobileFrontend without the need for setting X-Device through a caching layer. Change-Id: Ic01a1ccb1389068a4c0e6da4bcee4519ac1dd85f
commit 2400b7394fb190ae0a710f22b2b62c11cdcb4ff4 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Dec 21 17:10:06 2012 +0100
The first two Selenium tests: mobile Search Change-Id: Ie76d0131be0eb67bddf68aca3ed6d40d2a33b076 Feature: Mobile Search Scenario: User can search from mobile website home page Scenario: Search mobile website for partial string
commit f227f38232b93fb3b8d62aab42e35d98f89d3269 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jan 2 23:20:55 2013 +0000
don't enforce a margin top on special pages move margin definitions to .content element Change-Id: I555c4b0a4a80c0b42607693269d8c76f0f36d9e0
commit c3362099d4c17d350bce432527f731af2ee8ff18 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jan 2 16:14:30 2013 +0000
show watchlist star when not logged in [beta] when the user is not logged in show the star to inform them of the functionality - but make sure when clicked it shows a link to login when watchlist star is clicked anonymously: set in local storage a flag on successful login check the query string and this localStorage flag if present and article not watched watch it changes: * changes settings.js into a common library rather than a module ** updates respective tests Change-Id: I5ec6663385a9d8c7707189a86f30a0325d7f6583
commit 18effe0c9a197f0661f037d7fed6b7d9317e6377 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Fri Dec 21 16:58:00 2012 +0100
Setup for Selenium tests RVM (.rvmrc) makes sure the correct version of Ruby is used and that all Ruby gems are installed into a sandbox (or gemset). Bundler (Gemfile and Gemfile.lock) makes sure all required Ruby gems (and versions of gems) are installed. Rake (Rakefile) makes it explicit how to run the tests. Cucumber (cucumber.yml, env.rb, sauce.rb) is the test runner. config.yml holds almost all configuration (usernames, supported browsers...) Change-Id: Iea9213fa732fecd7dfde85e00d513dd332a4061a
commit f063b71f011d49ea110e877b90508fdc937ac9fa Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Jan 2 20:52:16 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I812d34d5dc1bd986c944f1ae4112024c1696e3da
commit 45b41ef022c08bc6a3b49538e34f2f45719dc2a8 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jan 2 20:06:44 2013 +0000
RL fix: fix dependency [beta] jQuery modules require jQuery common dependencies to be loaded first Change-Id: I4b86ff31a712085ab032c848b8172a9ca400c300
commit 8801f9de3616310f47199cfe82ce33582e2254bb Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 31 16:28:15 2012 +0000
improve styling of diff page first steps towards: https://mingle.corp.wikimedia.org/attachments/eb06b1db64417c279a7b481bb0edb7e5/215/Watchlist_UXSpec_Beta_Dec12th-06.png Note: Ignored following: * tricky to separate edit count from message without html and not sure how well this will localise * information about user not currently available * position fixed styling will need to be reviewed * no asset for + or - currently so ignored next to bytes added/removed Change-Id: Ica229d80ce6d320fa39384e3066be1339a9743c5
commit 217c31cb52f50d7799551a153f66b061a86fdb24 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 11:39:30 2012 -0800
change mf-settings.js into library rather than module allow easy access to useful functions create 2 modules for mobile options page specific javascript and javascript for stopping mobile redirects when clicking desktop link Change-Id: I97e1cc4b23db9d1d6df67fb8fcddefa49d3e0b08
commit a9199076580517927aea120f85e1d5932e213442 Author: jrobson <jrobson@wikimedia.org> Date: Wed Jan 2 19:05:33 2013 +0000
language search - correct inputs in overlay headers [beta] currently language in beta opens up an overlay with an input in the header for which the margin is completely wrong causing the input to overlap with the back (escape) arrow Change-Id: I7a4822d209884d42e4d2b589af229ebe91338162
commit 91035888ee800f292c923f49585d1aa6e886ffd6 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 27 13:17:41 2012 +0000
update pre-commit hook to crush pngs Keep Max happy by ensuring any pngs added to repository are pngcrushed Change-Id: I828d7954755f7bcf12f41d098f2714644f3362e5
commit 295a9aac122b33d13c3e53eb2567d17a2037efe0 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 15:03:37 2012 +0000
don't show edit link on protected pages (bug 41518) checks users permissions and sends in the configuration variable enableEditing takes into account the value here Change-Id: Ibfb7da75b09312e54cb131d6858ab1f010996134
commit 33f94d390cc53b85f0e7d84b8521a020767a392a Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 19:58:07 2012 -0800
show temporary image as thumbnail size Change-Id: I54c98ea9a5b31c8edd043cb01e7e8dde4ef132c7
commit ac321b60becdc7c98788c429cf2a80d8482779ea Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 19:52:40 2012 -0800
show thumbnail instead of full size image let's not transfer huge pictures over the wire.. Change-Id: I84dd1e383087e91fb62f0045d3a2ef0cdb0ad809
commit 71902031f2591213656181dd0805b675f8278262 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 24 16:46:51 2012 +0000
Improve ResourceLoader support for js/css [beta] story 293: separate script/style handling from prepareTemplate refactor in process only load special pages css/js and action specific css/js on the pages they are needed use RL when possible Change-Id: Idaa82d2efa675c463068375836e3579fa6644d68
commit 7a6ba48714166ae51a0bd091d433a25ba71f8ddf Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 28 21:45:03 2012 +0000
rewrite processDiff using xpath this is to ensure it works with wikidiff2 as well as wikidiff1 some minor styling changes also arrange the del and ins items by occurance in the diff. order is important Change-Id: Id644ea9734bdbda6627af23312a78e60e7a728be
commit ef56be9295d48b7dd2f2202dbd3cbc46f8be0845 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Jan 1 20:24:09 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I07ebf8a2b05b75a5c9b84b1ee3be757c7904890f
commit 25eeb35f3e853f4ec0f34a39d95a1b44774ff760 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Dec 31 16:50:29 2012 -0800
Fix path in mf-mixins.less I'm not sure why it even worked before, It confuses the .less file watcher (autocompiler) I'm working on. This change doesn't have any effect on our current `make less` command. Change-Id: I4af3c8cdc866ec3dc40327f1e9043d6e3dec0931
commit 89b09b2bb749bfa0c5cca917510ee9a6f6983c0e Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 31 20:50:40 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ib8d80a0a39ad6b702f04420680f17da7f3052c2c
commit 38668600ae376cedd0e3c97d7684f6574e8719f7 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Dec 25 02:32:01 2012 +0400
Bug 43305 - proper mobile edit tagging Change-Id: Ib2aaa2ad5adf8e6f747e9d61d91f3b45193d5ea7
commit e69a90e2224227b3d27a4e2edaf2717ad90d3057 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Dec 25 17:06:30 2012 +0400
Comment fixes, rm unused variable Change-Id: I2fd873be7757cb4390e0e32e844d5683c43d22d2
commit 92e3a8b40fc3715157ff45535b27e151fbadb6a3 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 12:38:06 2012 +0000
i18n get rid of html messages in MobileFrontend (bug 36109) replace these with wikitext which is better understood rename keys to avoid breaking with outdated translations Change-Id: Idcd6a0d72d88956a7dea263db5c3e67abd5db89c
commit 772175d46a1cf74243ef869d4243e0ce4657dd45 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 17:46:34 2012 +0000
show message when watchlist view is empty (bug 42745) in future we may want to show calls to action but in the meantime lets just give the user feedback so it doesn't look broken Change-Id: Ie5787357c52f35c36ba764eb78978bded288686e
commit 07ce214c00428cfcce9c987de1bad0c6d5c8637d Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 30 19:57:24 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7d9605a3d10a39b00f4c4375a764095b20f7173b
commit 9979a383c25fb050801d39ba0f8577374a5050a5 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Dec 29 19:42:37 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iae73cb18b0a5fa7f69174c70830c3b56b1612bd8
commit 5c8207b578f4708860d48182c68cc0d1bde8bfe7 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Dec 28 21:16:58 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I0c775dadc05c57f6923c8287512b92f207f08319
commit da6748437d8522cdb21404ca47b8f4a8375f3d67 Author: awjrichards <arichards@wikimedia.org> Date: Thu Dec 27 16:37:21 2012 -0800
Make login links respect wgMFForceSecureLogin TODO: ensure form actions for login/create account respect it as well Change-Id: Ib0716544d3f77830c1dd2d48928c7786ff25f57c
commit 4d1c23a41d5ea58ba377438f0f39aa439f3d3bb5 Author: awjrichards <arichards@wikimedia.org> Date: Thu Dec 27 16:32:22 2012 -0800
Introduces wgMFForceSecureLogin config var This will be used to determine whether or not we force https for login-related links. Change-Id: I5ff8ec704a1b1f8ba81d4539283169aa82f600b5
commit a7294262b3dcbdbaeaec8ecdef155e02c40dd512 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 27 21:23:18 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ie43fd71b8a08215e8659a6374a8fb4ad8ff68796
commit 783806a608324aeed55995bfdd0359b30aad0f9f Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 27 20:10:04 2012 +0000
add thumbnails to watchlist list view (story 273 beta) adds a thumbnail via javascript to left of article Change-Id: I49396be68b597b9ebed2a8be4a1eb6468f64574d
commit cc00efcd4b19e78cc913a70ee5db282577c77623 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 11:51:03 2012 +0000
remove close this section [beta] left in non-beta since older phones will have no toggling and jump back a section is useful there 405 + 288 + 221 + 171 + 122 + 89 + 64 + 44 + 20 + 19 / 102,230 = 1443 / 102,230 = 0.01411523036291 = only 1.4% of toggles were to close a section using the link at the bottom based on data from: https://www.mediawiki.org/w/index.php ?title=Event_logging/Mobile&oldid=619140#Section_toggles Change-Id: I06aca5c6237ffe340eb952f59d11212e51c04e72
commit 44c5c2d467cf6c22eb581336d9447fe19353d7f6 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 18 10:47:47 2012 -0800
new approach to tables (alpha) make sure the table is visible so a reader can decide whether to view it or not add a bar at the top allowing you to zoom the table add a bar at bottom to allow you to unfold the table - this makes the lead sections smaller when an info box is taking up all the space Change-Id: Ia2fd786571b74b4cdbdd1aa5cc9ed588aac5619d
commit 13676bcf2cad265b9a85529fe28dcd2b63c55bfe Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 13:55:52 2012 +0000
check watch status for multiple articles in one request (bug 42587) replace mw-mf-search-result event with mw-mf-search-results event to prevent multiple requests rename initWatchList to more meaningful initWatchListIcon introduce initWatchListIconList to operate in bulk update checkWatchStatus to take a list of titles rather than a single title update tests inc new test for initWatchListIconList Change-Id: I790e8b5b51123ffbc18700849d48c159cfc389a0
commit 93eacab9a06f27c9a7e7ae2833339c4144735fad Author: Ori Livneh <ori@wikimedia.org> Date: Wed Dec 26 15:29:01 2012 -0800
Upgrade to full EventLogging & declare schema dep. This change removes the obsoleted implementation of EventLogging, and adds a dependency on the new-and-improved EventLogging extension. The schema dependency is declared but not used; I am deferring that to a separate changeset. The dependency is toggleable and turned off by default to keep the MobileFrontend extension easy to install for third parties. Change-Id: I4e1487f29561e84c78e8070a8f3f146c3e52b054
commit a0c403f947c4517d5d81a74082b218012a883c46 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 17:24:45 2012 +0000
respect address bar in random suggestions (bug 43241) make sure the address bar changes when selecting one [alpha] Change-Id: I403012edad7d35be772c6c72f11117a3af96c4c6
commit 79887caa118bcf4fc6270e4fac5852880c07b4e5 Author: awjrichards <arichards@wikimedia.org> Date: Wed Dec 26 14:59:09 2012 -0800
Fix possible php notice when 'query' not present in parsed url Change-Id: I80e8697af6a87195604fd3a39b7d0853d1ba4e53
commit ddf39be2a9c714c1f52c6b44d378ba829e168586 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 26 22:59:12 2012 +0000
remove overlay close button from special pages (bug 42744) This seems to be the easiest fix for the time being and encourages use of the browser back button. Change-Id: Ib5f4cec02b0a4e145f7f0dd3a5bfe1a0796e7c61
commit 470d04417f25c40a3a969801af63c3315e418144 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 26 21:11:19 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: If1b4c27906b00250dbb5983e0846af5691038847
commit 29231f89e39813a045f1fa4b6f39a9fec8dc6bb1 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 26 19:14:10 2012 +0000
fix background color of header (bug 43242) on Windows based phones where gradient doesn't work we get a horrible black color making text unreadable. This fixes situation.. Change-Id: I3d93a3c62bc46b7900b9753ab2998c481f91bf0e
commit 96b34bca4727d52357c529f2a80aa49d665c6d3c Author: Brion Vibber <brion@pobox.com> Date: Wed Dec 26 09:34:04 2012 -0800
* (bug 43425) Fix aspect ratio on images reduced to fit width We were setting a max-width but the height was left at the implicit original height of the image. Adding height: auto resolves this by keeping the aspect ratio neat. Change-Id: I72f027130b464a41e18bfad06b76c8146849b726
commit fb1463cf9f903ca23bd295954a952f636f8cc793 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 25 20:10:04 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ia718ed8ab38162cc755e89ce494795351c1b6cdb
commit d625c155d7dd67d0a18714c9405243299bdf90cd Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 11:03:33 2012 +0000
protect against no jQuery if $ is false an exception will be thrown Change-Id: I2c578c861c17edb6578c07604764e675425ca7d3
commit d713ede97c921521fd0b30165ffbd69019561f7a Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Dec 25 17:09:39 2012 +0400
Untangle MobileFormatter from MobileContext Change-Id: Id73eb76bdc380acc71b7a66ba792fb4e094bff67
commit 14cd81a5117c38d8f0100e872cd47851e39c53c6 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Dec 25 16:58:21 2012 +0400
Kill $wgMFConfigProperties, does nothing these days Change-Id: I563a5c6156bc191c37fa7f1afcd1b20df550fa67
commit 88cb16c435df1cd8360e3de052b54d45469b26f5 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 24 17:43:54 2012 +0000
use responsive images in dynamically loaded sections (bug 41288) not tested due to lack of retina display... Change-Id: I91833e4f22b8718d180f980a9b64c74c0adec05c
commit 2eacf5d8010b6f12bac8a2130c291ebaf17d2c5e Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 24 14:45:07 2012 +0000
exclude phantomjs-qunit-runner from jshint putting in a folder called externals and updating .jshintignore external libraries cannot be guaranteed to pass jshint tests using external folder gives us a generic way to do this Change-Id: I9a46ff12b2f611689362ea3a5f1a0a37bd3279ec
commit ac2b7fd58e2d8f0fd5117214902637f6e850b4bc Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 15:27:41 2012 -0800
limit photo uploads to talk and article namespaces pass namespace in js config Change-Id: If6e5fac6e8b59e074c44dd80fd2b6980236eed10
commit 69e1428af5fca34feab84fa9b6072568fa6451f8 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 11:31:26 2012 -0800
define when photos should appear on articles follow guidelines of https://mingle.corp.wikimedia.org/projects/mobile/cards/282 Change-Id: I0abfb92fafe01f480f90363ecade08a4d084fd10
commit 9bf966deaae55e6235b55624488c41021eaa9c0f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 23 21:54:42 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I09da251da151cbbc802391d12bc66db4952e1cf9
commit 40a8ca3bbfbb145a195ec92a8c63e066c538d40e Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Dec 22 22:13:57 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iddc1ebf2c243db47318a60bfd53a825abf1376b7
commit f0e7c0826447aa542ad7eb264643cb794c0db871 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Dec 21 20:15:37 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iac2d6e11ac82a096071fca290ff04bf2e5f88ccd
commit e8f192d5412a1c49be6a34fb17b5ce80adbd4605 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 11:42:47 2012 +0000
drop summary section toggling [beta] based on real data this feature doesn't seem to get used frequently enough 2,744 / 102,230 = 2.7% of all toggles compared to 28,264 / 102,230 = 28% for section_1 (the following section) and 3,829 / 102,230 = 3.7% for section_7 (which doesn't even feature on all articles) based on data in: https://www.mediawiki.org/w/index.php? title=Event_logging/Mobile&oldid=619140#Section_toggles Change-Id: I109f70dd82d4cec29fbdb0f33abd586ccb6b3332
commit 9898e242f8da16a102a0829c54161e34449f3fe2 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 17:49:30 2012 +0000
fix rendering of login form on firefox (bug 43247) support vendor prefixed box-sizing Change-Id: I54d811e8e9da3994256f21ba2594c078aedb6e52
commit 7a160c71248a4747915fd1a7b229eac70e4ec776 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 17:21:22 2012 +0000
only enable random module when history api supported currently it results in weird redirections on android 4.x for example this stops this behaviour Change-Id: Iec1edc8763ab29acab5eeca4f01a022a4db55c9c
commit b0fa442153fa67cad2655fd564b924b3f77dcf47 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 12:55:44 2012 +0000
move search specific styling into mf-search.css going forward we only want to load this styling on the search results page add FIXME to explain this Change-Id: I0a8e460cf43699059cc90bdc54e2be32f1fbf2a3
commit 00b5ae879681f500e7f291406c02c99d00fcc630 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 13:03:15 2012 +0000
remove edit toggle module dependency (bug 43246) this addresses the problem with multiple arrows (previously footerInitialised flag ignored) Change-Id: I32d121b369047a83d1a60d58a2ce52a350be069c
commit ae44a761cf87e59e6492680db6c2ba89677d9893 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 10:55:23 2012 +0000
don't bind the jQuery shim to $ some existing tests seem to use $ directly rather than alias jQuery. Since we alias jQuery everywhere (or at least should be) taking away this alias for the shim Change-Id: Icd1896e089e2f1b052e48a6166535d42b7cd7773
commit b7d89344df71a4af1420402fbb34561da63c2c90 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 20 21:32:21 2012 +0000
style watching action as a toast notification Change-Id: Ifac2e5925fea37712952196c4673d20ce60e2943
commit 251ba67763a914010828c3cecffabc19dde5e917 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 11:24:43 2012 -0800
refactor when to show photo uploader break out an articleNeedsPhoto function and expose it so we can write tests for it Change-Id: I80e79a2a6808c3177eaf8fcece0c4cf7502b8765
commit e64a63f541205cf3b127655598635470d5e92724 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 20 01:57:24 2012 -0800
add caption as description to newly uploaded photo [alpha] Change-Id: I383e2d0777b7b7384f87492af41129c7a2b21741
commit 976e466fc428f071929fdff05f516ffaee0d8dd0 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 19:51:50 2012 -0800
add generic function to control display of spinner in image module Change-Id: Ib65a68a677644c30fe4794afa76e208b81f1fbcf
commit 6789bd70bfda8118820571c819472a5190d6b935 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 19:19:51 2012 -0800
update link on an upload Change-Id: I6b778b300e16bb01843c36679f18f82c3527b358
commit 0152fedede2cec1732018ba8693b39d824cfc2f8 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 19:18:55 2012 -0800
refactor image module - add displayPhoto function Change-Id: Id82e847a513514d9bf5bc23a8b72ec0c07edb784
commit 0a5dd6094b97539e59e41d93562621319b4a1764 Author: raymond <raimond.spekking@gmail.com> Date: Wed Dec 19 19:21:27 2012 +0100
Sync special page alias file In https://gerrit.wikimedia.org/r/#/c/39155/8/MobileFrontend.php,unified * 'DonateImage' was added * 'MobileDiff' and 'MobileMenu' were added somewhere in the past * 'MobileFrontend' was removed somewhere in the past Change-Id: Idc9711054fd18b7321ff62de1c71c90fcd7480c9
commit 4e7d1a44a32cbbdcbae45d7f8bc75fed95b58a1d Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Dec 19 14:11:04 2012 +0400
Now that 1.20 is out, we don't need to spend 4ms on this Change-Id: I9dc9bf7089955aac4bed07be5636d83814c77cf5
commit e435cef7b99382f13dbc81c10045a4083ca805ec Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 18 17:42:21 2012 -0800
recenter the navigation overlay heading (again) why does this keep breaking!?! see 43876d1f5b2406c31b11f4047ad3c118c6dfbbd0 probably broken by I25253c90b368b3628f67836e45877795e290996d Change-Id: Id9dd3d5413dc7e709c71b472eefceafb7ad593eb
commit ae071d7546d62698a1c0412910b2050bb2f2b78c Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 16:45:15 2012 -0800
hardware back button behaviour this addresses bugs: 40904 and 42805 has is set/reset when navigation menu opened/closed change to mf-history.js allows search to be closed via back button by defining hash as having changed on original page load Change-Id: I4879f538927747b37163a980fac39a7fecaddf3c