Extension:MobileFrontend/Deployments/2012-12-18
High Level
[edit]Stories
[edit]#140 - Account creation Related Task #292 - link from login page to account creation #289 - "Here be dragons" alpha #250 - Visual Design for mobile login #265 - Automatic redirection from login success page #267 - Promote cleanup template work from Beta to production #286 - Editing an article sometimes redirects to the Desktop Site
Bugs
[edit]https://bugzilla.wikimedia.org/show_bug.cgi?id=41605 History pushState misbehaving on 4.0.4 https://bugzilla.wikimedia.org/show_bug.cgi?id=41407 history replaceState crashes when first argument is a JSON object on Nokia S60 https://bugzilla.wikimedia.org/show_bug.cgi?id=41875 Expand "Chinese" language choice (also provide Taiwanese and Hongkong Chinese) https://bugzilla.wikimedia.org/show_bug.cgi?id=42710 New table styling interferes with clean up templates cleanup https://bugzilla.wikimedia.org/show_bug.cgi?id=42702 Long titles on Special Diff page and another special pages https://bugzilla.wikimedia.org/show_bug.cgi?id=43138 Style screen flash on watchlist https://bugzilla.wikimedia.org/show_bug.cgi?id=42805 Clicking hardware back button when 'hamburger menu' open https://bugzilla.wikimedia.org/show_bug.cgi?id=42804 RTL hamburger menu badly styled
Uncatagorized
[edit]Localization Changes Logged whether a user is signed into beta to track % of users who are logging in [beta] Allow for two watchlist modes reading mode and recent changes mode [beta] Sort watchlist in alphabetical order [beta] Allow for switching between watchlist reading view and changes view [beta] Only load modules once [alpha/beta]
Git log
[edit]commit 5719be5b6e6887e41f6efe0a9fbe3f224bc07a23 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 14:20:51 2012 -0800
only load modules once [beta/alpha] for some reason mf-photo.js/css, mf-random.css and mf-tables.css seem to be in both alpha and beta this means in alpha it loads twice i smell a bad rebase that this corrects Change-Id: Iaa0c5be9d2ded7dcac32c3776313d681dcc31937
commit 2df59d68b9b706c1fb2b6b9d842d91624b7c5e86 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 16:09:35 2012 -0800
i18n change for hamburger menu (bug 42804) this ensures that the icons appear on the right of the menu in rtl mode rather than the left of the menu Change-Id: I102fc7795784ecdb83eada8d674d9155d99038f8
commit ac2eeba806c15a3ae7d232673f219235dc85b386 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 17 21:27:29 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I28af570c112a6e101c29373decba1154bbc5650d
commit d7094470afcdc319c68b04410ca3f0cc3e213057 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 14:36:48 2012 -0800
allow switching between watchlist reading view and changes view [beta] introduces the ability for an anchor tag to style itself as a button and button styling for buttons inside the header at the top of the page slight adjustment to left nav to remove button class from random link which is currently not being used for any purpose. Change-Id: I6a74c1e7ae1ae3e72b2e5ffffc2e473236ae80a6
commit 876cd3788853299bb230d7d93e9d36395e640076 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 16 20:51:14 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I0dee9559e0b54eccd3068461778f598200aeda7f
commit 6dfb92ba8d20d2f8e78dcd8941281b41c82a6fe3 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Dec 15 23:55:48 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ib93b79065e142e616b66fa2f3f136130ac294741
commit 7cbb9a043d22c36fad8f175ad0b1286da8287abb Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 14 16:29:30 2012 -0800
when focus initialise textarea height to show all the content this creates a pre element with the same content takes the height and then sets the textarea to that height when the user focuses the element on clicking enter or backspace it readjusts itself Change-Id: I7ada08794210cdbbd5a7d5864c995e260e0f112e
commit 3910129b0cb5879a977d7835626cebfe096527f8 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 11:53:45 2012 -0800
list watchlist in alphabetical order [beta] this is default view on watchlist Change-Id: I4e06dd38982901f048c8863c6adf49a360dd2dc2
commit e127c07c2e0bb5b9a3c6b2336ea4d80c32ae8b99 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 14 15:53:05 2012 -0800
watchlist styles / load RL at top of page (bug 43138) this moves the script tag for RL to the head of the document this means stylesheets can be loaded dynamically before the page content has loaded Change-Id: Ib5b0008a1cc38fb4ec396459f5a32158ad611bfd
commit b3efeb6676ed609f51a8e4d4de19522ee49df2f8 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 11:32:52 2012 -0800
allow two modes for watchlist [beta] this refactors watchlist code so that we can have two views on the watchlist - reading mode and recent changes mode currently only recent changes mode implemented accessed by watchlistview=feed query string parameter Change-Id: Iaea2b97ef7e56c9a131cdb296c4e3d2ca22658c4
commit 24112dafa7f6246739ee24d9bf175ee166543df8 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 7 13:15:30 2012 -0800
enable the history page in mobile add some basic styling rules Change-Id: Id932051c659a9feb3be5ff816ec057eb8b8a85fa
commit 9c6195fab5572cce77e1144e3a4b10e790bed501 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Dec 14 20:36:21 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I29ddc14b73a5b5bc14b927b67fd304e5a9f940e4
commit 7c0401483d8a1a3e9d3bd36d00bd7f6bd5639c56 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 16:57:26 2012 -0800
switch to less aggressive min-height (bug 42702) it seems that on Nokia E52 the Issues heading spills out due to a browser glitch this makes the header larger on that phone so the header is still readable this also provides an interim solution for bug 42702 Change-Id: I2bf1ce4c499272e530e4475564097adc26932173
commit 178519004b27380c7ae6856b0b49a6b6cfcf92ed Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 14:53:46 2012 -0800
promote cleanup template module [267] cleanup templates styling will appear regardless of javascript known bugs: Styling issues on WP7 Change-Id: Idd67e7ff82b3eada3cb4812ea8b54adeb462e66d
commit fb2f8202796f21f1a84de149269791bcfa206539 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 14:52:43 2012 -0800
switch to border box mixin [267] Change-Id: I64c539730adf188bcd7e2e0187a5b92fcd022895
commit 98dece3de9691b29232c65fb77973217092c7f7f Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 14:47:49 2012 -0800
move cleanup templates css into cleanup template module css [267] drop .mobile rule as no longer needed Change-Id: Ifcd0a622968c26e63eb4fb19e51490814b7f51b2
commit 43876d1f5b2406c31b11f4047ad3c118c6dfbbd0 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 14:35:21 2012 -0800
ensure heading centered [267] open the cleanup templates the title "Issues" should be centered above cleanup templates Change-Id: I7e587afdf4d37c59e907d525eb31a2c9cd91e628
commit 135ca3ce76418c1de09a1e04e4afe050608a32e1 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 11:21:35 2012 -0800
only style tables in overlays created by table module (bug 42710) limit styling to contentTables class Change-Id: Ie2ff18e63941e5f3c2e1640ef40a8162c3dc024e
commit 8f216ca591f12de004d86fabadcb4830cf611a87 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 14 10:35:23 2012 -0800
show sign up heading for signup page previously it was showing sign in Change-Id: I7bd6014598c4a27fde5c130be8dc974a9376c8f1
commit d88fa92dba8dcbd3317835b827d315534f70d18c Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 17:22:01 2012 -0800
style account creation form this attempts to follow the design in https://mingle.corp.wikimedia.org/attachments/3408386b028630169e1105579e7b53da/186/Wikipedia_Signup_-_iOS.png as close as possible it is impossible to style the captcha with a gray background without a change to the captcha plugin so that the captcha image is transparent Change-Id: I76be140e04fe55a8548e84add9bcb78506d112f7
commit 1efdb4c6e720bee31d68d2e520069c515d232a49 Author: awjrichards <arichards@wikimedia.org> Date: Fri Dec 14 01:06:46 2012 -0700
Fix class description for mobile account creation form Change-Id: I278ab754e0cfdcfc4f3b1b55d518205decfae291
commit 3ab47577ea2b2a9f4238eeae0f1aa99c239faf9c Author: awjrichards <arichards@wikimedia.org> Date: Thu Dec 13 13:48:56 2012 -0700
Add overridden and unstyled account creation form [beta] Mingle card #140 Change-Id: Idc60196e44c831a685274d6fdc6dbd4c9a645185
commit fb63fad013172241be8ae6e9739b8737cf7c8b73 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 16:26:13 2012 -0800
redirect to homepage on logins via main menu [265] as described in story always redirect to homepage update mf-history so it only updates returnto value if it previously existed so that we don't force a redirect to the previous page Change-Id: Icd36a8b203e4f223b727d5352b17b69148e99572
commit 040941d6582fb295a06514df1acec7967f684aa2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 18:10:08 2012 -0800
when user logged in show welcome text at top of homepage [265] update homepage to show welcome message to logged in users Change-Id: I3e86412869e756850af3bbe413a6a0d9351fcab8
commit e54e6de82a2677b3c8ea1d78e16c2dd3a296866f Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 17:44:02 2012 -0800
trigger a toast notification when query contains welcome=yes [story 265] repurpose mobile-frontend-logged-in which is no longer used for a new message key changes: addes specified class to #mw-notification changes link hijack so that welcome query string parameter is not passed to subsequent page urls Change-Id: I4e7602bafb113512ebdcca30eb24f94b95612c5b
commit 80488313ef741a740d39320c5b61c47a9be9a1a2 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 13 20:29:01 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7db8775b9ae252659c8898e0623e263a53170d5e
commit dca9c6437ed783c32e74260589409d1f246f4bdc Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Dec 4 14:32:52 2012 -0800
(bug 41875) Language variants Language variant selection for mobile. For now it's in the same place as language selection. The final decision as to UI yet to be made. Some cruft removed from SkinMobile.php language selection too. Change-Id: Ifd540d3b787e588bcec88c8f75132ab9370cc912
commit 4ef69f3e647d7e366fda396d793324f3f6afbde6 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 11:02:03 2012 -0800
add ie specific hack for cleanup templates annoyingly it seems that on Windows Phone 7.5 the cleanup templates are rendering badly to the point of being unreadable this hack makes them readable and adds an ie.css stylesheet so we can limit this just to Windows based phones Change-Id: Id19aedec31c57351bba03a620c53e142d49cd9d7
commit 593e500c123931c0e64ae79024e6178b8ac44e2c Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 12 21:14:32 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Idfdb55bfc24614bc05a672f8c779d5497d7f41fd
commit a66e9374b56567c85e0185b058594be1773f41ae Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 11:38:14 2012 -0800
make less again ran make less got changes that happened in a previous commit to a less file but were not updated in the css file hopefully now we have protection in the git hook for this this will not happen again Change-Id: Ib62847faec021a1f95c15ed411a8e9ab0ff628b4
commit a2cfb6d0782faa6f1a9e4ac259c427faedbe988b Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 10:56:31 2012 -0800
log if user is authenticated [beta] this will be useful to get a feel for what % of users actually login Change-Id: I0ae104641797d93da852018ebf360f0c35bb456a
commit 184d17b62cafb216aeed9d77e612a66caa3f51ad Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 10:52:25 2012 -0800
move logging code from SkinMobile to main.js reduce javascript in html to avoid caching issues Change-Id: I8ebef115f74f74a1ae805df1255d5e2afb955b83
commit 534fe0502387c375522ae231bb893a2ac70429d9 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 12 10:45:25 2012 -0800
minor code cleanup for toggling Change-Id: Ieb9377ced8f1e4f35b98692a0ee213541bb5e66a
commit a1a78527fc9c1a810a074cd5e2128efcc107dafe Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 17:06:12 2012 -0800
add watermark to top of login page [story 250] https://mingle.corp.wikimedia.org/attachments/6d21f1a7d936c9edd44827fa44fc18e4/182/Wikipedia_Login_-_iOS.png Change-Id: I684db89bb3ac1069072f9cc9989ce6e2f3efcc44
commit a5687d21c3da057587dd10feb2ab99387c8f4051 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 17:29:47 2012 -0800
style error message [story 250] apply new styles throw away rules related to tips which are not be using Change-Id: I1e1dd33cf8fa8f7b7e2d63c830570b7cabb409ec
commit 55ac493f11b63bc9047967e1f1ce2dd5a0900d2d Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 17:11:16 2012 -0800
style login screen [story 250] Change-Id: I0abc2c128a152da7d0a9bc6f1d320f85e18e5b9b
commit 68ce56c35c17e4a0b68f854baa2bda5a80beab70 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 17:09:01 2012 -0800
add placeholder to login elements [story 250] for some reason these are missing Change-Id: I85acc27f650c28086cdfd9ec951260ca30291432
commit 9681731ddeaee2548cfa0999775f86a7622255fe Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 17:08:17 2012 -0800
remove info box from top of login [story 250] see http://i.imgur.com/rtGOo.png Change-Id: I978bec4e1ec61fcfceb927bfd56c064cf5c173e9
commit e5eb38a5353cb625d7e1354ed731535090e62221 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 6 12:26:30 2012 -0800
add an experimental mode to MobileFrontend Here be dragons mode (alpha) is implemented exactly the same as beta on settings page the alpha option only turns on when you have opted into beta when in alpha mode the beta mode disappears from settings page (thus you have to disable alpha then disable beta to get back to stable mode) Includes stats tracking for alph opt ins and opt outs. move photo uploads, tables and random to alpha mode Change-Id: I32a910eda61348d6bb3ecfcbe7595f4b6d263f1d
commit ee751ad1953dd55c421b3e51b94fdab5e9d61868 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 11 18:20:25 2012 -0800
remove duplicate cursor definition Change-Id: Id2682090a501060b8262fb37861c9b7a4e5d48b6
commit b5d9d1dd10734cf04e5a1ef03ba33f522c7e84f2 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 18:33:56 2012 -0800
add a link from login to account creation [task 292, story 140] include robot speak Change-Id: Id401f982f9a47d5d351983291b178d9da0e480b5
commit 9b43fe8ae0a3b30abde714802395b4d7fd490958 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 11 22:53:22 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iebe67cc81bd395b221fc7fc9b84f306194965c8b
commit 588b45075118b2058c3783d355d3871959217ca5 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 11 12:13:12 2012 -0800
disable enhanced tables in summary this makes the table code only initialise when a section is toggled note that this also fixes an issue in the trigger in that it wasn't passing the correct container Change-Id: I58731928e1c544bb8740394fa27d991cfe61fe09
commit ee1fd1c7bdf8b278725edc79b5f5d03d8cc5b96d Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Dec 7 02:24:49 2012 +0400
Remove old JSON API completely Leaves a stub that serves 404's Change-Id: I293ed919bc86b7bd3dcc394a1ca10bf76f207e8d
commit f71e53f7b1eca770d969813bd975b3b6333da816 Author: awjrichards <arichards@wikimedia.org> Date: Wed Dec 5 17:35:45 2012 -0700
Preliminary work for mingle card #140, allowing for account creation * Creates abstract class for hijacking templates (like login, acount creation) * Makes login form inherit from aforementioned abstract class * Creates placeholder sign up form class * Exposes default account creation form Change-Id: If5ece923f5de9040f2f31e27fdead36ed7b315fa
commit c3e87ed91ea5974f5d341c7d7bb070d4a16b903b Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 13:26:58 2012 -0800
run make less if a less file changed if an attempt is made to make a commit containing a less file this pre-commit hook will cook in and run make less this should ensure we don't fail to check in corresponding css files in (note that git review will not run if there are unstashed changes) Change-Id: I93d7c049cd55b34d6fb8015b2a5f73351e147199
commit 7882dfe98102f28e57b6d2e11110636eba2853f3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Dec 7 13:45:35 2012 -0800
Remove dead code from SkinMobile, no need to pass $out $out is already set and we can get it using getOutput(), initPage() is not invoked. Change-Id: I13bad0327aa446d38b9741822cf92b0edafee00c
commit c57d3c46354c38c1b33221add37b4b81a0c249ef Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 6 14:20:40 2012 -0800
disable usage of history api in S60 webkit browsers (bug 41407) Passing an object as the first argument causes the browser to crash this is not good Change-Id: I2467a8c90379dc009993f24664eb71c7fdd3f14f
commit 700b373badb95c755a46375271bb60c47f779f42 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 6 14:19:06 2012 -0800
disable history api usage on Android 4.x phones (bug 41605) resort to browser sniffing. the api is there but doesn't work. blacklisting phone Change-Id: I03c0927c013678be92163f9114671b44dcf7f573
commit ceae2c5a2b9cb54417a804bcae857a00c38f9c50 Author: awjrichards <arichards@wikimedia.org> Date: Mon Dec 3 17:45:07 2012 -0700
Make 'mobile view' link respect canonical URLs when possible Addresses bug 36182 Change-Id: I93af392e3b27017f95e36acd7c0651d3b896741a