Extension:MobileFrontend/Deployments/2012-12-11
High Level
[edit]Bugs
[edit]https://bugzilla.wikimedia.org/show_bug.cgi?id=42492 MobileFrontend strips too much content in images disabled mode
https://bugzilla.wikimedia.org/show_bug.cgi?id=42709 Cross domain tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=42835 Beta doesn't respect license when dynamically loading pages (doesn't update link)
https://bugzilla.wikimedia.org/show_bug.cgi?id=41407 history replaceState crashes when first argument is a JSON object on Nokia S60 https://bugzilla.wikimedia.org/show_bug.cgi?id=42749 Toggling broken on tier 2 phones
https://bugzilla.wikimedia.org/show_bug.cgi?id=42704 other suggestions' sometimes spill out of the content area when using 'Random
Uncatagorized
[edit]* Localization Changes * Jshint configuration changes
Git log
[edit]commit a0b121a15d436c3e11f739862bbf5fa6574c40ad Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 10 13:26:30 2012 -0800
run make less and save results seems something changed or didn't get checked in Change-Id: I77124c7f364ff442ace7f48493afeee7ec8c2b4d
commit a26ddf2888525f477ba68300fcb36277b0d79be5 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Dec 10 12:36:14 2012 -0800
Remove dead code in mf-languages.js and mf-navigation.css [beta] Change-Id: I5ae22c798c672b05f2a6024aba128725cb51a9dd
commit d98d22b7b8e9bbf66b60fd9514d720cdb12da745 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Dec 10 12:46:16 2012 -0800
Fix indentation in mf-history.js Change-Id: Ic0980ecde06f60126c7d17b3d64ca215aedf1dec
commit d0a884139bb529dfff4d1a475b2f2bc6531055a9 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 10 20:31:11 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I574b8fa21e0f323ed894606959f469ee4195f024
commit fe67e0e1562538b502c6af36a52104f6c2d9917d Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 9 20:28:02 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7975d06ceb8014d7977d1ef0aecdf22349ea51d2
commit 076eea1558833a4c7128b2b5d3a55b30fb41d1a2 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sun Dec 9 16:08:05 2012 +0100
Article to page where possible Change-Id: Iaf6c778adbf6235183bac44383094eb65db2529c
commit dd017d60cc01ddc5b88868c4ec0a41e506b1d78f Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sun Dec 9 16:10:11 2012 +0100
Clarify error message Requested by Niklas at https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-photo-upload-error/en. Change-Id: I582c3acbb43150deeac272e5f084d71d5fe36767
commit 40620c2b4afbb7ffe9a553ccc67126a0643c5969 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sun Dec 9 15:54:15 2012 +0100
Fix incorrect CC BY-SA license abbreviation Pointed out by Niklas in https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-photo-license/en. See http://creativecommons.org/licenses/by-sa/3.0/ for correct abbreviation. Change-Id: I258a1408ce2ad7473a8c087b54b8d49867b16483
commit 9ca92e1b51b83be114cd8846ba8d0085d7cd3012 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sun Dec 9 15:47:35 2012 +0100
Remove jargon Per Niklas in https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-changeslist-ip/en Change-Id: I1b02ef4ceedc308357dd159bd19f55174a9f85eb
commit 807c34e602313eed259aae9ac6693b7994a5abf9 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 14:48:47 2012 -0800
enforce onevar onevar to rule them all In the Land of Mordor where the Shadows lie. One Ring to rule them all, One Ring to find them, One Ring to bring them all and in the darkness bind them Change-Id: I9b8fa9e68e819eddefd79e1080ae35950f329b1c
commit 5ad83f6dd33f13fa488b722dabd0b762819af1eb Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 7 15:40:02 2012 -0800
fix the search tests create mocks here now there is no MobileFrontendTests update filter so the tests appear under the filter MobileFrontend (this is why they went unnoticed) Change-Id: I0d6dca431ac57779c7bcad2772dc53d9fad76fb9
commit d9389f797862e9af5abb45c841a0ffcd382e3ed4 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Dec 7 21:55:42 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I0ad554c3ece1e97cf862215f0d981b846c7db1ae
commit a40b4c0ffc73944801b698647887ff2cb605a1e1 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Dec 8 01:44:00 2012 +0400
Bug 42492 - don't be overzealous with image removal Restored images with thumb and frame, image captions and galleries Change-Id: Ieed3e8139002a9c0c37ea3ba8e866a3104c6a5db
commit 2d186f889556e5b5dbcdae3fe9a5a471fe509065 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 7 13:14:04 2012 -0800
quick fix for article history problem (bug 42835) going forward it would be useful to mark up links that need to change on a new page load Change-Id: Ie51bd5ef70d8c509da4517266d22035c2fec0a48
commit c57d3c46354c38c1b33221add37b4b81a0c249ef Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 6 14:20:40 2012 -0800
disable usage of history api in S60 webkit browsers (bug 41407) Passing an object as the first argument causes the browser to crash this is not good Change-Id: I2467a8c90379dc009993f24664eb71c7fdd3f14f
commit 700b373badb95c755a46375271bb60c47f779f42 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 6 14:19:06 2012 -0800
disable history api usage on Android 4.x phones (bug 41605) resort to browser sniffing. the api is there but doesn't work. blacklisting phone Change-Id: I03c0927c013678be92163f9114671b44dcf7f573
commit 4307a3ad38a3f586d442199c9a0b453d611a030b Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Dec 7 02:14:28 2012 +0400
Remove a few antiquated option screens Change-Id: I0d66a17cf868cceb5e36ec846e8e65f14f25a397
commit bfe91b3926817c9861ca349e7942eb1149e02fbe Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 6 20:14:44 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ia52280a1350cccc1787a498a6db2698f9dcb0c93
commit 39bc7ff4a878769e5fe4ac682f4b1f16606e901b Author: awjrichards <arichards@wikimedia.org> Date: Wed Dec 5 17:46:16 2012 -0700
Removes no longer needed doSpecialCases() code Now that the formatter no longer strips form elements, doSpecialCases() is unneeded for special casing the login form. Change-Id: Id9c2db2c4c8d2455426a8166ab7dd347323d265c
commit 33c787e71bde4ef4acbbfe327297c2578fc25ef2 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 15:58:48 2012 -0800
separate jQuery shim tests from application tests rewrite tests within mediawiki style guidelines Change-Id: I364352160f5dd5347a4a670498b7ccd8c5cf575b
commit a51bd1ea392be621fc2e59c300fed6158f50a818 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Dec 5 15:49:30 2012 -0800
Remove unused message in i18n. We only use mobile-frontend-main-menu-logout. Change-Id: I5a3b4004d2ae9c41a11e0c385c21c864fdf388c0
commit 9a9d82a28401fef58bc688ff5b92c0b15d1add84 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 14:34:39 2012 -0800
add other jshint options Change-Id: I616efdd6381e8cad75a7b10ffa01ae685203cf57
commit 8d09b0fdfcd5975d2e970395e18c49ec5cc84ab2 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 14:07:58 2012 -0800
enforce triple equals Change-Id: I7152b8ad10b948037029a09a9d455e3b3eaa137d
commit b5a289074d888d14cedb995bd6f2ebc933a3feec Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 14:03:36 2012 -0800
add consistency to single quotes usage but do not enforce single quotes via jshint yet as the tests currently use double quotes and preserving history is more important Change-Id: I93bfb943a28efa0ed5b72ae20272ba72c5f7d40d
commit 507d599e5a68d4e6a171c38af124a5431fdce754 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 14:55:04 2012 -0800
fix broken section toggling on tier 2 phones (bug 42749) tier 2 phones being the one's we serve javascript but no jQuery to test use DeviceDetection to force nokia as the device name Change-Id: I8936897e54bf59729aa07db1aa663eb4045c4b6e
commit b631d5fda47b7a3c65f54efa9ad7ac16b55f4335 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 5 20:54:40 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Icabbe7f9d06b7f6283af2d39086e1104ad5960f4
commit 87005d1d83e8775535b044f65603b2b48e9c49c3 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 09:45:08 2012 -0800
when $wgMFEnableResourceLoader disabled add watchlist styles these are currently dependent on resource loader support (currently not enabled on the cluster) Change-Id: I27631ada6859d6d2878df7c177eb8793113db3ab
commit d1cd0e15b40f094f0c812dd6b71a9a53491a4859 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 4 18:07:01 2012 -0800
make edit to local wiki using local token (bug 42709) the token for photo uploads is not necessarily the same as the token for article editing Patch set 2: changed tokenQuery to tokenCache which explains what it's for better (jgonera) Change-Id: I68a67431ccca7ae699f9e47e07fcbcd6b8d6cafc
commit cf293fb3ccafa348333e081daf5b89fe3952edd9 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 5 10:34:47 2012 -0800
remove spurious test no slide up animations in references code anymore. Test not testing anything. update teardown to cleanup after itself Change-Id: I39682a718c105e9c7a7d8d5579ab9a2868245ecf
commit 1efda5a6edfb25525be046eb40ff83573e744c22 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 4 15:27:52 2012 -0800
jshint test suite * add a .jshintignore file - tell it to ignore external files and the fixtures * cleanup the tests: ** remove MobileFrontendTests ** put required fixtures in the test modules themselves ** cleanup usage of MobileFrontendTests ** remove bogus test: "MobileFrontend application.js: logo click" ** improve styling as we go along = jshint jenkins +1 ? => profit Change-Id: I7e36d3cd2f0c36496a957e7944ce1263b5854388
commit b6b20fa6478264585f72ca6981147b314e00f515 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 4 16:48:05 2012 -0800
make hlist li inline block (bug 42704) this fixes the overflow in horizontal list shown in the list of random article suggestions in the latest random feature Change-Id: Ieaa23b0c5b34213c6ed2585476ce41d80d4a9c89