User talk:Tgr (WMF)

Tgr (WMF)

Previous discussion was archived at User talk:Tgr (WMF)/Archive 1 on 2015-10-01.

Hi! I was documenting the change in phab:T362566 on the Manual:Content table, but I was surprised to see in Manual:External storage it was supposed to be working since 1.32, according to your edit. However, the linked task implies it will be implemented on 1.43, and looking at my tables on 1.39 I can only see tt: addresses in the content table (I have External Storage enabled and working).

How could this be possible? Maybe it was reverted, or the change lost somehow? Or am I interpreting the code change wrong?

I might have misremembered or misunderstood. The new tables were definitely added in 1.32 with the intention of abstracting away the storage and allowing ES (or whatever), but maybe support for that wasn't fully implemented. @DKinzler (WMF) might be a better person to ask.

The storage schema was designed with this use case in mind, and we planned to implement it in 1.32cor 1.33. But at the time we didn't get resourcing for going forward with the final phase of the migration. There were also some unresolved questions around handling legacy character encodings, which has since been fixed.

Because of that, we kept using the "tt" schema for blob storage. I'm happy to see that Amir picked up the last stage of migration now.

Thanks for the explanation!

... I think the TDF has failed to keep decision processes aligned with core open-source values such as transparency of the decisionmaking process (if that was even a goal), which is maybe OK for decisions which primarily affect the Wikimedia infrastructure, but I don't think its acceptable for decisions with a large impact on the entire MediaWiki user and developer community. ...

Hear hear.

Hey, I just saw Special:Diff/3858844, The code I wrote would very likely explode majestically if we use "notnull" instead of "NotNull". Where did you see the DBAL docs? I can work on it and fix it though, not too complicated.

Sorry, I assumed it's case insensitive because both the page and your patches already had mixed case (`Notnull` and `NotNull`).

The docs I mentioned are https://github.com/doctrine/dbal/blob/2.10.x/docs/en/reference/schema-representation.rst

It can still work fine with both and I don't mind lower case either. It's that setOption in Column.php is like this: https://github.com/doctrine/dbal/blob/2.10.x/lib/Doctrine/DBAL/Schema/Column.php#L75 so I assume "setnotnull" wouldn't work. I dig deeper and let you know.

hmm, it's because php function calls are case insensitive: https://stackoverflow.com/a/5643544/2596051 so it doesn't matter which way. There's pros and cons:

- "NotNull" is closer to the actual declaration

- "notnull" is easier to read, looks better IMO.

I don't know which way to go TBH.

Given the docs, I would say latter. Let's go with the latter.

Hi Tgr. Hope that you're doing okay. I was wondering if do you think https://gerrit.wikimedia.org/r/#/c/372803/ is now ready? Regards.

The patch looks fine, I just want to test it locally before merging. Sorry for not having gotten around to do that; it has been on my todo list for a long time but I always had something more urgent. I'll try to merge it this week (no promises, this is conferences week for the WMF).

On a closer look, The exception handling shouldn't be done that way.

Hopefully @Melos can take care of fixing the issue :) Thanks for your time.

I've uploaded another patch could you take a look now please?

Hi! First of all thanks for the new tutorial Manual:Pywikibot/OAuth/Wikimedia. However, since the bot edits must be performed with the bot account, it is not completely clear if the bot operator should fill the OAuth form while logged on mediawiki.org with his main account or with the bot account. Moreover few details about the RSA key would be useful. (can I use it with Pywikibot? Should I use it? Is it mandatory? How can I use it?) -- Basilicofresco (talk) 03:42, 6 August 2016 (UTC)

You need to fill the form with whichever account you want to give the bot access to. (So probably the bot account, although I'm not sure how much sense it makes with OAuth to have a separate personal and bot account. cf. phab:T142303)

As far as I know Pywikibot does not support the RSA signature method for OAuth, and in any case it's complicated (you have to know how to generate an RSA key, for starters), which is why it is left out of the tutorial.

The "Conflict of interest" section was not approved earlier.

There has been further discussion on it, aiming to solve those issues. Please participate in the sub-sections of Talk:Code of Conduct/Draft#Finalize "Conflict of interest" section? and make sure your concerns are being addressed.

Thanks.

User:Mattflaschen-WMF 03:55, 28 September 2016 (UTC)

Test?

Test!

You participated earlier in discussion about the "Conflict of interest" section of the draft Code of Conduct for technical spaces. There was not consensus to approve an earlier version of this section. I'm contacting you to let you know the draft has been updated, and we are now discussing whether to finalize the new version.

Please participate here.

Thank you,

User:Mattflaschen-WMF via

Hi Tgr, I added a comment to T64266 about the problem with the MultimediaViewer (a suggestion about a simple solution for the problem). Is there anybody left after all this time (2014) to take care of this problem? Regards, Wilrooij ~~~~

Changing the behavior is not technically complicated, there was just no consensus on whether that's a good idea. Anyway MediaViewer is maintained by the Multimedia team and I haven't been a member for a couple years now. The product manager for Multimedia is Ramsey Isler so he is probably the best person to talk to about this.

Hello Tgr, thank you, for your information. I will contact him.

Ik ben bereid om mee te werken maar op dit moment weet ik niet waar te beginnen