Extension:MobileFrontend/Deployments/2013-03-27
Stories
[edit]* https://mingle.corp.wikimedia.org/projects/mobile/cards/439 * Special Handshake
* https://mingle.corp.wikimedia.org/projects/mobile/cards/410 * Analytics work - increased accuracy for pageview stats
* https://mingle.corp.wikimedia.org/projects/mobile/cards/347 * Suggest an article to associate a photo with after upload
Bugs
[edit]* https://bugzilla.wikimedia.org/show_bug.cgi?id=46435 * Uploaded via web template no longer being added to uploads
* https://bugzilla.wikimedia.org/show_bug.cgi?id=44042 * Special pages not written for mobile have no margin
* https://bugzilla.wikimedia.org/show_bug.cgi?id=44484 * [Dynamic Page Loading] Languages broken
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46223 * MobileFrontend Selenium tests fail on Android
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46219 * MobileFrontend jobs should be created from template
Uncategorized
[edit]* Remove event logging for Commons CentralAuth image errors * Protect mobile special pages when viewed in desktop mode * Localization Fixes * Minimal fix for wikibase related SpecialMobileWatch fatal * Kill Native iphone device type * Fix JS error on edit page * Regression Remove Overlay Manager * Regression lotsof JS errors on some pages * Disable editing on beta * Add animation to popups and drawers (alpha) * Load hi-res icons for JS-enabled devices * Ruby gems update * Maintenance Proved valid css * Grammer fix * Rewrite createOverlay to use an Overlay View * Alphasort devices * Kill supportsJavaScript * Prevent search focus when closing menu using hamburger * Fix the page being wider than the screen on watched pages * Fix wrong margin for menu items * Increase left padding in search input * Fix menu borders in Firefox * Fix search input dimensions on non-Webkit-based browsers * Add explanation overlay to photoupload view * Remove warning on place of oldAPI * Ensure mobile.stable.styles load at top * Maintenance Load minimum possible css/reorg css * Remove unnecessary CSS * Correct counter on photos dashboard
Git Log
[edit]commit 879eb1cdcf07cf9a61b9ed9bea7eb363d07ef7fe Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Mar 26 23:17:41 2013 +0100
Remove event logging for Commons CentralAuth image errors Now userlogin.js is loaded at the top of the page to issue a redirect to Commons as quickly as possible, so we can't assume that mf-application.js needed for EL (getSessionId()) is loaded. Change-Id: I60ecaacfc053167eae75b8b37a729ec43a15e265
commit 2018e70a37aa672b4bb81230a05969a34ae0b095 Author: jrobson <jrobson@wikimedia.org> Date: Tue Mar 26 14:49:14 2013 -0700
Protect mobile special pages when viewed in desktop mode When pages are viewed under desktop skin they throw an error. Let's protect them from doing this. Note the FIXME Change-Id: Id003a680f98cee1a376b89e9e5deb098f8947616
commit f869ba2b6990dadaf9939e9ad7c05d59d6f3bdb6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Mar 26 21:16:14 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I5a7523deb8761cf686ded0d13bb816ee2f4594b4
commit e7b105aaecba23c3e309a9ced8df068b685bd01e Author: Reedy <reedy@wikimedia.org> Date: Tue Mar 26 18:45:37 2013 +0000
Minimal fix for Wikibase related SpecialMobileWatchlist fatal Catchable fatal error: Argument 5 passed to Wikibase\ClientHooks::onSpecialWatchlistQuery() must be an array, none given in /usr/local/apache/common-local/php-1.21wmf12/extensions/Wikibase/client/WikibaseClient.hooks.php on line 311 Change-Id: Ic4e337c3a22388f52e0a515b4ee3aa7c15381d04
commit 08d87dfab6ae9beb291e452282ccc68720c68b2d Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 14:55:54 2013 -0700
Bug 46435: Fix badly named global variable Fix template use in descriptions of mobile uploads Bug 46435 Change-Id: I3aa7ce1d4ad313bff185b58b66eb4444590ceb6b
commit 945ec755eda01cca89d40633cd5afba80b5cd510 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 16:06:45 2013 -0700
Regression: Disable editing on beta Whoops this was done accidentally It will return soon! This reverts bad commit with change id I42be459c78ea05fad9d24bfabd37f18743f41050 Change-Id: Ife7d14172339c766d94260f91acc5b38d614b3b4
commit a9d28a360305fe3389546cff6418fe3df9c44ff9 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Mar 23 00:59:06 2013 +0400
Kill native_iphone device type This misleading name covers everything run on iPhone except for Safari and Opera. These various browsers don't need a special treatment just because they're on iPhone. Change-Id: I685c92f2529ed7a539b1108b6034d44876417963
commit 3a254bc5824f9326a748ed9306f42c63dc7bb2b1 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 18:52:04 2013 -0700
Fix fix me (js error on edit page) Now the module is in contextModules Change-Id: Ibc33354f8ff89ac7d0ce141e4535cc6e670f23dc
commit 08d87dfab6ae9beb291e452282ccc68720c68b2d Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 14:55:54 2013 -0700
Bug 46435: Fix badly named global variable Fix template use in descriptions of mobile uploads Bug 46435 Change-Id: I3aa7ce1d4ad313bff185b58b66eb4444590ceb6b
commit bd8fdbd1379626dfe7a3a1e3f565a7abf125249b Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 14:40:56 2013 -0700
Regression: Remove OverlayManager, Fix photo uploads a better way to do this is for Overlay's when created to specify a parent. If a parent is specified closing the overlay will show the parent overlay. If an overlay has no parent when hiding it will switch from overlay mode to article mode. This seems neater. Fix call to non-existant close to trigger hide. Change-Id: Ie8dfe4d833c96b16eee05a84fcf6787782f18504
commit dbaf38ed7cf0a3d817cfab0aa458a7a74dea9989 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Mar 26 01:28:03 2013 +0100
Fix gazillions of JS errors on some pages (regression) Regression from 2f03308 (lesson: don't make small changes to external code without testing them well). Change-Id: I1085848ab9e60d5745bf719fa2535902adf9c89f
commit 945ec755eda01cca89d40633cd5afba80b5cd510 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 16:06:45 2013 -0700
Regression: Disable editing on beta Whoops this was done accidentally It will return soon! This reverts bad commit with change id I42be459c78ea05fad9d24bfabd37f18743f41050 Change-Id: Ife7d14172339c766d94260f91acc5b38d614b3b4
commit d00028502b7ca50384afbbc9863578378127049a Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 13:23:28 2013 -0700
Alpha: Create CTA for watchlist only once It seems in alpha due to the page-loaded event currently firing (see 45299) this gets created twice resulting in two DOM elements Should probably be done globally to avoid this in the meantime Change-Id: I64a2ebff747af7c1ff0d63e9d4b584dabb06a19f
commit 3b58f6e7010752e8e7da9e31c67b08c4a2f0362f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Mar 25 19:59:47 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I588be30b44333df2a3686621a2ab9fed17030be8
commit 2f03308b7447971e2ffc47b667d590e158901e25 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Mar 20 22:28:03 2013 -0700
Add animation to popups and drawers (alpha) This affects notifications, references and CTAs in alpha on supported browsers (for now new Android Browser, Chrome, Safari and Firefox). Might require clearing browser cache. Change-Id: I8a56c62284c718bfcb524fdb13cf05b8a058972b
commit 11ecf35321f34da01b51259d7e343289262525a0 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Mar 25 13:52:23 2013 +0100
Load hi-res icons for JS-enabled devices (regression) Hi-res menu icons were never loaded resulting in blurry icons for all modern phones because ".jsEnabled #mw-mf-menu-main li.icon-home a" is a weaker rule than "#mw-mf-page-left #mw-mf-menu-main li.icon-home a" (rule started with id has preference). Also, move all icon rules to mainmenu.less and avoid nested id rules (id are unique anyway). Regression introduced in 149f609. Change-Id: Ic6fd7585d25a051895e1eea26acb2f4934c97120
commit c47b10805f1320a5e7ca733bcbc9b05e7532a318 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Mar 19 17:40:05 2013 -0700
Add Special:LoginHandshake workaround (#439) This makes the login (and create account) page redirect the user to the login handshake URL on their first login attempt. It's enabled by setting $wgMFLoginHandshakeUrl to a URL of the Special:LoginHandshake page we want to redirect to (in case of Commons it would be http://commons.m.wikimedia.org/wiki/Special:LoginHandshake). Special:LoginHandshake sets a 'loginHandshake' cookie (with no particular content) which reassures mobile Safari (and future versions of Firefox too, probably) that it can accept third party cookies from this domain. As soon as the cookie is set, it redirects the user back to the login form. Change-Id: If45e29ffd0bb9c4c945f942951a8e482017610c8
commit 7470f8547f6cfac318e82b7cf3c9d2f98df5f10a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Sat Mar 23 13:25:10 2013 +0100
Updated Ruby gems Change-Id: Ie16afa17de2fc603bdb1834420132f89467decfd
commit d83f7cb078c60cc8ab4753c95c4d5d879b98a608 Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 21 11:26:09 2013 -0700
Maintenance: Provide valid css * zoom is not a css property - whatever it is it is a hack and should be documented and in the hack file if it is indeed doing anything * word-break: break-word - i think what was meant was word-wrap: break-word * correct a bad argument to background position Change-Id: Icafa1090d3640465c787989a8f7783a0e222b25d
commit f7228495e54fbfc5db7bec4096bd772227367b78 Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date: Sat Mar 23 17:40:49 2013 +0100
Fix grammar (comma before but) Change-Id: I75d67529f5ac4eb9affdda550e6a5c281377e205
commit 32b21c0ef74765ad6c24ee0d49eece88a6601c90 Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 6 15:26:36 2013 -0800
Bug 44042: Add #content div to special pages We should be consistent in our html markup across page types. The less differences between pages the better. The solution could probably be more elegant but addresses bug 44042 for the time being Change-Id: Ia5484c32ddfecf9ccceff73af085d73d02acbed5
commit a594e17b2cf5952a339293e0bb29053b5ff83310 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 15 13:22:39 2013 -0500
Rewrite createOverlay to use an Overlay View that is stackable This refactors overlays so that you can have more than one open at a time. When closed they are removed from the stack until you escape back to the page content. PhotoUploaderPreview now creates an instance of Overlay - this is probably not perfect but it keeps this patchset as simplistic as possible. Change-Id: I0a5ff8fa2c2b7c3c68276bead268b25a0c54a7c8 TODO: Make overlays close with hardware back button press
commit d9afbbc40aaf0f163f3c92fda660cdc4a6288b4d Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 22 14:10:24 2013 -0700
Revert "Rewrite createOverlay to use an Overlay View that is stackable" This reverts commit 45bc2298c2def22cb61365c87cdb45b1ce693ff6. Change-Id: Ie494748a46f36201aa73b5ff2a50a82ab0fbabc4
commit 47b0386636fd5e61bc9da7462e971b722997c518 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Mar 23 00:43:33 2013 +0400
Alphasort devices Change-Id: I4c4c6b8c730efa458d63d95c792525a5d7c6102f
commit d80c47c7e08c11f2449bb8269ae585b480e9a1e7 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Mar 23 00:33:28 2013 +0400
Kill supportsJavaScript() It's irrelevant now, we need to know whether jQuery is supported. Change-Id: If0062e0e8864374ce70da430baf7c6d7e125037a
commit 67360574fb4cf166fe3a0e88b5be6fadb6fe3caa Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Mar 22 20:15:13 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I31086bce6a78865722784c8632ec6486e437e34f
commit 45bc2298c2def22cb61365c87cdb45b1ce693ff6 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 15 13:22:39 2013 -0500
Rewrite createOverlay to use an Overlay View that is stackable This refactors overlays so that you can have more than one open at a time. When closed they are removed from the stack until you escape back to the page content. PhotoUploaderPreview now creates an instance of Overlay - this is probably not perfect but it keeps this patchset as simplistic as possible. TODO: Make overlays close with hardware back button press Change-Id: I26dc25cf47a2a964e7353a05a0fb4400388b79bf
commit 98269db9a43a00ee6865030e5e3338f771b3d943 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Mar 21 23:28:20 2013 +0100
Prevent search focus when closing menu using hamburger Change-Id: Ie091d03bbdb22df68e07181e4cc9ca4ce44cdd18
commit 46ae8d79d363fd68360d6fd9205d291ea9384cda Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Mar 21 22:41:00 2013 +0100
Fix the page being wider than the screen on watched pages In alpha, when the watchstar was rotated using transformation, the whole element was rotated and therefore was sticking out. Change-Id: I8b5fbbb772a567f076988ab6e636684e8fcfb7df
commit 0284c93a4b42139bd44a93551e0d02e1234b6973 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Mar 22 16:15:57 2013 +0100
Fix wrong margin for menu items Broken in 0cfeb1f (Maintenance: Load minimum possible css / reorg css) Change-Id: I40ecee43c8151feee0ed58967bc9be3e79103833
commit a2efa0f9ae1b014aedbf08051422d9e0547aeb69 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Mar 22 15:42:43 2013 +0100
Increase left padding in search input Makes the distance between input's border and text uniform. Also, remove redundant CSS. This was already merged but the changes have been reverted by 0cfeb1f (Maintenance: Load minimum possible css / reorg css). Change-Id: I9bedd7faae16e09fd24236482ddef5baed4d754b
commit 7e47219c6ebd6269b4e273de68ab0e02ffc2455d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Mar 20 22:34:51 2013 -0700
Fix ugly menu borders in Firefox This doesn't change anything in Webkit-based browsers. Change-Id: If5e61fc417ff494256baede35e250ece9a16d8fd
commit 320f06b1b8eea426c6db9be8398c55bdda61758e Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Mar 20 19:46:49 2013 -0700
Fix search input dimensions on non-Webkit browsers In particular Firefox, possibly other. Change-Id: I36857139e718c9f8996b3f3710c7a5026d065a7e
commit 18368c9d0937aa9f5720c048c5ae48de2212959d Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 14 17:24:00 2013 -0500
Add explanation overlay to photo upload view Changes: * Allows any element matching .close selector inside content to close the overlay TODO: Currently only one overlay can exist at a time, next commit will refactor createOverlay to allow stacking.. Change-Id: Icadff153ee8d933c920bd0df50e6003b9af768b0
commit 43116e41e4be1e012a5ad1c48e1272da016a3450 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Mar 22 04:08:40 2013 +0400
Rm warning on place of old API Change-Id: I2013588863a6b68133769a0bff3aea74a97c9fc9
commit 85be5cfb487a9d84aaa64c20630dde24cb9fcae8 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 4 14:52:32 2013 -0800
Bug 44484: Use template to render language section In process surface translated article titles since we have that additional information available. Change-Id: Iae272dcf22ccc9739f5da3399c167ef3a5753fc9
commit 7586ca9c9b028c57ba99cfba8672689e4815e33f Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 21 16:20:46 2013 -0700
Ensure mobile.stable.styles loads at top Currently it seems to be loading at the bottom causing flashes of unstyled content Change-Id: I17140e0e85086b9caca3045fa1332d5fdadc9296
commit 62e91c5a23582590cd9a67e11a0cf363b98c9dec Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Mar 21 22:41:49 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I2501e79b3a45a295c769286570a4e6b2be968c75
commit 149f609e7481979bb9385cabb7c51b98d267c3e1 Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 7 09:10:39 2013 -0800
Maintenance: Load minimum possible css / reorg css The key change this makes is it stops loading unused css for non javascript users. All of css is loaded via javascript as needed * Move css specific to Special:MobileMenu into its own css file * Put all essential css for non-javascript users into ui.css and hamburger.css t(for the left menu) Load all javascript dependant css in javascript * Define mobile.styles.page and put all styles that are not relevant to special pages there * Combine less statements for readability Change-Id: Ie6a54403739065998e2108a15f38acfb6019e286
commit f6e2305b9c602125d39f6746a50315d9acd4c39c Author: awjrichards <arichards@wikimedia.org> Date: Thu Mar 7 01:21:48 2013 +0100
(mingle #410) Add X-Analytics request/response header handling support This change will cause MF to add analytics info to X-Analytics response header when user is in alpha or beta, and/or if there is an X-Analytics request header (in WMF production, this will happen if the user is accessing the site via ZeroRatedMobileAccess). The X-Analytics response header will only be set if the aforementioned criteria are met, AND wgMFEnableXAnalyticsLogging (added in this changeset) is set to true. In the longer term, it would be good to move the X-Analytics response header handling into core, perhaps into OutputPage - but since Zero and MobileFrontend are the only components currently using the X-Analytics analytics headers, it seemed prudent and more expedient to start with the handling in MobileFrontend. Relates to change: I14973cce2d2e80f480aabefa2dfbbfd5936db6cb Change-Id: I93758fc76721d89f9c32a28c1821f3e59eb384ef
commit 83f742f01ae48e2bc11906eb937202deb2d68fc9 Author: jrobson <jrobson@wikimedia.org> Date: Tue Mar 12 14:02:54 2013 -0500
Disable photo upload menu item when unusuable Disable photo upload menu item when a user is incapable of uploading Going forward we will probably want to use this for nearby menu too Change-Id: I6afb3f30fa2ab2e8d83aa95af6d0c135aee621df
commit 9a71adda96a56b677ea377820d37f3c917d07b62 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Mar 21 02:34:34 2013 +0400
Fix funny bracketing fail Change-Id: I5b10e44e82d242bc9b07f7c848c37af991198f0e
commit 7a985ad2eb6a918cf46b7de9c93d02c046fb6359 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Mar 20 20:55:37 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I269a08964b5e38777c0402032e9bb4a409ed9527
commit 193783da97dddc1d2f45475b996af7228fdfc725 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Mar 21 00:48:11 2013 +0400
Rm bogus CSS We do it in MobileFormatter ATM, and <video> should be handled uniformly on all devices Change-Id: I533fd388aa3aca10f3d5bf2ecbae5c0ae00d6d6f
commit 4a45abe1017b8ee580b575a42633799d91c18792 Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 14 11:57:20 2013 -0500
Story 347: Provide nicer filenames Filenames are descriptions with date appended accurate to minutes Change-Id: I8b5f2a78b9f73a23abc505ac424ab3926b81bf6d
commit fd5cf16b0af07ff18c5caba3f0439516b6acffa3 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 18 14:52:37 2013 -0700
Regression: Correct counter on photos dashboard
Shows 12 rather than 12
Change-Id: I8a18973c6c115beac626df9581753b85c5dd2f6c
commit 73914ab499e121bfb74aec4b89f9998546c3e650 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Wed Mar 20 14:22:41 2013 +0100
Workarond for Sauce Labs Android driver bug "Selenium_user" for some reason becomes "SELENIUM_user", but only on Sauce Labs+Android. Works just fine for other browsers and on a local Android driver. I have reported the bug to Sauce Labs and they are working on it. Bug: 46223 Change-Id: I99f51f63b248c9fef739b0ff47a6ecf8e2009acb
commit f8360d964ff993c6a16fea1c9d3a42e58475b5ae Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Wed Mar 20 10:33:23 2013 +0100
Updated Ruby gems Change-Id: Ica40deaf8073bbb111a77d89951ade50dfb84154
commit 513bde20604d4887c1558ac693d9a7140221cdef Author: jrobson <jrobson@wikimedia.org> Date: Thu Feb 28 11:11:45 2013 -0800
Alpha: Nicer diffs (character granularity) Some diffs are impossible to read in the current setup if an editor adds a word or adds punctuation. This change uses javascript to process them into a readable fashion Highly experimental and possibly bugs Change-Id: I397f93e341cf1daed646b75bf86c566c126f92a3
commit 93ac86e5098f472c7ae9ba579ff7f88697fc6b24 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Mar 19 21:39:06 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I95edadb3f6652fe7b6712427d148ad7522989a2b
commit 318c145455db0bb6ed7886c83ff81aff5350f851 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Mon Mar 18 20:34:37 2013 +0100
Makes it easy to create new Jenkins job to run Selenium tests from MobileFrontend repository Bug: 46219 Change-Id: I86e7b5d3a6fcf212cbaa3b7f35907369380e74a5